Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0035368
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2017-02-27 12:332017-03-15 14:12
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision79aa23e54130
ProjectionnoneETAnoneTarget VersionRR17Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035368: Not possible to log in the Web POS if there are resolved errors in the Errors While Importing POS data window

DescriptionSince the change done for this issue: https://issues.openbravo.com/view.php?id=34586, [^] it's no longer possible to log in the Web POS if there are pending errors in the Errors window. This is correct. However, the check also raises in case the errors existed but are now resolved, and this is not correct, as in this case the system is in safe state, and login should be allowed.
Steps To Reproduce- Log in the Web POS.
- Force a cashup error (for example, add "if(1==1) throw new OBException("Boom");" to the ProcessCashClose.java class).
- Execute the cashup process. Notice that the cashup goes to the Errors While Importing POS data window.
- Clear the cache and try to log in the Web POS. Notice that the following message appears: "Error in previous cashup"
- Remove the code which causes the error.
- Save Again the error in the Window. Notice the error changes to "Saved successfully"
- Try to login in the Web POS again. Notice that the same message appears again. This is not correct.
Proposed SolutionThe query should filter by errors in "Error" status.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0035367RR17Q2 closedmarvintm Not possible to log in the Web POS if there are resolved errors in the Errors While Importing POS data window 

-  Notes
(0094740)
hgbot (developer)
2017-03-03 14:38

Repository: retail/backports/3.0RR17Q1/org.openbravo.retail.posterminal
Changeset: 79aa23e5413002749f119dc22b8771a140621f39
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Mar 03 14:36:56 2017 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q1/org.openbravo.retail.posterminal/rev/79aa23e5413002749f119dc22b8771a140621f39 [^]

Fixed issue 35368. Query to find errors will now get only the non-saved errors.

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
---
(0094741)
hgbot (developer)
2017-03-03 14:45

Repository: retail/backports/3.0RR17Q1/pi-mobile
Changeset: 2e0795c1f91daeb07b6c6ec25fa24186bd7776ae
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Mar 03 14:45:07 2017 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q1/pi-mobile/rev/2e0795c1f91daeb07b6c6ec25fa24186bd7776ae [^]

Related to issue 35368. Adapted test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I34586_CashupErrorLoginRestricted.java
---
(0095046)
hgbot (developer)
2017-03-15 14:12

Repository: tools/automation/pi-mobile
Changeset: 2e0795c1f91daeb07b6c6ec25fa24186bd7776ae
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Mar 03 14:45:07 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2e0795c1f91daeb07b6c6ec25fa24186bd7776ae [^]

Related to issue 35368. Adapted test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I34586_CashupErrorLoginRestricted.java
---

- Issue History
Date Modified Username Field Change
2017-02-27 12:33 marvintm Type defect => backport
2017-02-27 12:33 marvintm Target Version RR17Q2 => RR17Q1
2017-03-03 14:38 hgbot Checkin
2017-03-03 14:38 hgbot Note Added: 0094740
2017-03-03 14:38 hgbot Status scheduled => resolved
2017-03-03 14:38 hgbot Resolution open => fixed
2017-03-03 14:38 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR17Q1/org.openbravo.retail.posterminal/rev/79aa23e5413002749f119dc22b8771a140621f39 [^]
2017-03-03 14:45 hgbot Checkin
2017-03-03 14:45 hgbot Note Added: 0094741
2017-03-07 16:01 guilleaer Review Assigned To => guilleaer
2017-03-07 16:01 guilleaer Status resolved => closed
2017-03-07 16:01 guilleaer Fixed in Version => RR17Q1
2017-03-15 14:12 hgbot Checkin
2017-03-15 14:12 hgbot Note Added: 0095046


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker