Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0035367

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2017-02-27 12:33

2017-03-15 08:50

Reporter

marvintm

View Status

public

Assigned To

marvintm

Priority

normal

Resolution

fixed

Fixed in Version

RR17Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

RR17Q2

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

guilleaer

Regression level

Packaging and release

Regression date

2016-12-06

Regression introduced in release

main

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/02c6c8e2af1710fd1ca9e865b55ed7996fe6151a [^]

Triggers an Emergency Pack

No

Summary

0035367: Not possible to log in the Web POS if there are resolved errors in the Errors While Importing POS data window

Description

Since the change done for this issue: https://issues.openbravo.com/view.php?id=34586, [^] it's no longer possible to log in the Web POS if there are pending errors in the Errors window. This is correct. However, the check also raises in case the errors existed but are now resolved, and this is not correct, as in this case the system is in safe state, and login should be allowed.

Steps To Reproduce

- Log in the Web POS.
- Force a cashup error (for example, add "if(1==1) throw new OBException("Boom");" to the ProcessCashClose.java class).
- Execute the cashup process. Notice that the cashup goes to the Errors While Importing POS data window.
- Clear the cache and try to log in the Web POS. Notice that the following message appears: "Error in previous cashup"
- Remove the code which causes the error.
- Save Again the error in the Window. Notice the error changes to "Saved successfully"
- Try to login in the Web POS again. Notice that the same message appears again. This is not correct.

Proposed Solution

The query should filter by errors in "Error" status.

Tags

No tags attached.

issue35367.diff [^] (698 bytes) 2017-02-27 12:43 [Show Content] [Hide Content]

diff -r c04938eafe0f src/org/openbravo/retail/posterminal/master/Cashup.java
--- a/src/org/openbravo/retail/posterminal/master/Cashup.java	Thu Feb 23 17:47:42 2017 +0530
+++ b/src/org/openbravo/retail/posterminal/master/Cashup.java	Mon Feb 27 12:42:35 2017 +0100
@@ -139,6 +139,7 @@
         OBPOSErrors.class);
     errorsInPOSWindow.add(Restrictions.eq(OBPOSErrors.PROPERTY_OBPOSAPPLICATIONS, terminal));
     errorsInPOSWindow.add(Restrictions.eq(OBPOSErrors.PROPERTY_TYPEOFDATA, "OBPOS_App_Cashup"));
+    errorsInPOSWindow.add(Restrictions.eq(OBPOSErrors.PROPERTY_ORDERSTATUS, "N"));
     errorsInPOSWindow.setMaxResults(1);
     if (errorsInPOSWindow.list().size() > 0) {
       return true;

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0035368	RR17Q1	closed	marvintm	Not possible to log in the Web POS if there are resolved errors in the Errors While Importing POS data window
caused by	defect	0034586		closed	marvintm	it is posible to create receipts related with processed cashup

Notes
(0094738) hgbot (developer) 2017-03-03 14:33	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: df806b7997dc845ea8eb9d67a1c431a9cc408866 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Feb 28 08:16:43 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/df806b7997dc845ea8eb9d67a1c431a9cc408866 [^] Fixed issue 35367. Query to find errors will now get only the non-saved errors. --- M src/org/openbravo/retail/posterminal/master/Cashup.java ---

(0094739) hgbot (developer) 2017-03-03 14:34	Repository: tools/automation/pi-mobile Changeset: 68ea938d32da63a4e2a20a1d0d1dfb10ae9eb717 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Mon Feb 27 18:47:05 2017 +0100 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/68ea938d32da63a4e2a20a1d0d1dfb10ae9eb717 [^] Related to issue 35367. Adapted test --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I34586_CashupErrorLoginRestricted.java ---

Issue History
Date Modified	Username	Field	Change
2017-02-27 12:33	marvintm	New Issue
2017-02-27 12:33	marvintm	Assigned To	=> marvintm
2017-02-27 12:33	marvintm	Triggers an Emergency Pack	=> No
2017-02-27 12:33	marvintm	Status	new => scheduled
2017-02-27 12:34	marvintm	Regression level	=> Packaging and release
2017-02-27 12:34	marvintm	Regression date	=> 2016-12-06
2017-02-27 12:34	marvintm	Regression introduced in release	=> main
2017-02-27 12:34	marvintm	Regression introduced by commit	=> https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/02c6c8e2af1710fd1ca9e865b55ed7996fe6151a [^]
2017-02-27 12:34	marvintm	Relationship added	caused by 0034586
2017-02-27 12:43	marvintm	File Added: issue35367.diff
2017-03-03 14:33	hgbot	Checkin
2017-03-03 14:33	hgbot	Note Added: 0094738
2017-03-03 14:33	hgbot	Status	scheduled => resolved
2017-03-03 14:33	hgbot	Resolution	open => fixed
2017-03-03 14:33	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/df806b7997dc845ea8eb9d67a1c431a9cc408866 [^]
2017-03-03 14:34	hgbot	Checkin
2017-03-03 14:34	hgbot	Note Added: 0094739
2017-03-15 08:50	guilleaer	Review Assigned To	=> guilleaer
2017-03-15 08:50	guilleaer	Status	resolved => closed
2017-03-15 08:50	guilleaer	Fixed in Version	=> RR17Q2

Copyright © 2000 - 2009 MantisBT Group