Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035322 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2017-02-21 12:14 | 2017-03-13 09:00 | |||
| Reporter | adrianromero | View Status | public | |||||
| Assigned To | mario_castello | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR17Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e020e081b204 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035322: [SER-QA 2479] Credit amount calculation and formatting is not done properly | |||||||
| Description | Credit amount calculation and comparison must be done using OB.DEC.sub and OB.DEC.compare: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/796f4eab7e93/web/org.openbravo.retail.posterminal/js/model/order.js#l4507 [^] Displaying credit amount must be done using OB.I18N.formatCurrency https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/796f4eab7e93/web/org.openbravo.retail.posterminal/js/components/order.js#l650 [^] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/796f4eab7e93/web/org.openbravo.retail.posterminal/js/components/order.js#l663 [^] | |||||||
| Steps To Reproduce | In description | |||||||
| Proposed Solution | See attached patch | |||||||
| Tags | SER-QA | |||||||
| Attached Files |  issue35322.export [^] (3,265 bytes) 2017-02-21 12:20 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0094953) hgbot (developer) 2017-03-10 21:10 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e020e081b20457c52de805c4179eae52ecb34f89 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Fri Mar 10 09:45:47 2017 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e020e081b20457c52de805c4179eae52ecb34f89 [^] Fixed issue 0035322: [SER-QA 2479] Credit amount calculation and formatting is not done properly - Refactor the calculate of credit amount and the comparison using OB.DEC.sub and OB.DEC.compare - Added correct format when show the value --- M web/org.openbravo.retail.posterminal/js/components/order.js M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0094954) hgbot (developer) 2017-03-10 21:16 |
Repository: tools/automation/pi-mobile Changeset: fa3bd34c92b70251e3576923873614e786006fdd Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Fri Mar 10 10:13:15 2017 -0600 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fa3bd34c92b70251e3576923873614e786006fdd [^] Verifies issue 35322: Fixed affected tests by this changes - Updated Copyright - Refactor and fixed test ReversePaymentOnPartiallyPaidOnCredit - Refactor and fixed test ReversePaymentPaidOnCreditWithCredit - Refactor and fixed test I31600_VerfiyPaidOnCredit --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/reversepayments/ReversePaymentOnPartiallyPaidOnCredit.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/reversepayments/ReversePaymentPaidOnCreditWithCredit.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31600_VerfiyPaidOnCredit.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-02-21 12:14 | adrianromero | New Issue | |
| 2017-02-21 12:14 | adrianromero | Assigned To | => Retail |
| 2017-02-21 12:14 | adrianromero | Resolution time | => 1488841200 |
| 2017-02-21 12:14 | adrianromero | Triggers an Emergency Pack | => No |
| 2017-02-21 12:17 | adrianromero | Tag Attached: SER-QA | |
| 2017-02-21 12:20 | adrianromero | File Added: issue35322.export | |
| 2017-02-21 19:26 | mario_castello | Assigned To | Retail => mario_castello |
| 2017-02-21 19:27 | mario_castello | Status | new => acknowledged |
| 2017-02-21 19:27 | mario_castello | Status | acknowledged => scheduled |
| 2017-03-10 21:10 | hgbot | Checkin | |
| 2017-03-10 21:10 | hgbot | Note Added: 0094953 | |
| 2017-03-10 21:10 | hgbot | Status | scheduled => resolved |
| 2017-03-10 21:10 | hgbot | Resolution | open => fixed |
| 2017-03-10 21:10 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e020e081b20457c52de805c4179eae52ecb34f89 [^] |
| 2017-03-10 21:16 | hgbot | Checkin | |
| 2017-03-10 21:16 | hgbot | Note Added: 0094954 | |
| 2017-03-13 09:00 | marvintm | Review Assigned To | => marvintm |
| 2017-03-13 09:00 | marvintm | Status | resolved => closed |
| 2017-03-13 09:00 | marvintm | Fixed in Version | => RR17Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |