0035322: [SER-QA 2479] Credit amount calculation and formatting is not done properly

Openbravo Issue Tracking System - Retail Modules
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0035322	Retail Modules	Web POS	public	2017-02-21 12:14	2017-03-13 09:00

Reporter	adrianromero
Assigned To	mario_castello
Priority	urgent	Severity	major	Reproducibility	have not tried
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version	RR17Q2
Merge Request Status
Review Assigned To	marvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0035322: [SER-QA 2479] Credit amount calculation and formatting is not done properly
Description	Credit amount calculation and comparison must be done using OB.DEC.sub and OB.DEC.compare: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/796f4eab7e93/web/org.openbravo.retail.posterminal/js/model/order.js#l4507 [^] Displaying credit amount must be done using OB.I18N.formatCurrency https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/796f4eab7e93/web/org.openbravo.retail.posterminal/js/components/order.js#l650 [^] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/796f4eab7e93/web/org.openbravo.retail.posterminal/js/components/order.js#l663 [^]
Steps To Reproduce	In description
Proposed Solution	See attached patch
Additional Information
Tags	SER-QA
Relationships
Attached Files	issue35322.export (3,265) 2017-02-21 12:20 https://issues.openbravo.com/file_download.php?file_id=10470&type=bug

Issue History
Date Modified	Username	Field	Change
2017-02-21 12:14	adrianromero	New Issue
2017-02-21 12:14	adrianromero	Assigned To	=> Retail
2017-02-21 12:14	adrianromero	Resolution time	=> 1488841200
2017-02-21 12:14	adrianromero	Triggers an Emergency Pack	=> No
2017-02-21 12:17	adrianromero	Tag Attached: SER-QA
2017-02-21 12:20	adrianromero	File Added: issue35322.export
2017-02-21 19:26	mario_castello	Assigned To	Retail => mario_castello
2017-02-21 19:27	mario_castello	Status	new => acknowledged
2017-02-21 19:27	mario_castello	Status	acknowledged => scheduled
2017-03-10 21:10	hgbot	Checkin
2017-03-10 21:10	hgbot	Note Added: 0094953
2017-03-10 21:10	hgbot	Status	scheduled => resolved
2017-03-10 21:10	hgbot	Resolution	open => fixed
2017-03-10 21:10	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e020e081b20457c52de805c4179eae52ecb34f89 [^]
2017-03-10 21:16	hgbot	Checkin
2017-03-10 21:16	hgbot	Note Added: 0094954
2017-03-13 09:00	marvintm	Review Assigned To	=> marvintm
2017-03-13 09:00	marvintm	Status	resolved => closed
2017-03-13 09:00	marvintm	Fixed in Version	=> RR17Q2

Notes