Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035297
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Y. DBSourceManagerminorhave not tried2017-02-17 12:132017-03-15 20:19
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revisionc1c9fcb3f14f
ProjectionnoneETAnoneTarget Version
OSAnyDatabasePostgreSQLJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035297: PL functions with optional constant params are not correctly standardized

DescriptionIf there is a PL function with an optional parameter that is a constant (ie. 'Y') and another one invokes it without sending this optional parameter, second function is no correctly standardized making it not possible to install it later in oracle.
Steps To Reproduce1. apply attached patch on pi (rev aff21cc5e768)
2. update.database
3. export.database
  -> check M_RESERVE_STOCK_AUTO function has differences and it shouldn't
TagsNo tags attached.
Attached Filesdiff file icon m_get_stock_param2.diff [^] (974 bytes) 2017-02-17 12:15 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 0035296 closedalostale pl functions with out and defaults params can be slow to standardize 

-  Notes
(0094472)
hgbot (developer)
2017-02-20 14:49

 Repository: erp/devel/pi
Changeset: 490d93599594dac190b9711b1a43054ad51cf025
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 17 12:34:43 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^]

fixed bug 35284, fixed bug 35297, fixed bug 35296

  dbsourcemanager.jar including fixes for these 3 issues.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0094474)
hgbot (developer)
2017-02-20 14:49

 Repository: erp/devel/dbsm-main
Changeset: c1c9fcb3f14f89b7430fca2867d11758ee47b164
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 17 12:28:59 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/c1c9fcb3f14f89b7430fca2867d11758ee47b164 [^]

fixed bug 35297: PL with optional constant params is not correctly standardized

  The standardization tranforms slect in a function call, the number of different
  expressions should be function of the number of optional paramters, but it was
  considering optional paramters only in case the default value was either null
  or a function, but not a constant.

---
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLStandarization.java
---
(0094653)
caristu (viewer)
2017-02-28 08:55

 Reviewed + tested in pi@1e7495658970
(0095196)
hudsonbot (viewer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-02-17 12:13 alostale New Issue
2017-02-17 12:13 alostale Assigned To => platform
2017-02-17 12:13 alostale OBNetwork customer => No
2017-02-17 12:13 alostale Modules => Core
2017-02-17 12:13 alostale Triggers an Emergency Pack => No
2017-02-17 12:14 alostale Relationship added depends on 0035296
2017-02-17 12:14 alostale Assigned To platform => alostale
2017-02-17 12:14 alostale Status new => acknowledged
2017-02-17 12:15 alostale File Added: m_get_stock_param2.diff
2017-02-17 12:15 alostale Steps to Reproduce Updated View Revisions
2017-02-20 14:49 hgbot Checkin
2017-02-20 14:49 hgbot Note Added: 0094472
2017-02-20 14:49 hgbot Status acknowledged => resolved
2017-02-20 14:49 hgbot Resolution open => fixed
2017-02-20 14:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^]
2017-02-20 14:49 hgbot Checkin
2017-02-20 14:49 hgbot Note Added: 0094474
2017-02-20 14:49 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/c1c9fcb3f14f89b7430fca2867d11758ee47b164 [^]
2017-02-20 14:50 alostale Review Assigned To => caristu
2017-02-28 08:55 caristu Note Added: 0094653
2017-02-28 08:55 caristu Status resolved => closed
2017-02-28 08:55 caristu Fixed in Version => 3.0PR17Q2
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095196

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker