Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035297Openbravo ERPY. DBSourceManagerpublic2017-02-17 12:132017-03-15 20:19
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035297: PL functions with optional constant params are not correctly standardized
DescriptionIf there is a PL function with an optional parameter that is a constant (ie. 'Y') and another one invokes it without sending this optional parameter, second function is no correctly standardized making it not possible to install it later in oracle.
Steps To Reproduce1. apply attached patch on pi (rev aff21cc5e768)
2. update.database
3. export.database
  -> check M_RESERVE_STOCK_AUTO function has differences and it shouldn't
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0035296 closed alostale pl functions with out and defaults params can be slow to standardize 
Attached Filesdiff m_get_stock_param2.diff (974) 2017-02-17 12:15
https://issues.openbravo.com/file_download.php?file_id=10461&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-02-17 12:13alostaleNew Issue
2017-02-17 12:13alostaleAssigned To => platform
2017-02-17 12:13alostaleOBNetwork customer => No
2017-02-17 12:13alostaleModules => Core
2017-02-17 12:13alostaleTriggers an Emergency Pack => No
2017-02-17 12:14alostaleRelationship addeddepends on 0035296
2017-02-17 12:14alostaleAssigned Toplatform => alostale
2017-02-17 12:14alostaleStatusnew => acknowledged
2017-02-17 12:15alostaleFile Added: m_get_stock_param2.diff
2017-02-17 12:15alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14630#r14630
2017-02-20 14:49hgbotCheckin
2017-02-20 14:49hgbotNote Added: 0094472
2017-02-20 14:49hgbotStatusacknowledged => resolved
2017-02-20 14:49hgbotResolutionopen => fixed
2017-02-20 14:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^]
2017-02-20 14:49hgbotCheckin
2017-02-20 14:49hgbotNote Added: 0094474
2017-02-20 14:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/c1c9fcb3f14f89b7430fca2867d11758ee47b164 [^]
2017-02-20 14:50alostaleReview Assigned To => caristu
2017-02-28 08:55caristuNote Added: 0094653
2017-02-28 08:55caristuStatusresolved => closed
2017-02-28 08:55caristuFixed in Version => 3.0PR17Q2
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095196

Notes
(0094472)
hgbot   
2017-02-20 14:49   
Repository: erp/devel/pi
Changeset: 490d93599594dac190b9711b1a43054ad51cf025
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 17 12:34:43 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^]

fixed bug 35284, fixed bug 35297, fixed bug 35296

  dbsourcemanager.jar including fixes for these 3 issues.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0094474)
hgbot   
2017-02-20 14:49   
Repository: erp/devel/dbsm-main
Changeset: c1c9fcb3f14f89b7430fca2867d11758ee47b164
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 17 12:28:59 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/c1c9fcb3f14f89b7430fca2867d11758ee47b164 [^]

fixed bug 35297: PL with optional constant params is not correctly standardized

  The standardization tranforms slect in a function call, the number of different
  expressions should be function of the number of optional paramters, but it was
  considering optional paramters only in case the default value was either null
  or a function, but not a constant.

---
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLStandarization.java
---
(0094653)
caristu   
2017-02-28 08:55   
Reviewed + tested in pi@1e7495658970
(0095196)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test