Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035284
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2017-02-16 14:232017-03-15 20:19
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revision490d93599594
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035284: update.database unnecessarily standardizes DB PL code

Descriptionupdate.database process reads DB model in order to compare it with XML definition to find model differences. This comparison is not performed for PL as it is always recreated, but when reading the model it performs the standardization.
Steps To Reproduce1. run ant update.database
2. check in log:
   ...
   [java] 6905 INFO - Starting function trigger and view standardization in 2 threads
   [java] 13882 INFO - Standardidized 298 functions, 317 triggers and 47 views in 6977 ms
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 00346543.0PR17Q2 closedalostale some performance improvements in DBSM tasks 
related to defect 0035296 closedalostale pl functions with out and defaults params can be slow to standardize 
causes defect 0036473 closedalostale unnecessary recreation of PL code in update.database 

-  Notes
(0094468)
hgbot (developer)
2017-02-20 14:49

 Repository: erp/devel/dbsm-main
Changeset: 09172053fd892f54d5b2180b7a751df353041b9e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Feb 16 14:24:08 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/09172053fd892f54d5b2180b7a751df353041b9e [^]

fixed issue 35284: update.database unnecessarily standardizes DB PL code

  Do not standardize PL when updating db as it's not used.

---
M src/org/openbravo/ddlutils/task/AlterDatabaseDataAll.java
---
(0094471)
hgbot (developer)
2017-02-20 14:49

 Repository: erp/devel/pi
Changeset: 490d93599594dac190b9711b1a43054ad51cf025
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 17 12:34:43 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^]

fixed bug 35284, fixed bug 35297, fixed bug 35296

  dbsourcemanager.jar including fixes for these 3 issues.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0094641)
hgbot (developer)
2017-02-27 13:56

 Repository: erp/devel/dbsm-main
Changeset: 966a26100d3d7c3fad961c8e92e29a890649c26b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Feb 27 13:55:56 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/966a26100d3d7c3fad961c8e92e29a890649c26b [^]

related to issue 35284: apply fix in DbsmTest

---
M src-test/src/org/openbravo/dbsm/test/base/DbsmTest.java
---
(0094642)
caristu (developer)
2017-02-27 14:01

 Code reviewed + tested in pi@1f961fdb2035.
(0095195)
hudsonbot (developer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-02-16 14:23 alostale New Issue
2017-02-16 14:23 alostale Assigned To => alostale
2017-02-16 14:23 alostale Modules => Core
2017-02-16 14:23 alostale Triggers an Emergency Pack => No
2017-02-16 14:29 alostale Relationship added related to 0034654
2017-02-16 14:29 alostale Tag Attached: Performance
2017-02-16 14:29 alostale Status new => acknowledged
2017-02-16 14:30 alostale Steps to Reproduce Updated View Revisions
2017-02-17 12:09 alostale Relationship added related to 0035296
2017-02-20 14:49 hgbot Checkin
2017-02-20 14:49 hgbot Note Added: 0094468
2017-02-20 14:49 hgbot Status acknowledged => resolved
2017-02-20 14:49 hgbot Resolution open => fixed
2017-02-20 14:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/09172053fd892f54d5b2180b7a751df353041b9e [^]
2017-02-20 14:49 hgbot Checkin
2017-02-20 14:49 hgbot Note Added: 0094471
2017-02-20 14:49 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/dbsm-main/rev/09172053fd892f54d5b2180b7a751df353041b9e [^] => http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^]
2017-02-20 14:50 alostale Review Assigned To => caristu
2017-02-27 13:56 hgbot Checkin
2017-02-27 13:56 hgbot Note Added: 0094641
2017-02-27 14:01 caristu Note Added: 0094642
2017-02-27 14:01 caristu Status resolved => closed
2017-02-27 14:01 caristu Fixed in Version => 3.0PR17Q2
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095195
2017-07-12 12:03 alostale Relationship added causes 0036473

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker