Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035284Openbravo ERPA. Platformpublic2017-02-16 14:232017-03-15 20:19
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035284: update.database unnecessarily standardizes DB PL code
Descriptionupdate.database process reads DB model in order to compare it with XML definition to find model differences. This comparison is not performed for PL as it is always recreated, but when reading the model it performs the standardization.
Steps To Reproduce1. run ant update.database
2. check in log:
   ...
   [java] 6905 INFO - Starting function trigger and view standardization in 2 threads
   [java] 13882 INFO - Standardidized 298 functions, 317 triggers and 47 views in 6977 ms
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to feature request 00346543.0PR17Q2 closed alostale some performance improvements in DBSM tasks 
related to defect 0035296 closed alostale pl functions with out and defaults params can be slow to standardize 
causes defect 0036473 closed alostale unnecessary recreation of PL code in update.database 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-16 14:23alostaleNew Issue
2017-02-16 14:23alostaleAssigned To => alostale
2017-02-16 14:23alostaleModules => Core
2017-02-16 14:23alostaleTriggers an Emergency Pack => No
2017-02-16 14:29alostaleRelationship addedrelated to 0034654
2017-02-16 14:29alostaleTag Attached: Performance
2017-02-16 14:29alostaleStatusnew => acknowledged
2017-02-16 14:30alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14621#r14621
2017-02-17 12:09alostaleRelationship addedrelated to 0035296
2017-02-20 14:49hgbotCheckin
2017-02-20 14:49hgbotNote Added: 0094468
2017-02-20 14:49hgbotStatusacknowledged => resolved
2017-02-20 14:49hgbotResolutionopen => fixed
2017-02-20 14:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/09172053fd892f54d5b2180b7a751df353041b9e [^]
2017-02-20 14:49hgbotCheckin
2017-02-20 14:49hgbotNote Added: 0094471
2017-02-20 14:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/09172053fd892f54d5b2180b7a751df353041b9e [^] => http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^]
2017-02-20 14:50alostaleReview Assigned To => caristu
2017-02-27 13:56hgbotCheckin
2017-02-27 13:56hgbotNote Added: 0094641
2017-02-27 14:01caristuNote Added: 0094642
2017-02-27 14:01caristuStatusresolved => closed
2017-02-27 14:01caristuFixed in Version => 3.0PR17Q2
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095195
2017-07-12 12:03alostaleRelationship addedcauses 0036473

Notes
(0094468)
hgbot   
2017-02-20 14:49   
Repository: erp/devel/dbsm-main
Changeset: 09172053fd892f54d5b2180b7a751df353041b9e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Feb 16 14:24:08 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/09172053fd892f54d5b2180b7a751df353041b9e [^]

fixed issue 35284: update.database unnecessarily standardizes DB PL code

  Do not standardize PL when updating db as it's not used.

---
M src/org/openbravo/ddlutils/task/AlterDatabaseDataAll.java
---
(0094471)
hgbot   
2017-02-20 14:49   
Repository: erp/devel/pi
Changeset: 490d93599594dac190b9711b1a43054ad51cf025
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 17 12:34:43 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/490d93599594dac190b9711b1a43054ad51cf025 [^]

fixed bug 35284, fixed bug 35297, fixed bug 35296

  dbsourcemanager.jar including fixes for these 3 issues.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0094641)
hgbot   
2017-02-27 13:56   
Repository: erp/devel/dbsm-main
Changeset: 966a26100d3d7c3fad961c8e92e29a890649c26b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Feb 27 13:55:56 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/966a26100d3d7c3fad961c8e92e29a890649c26b [^]

related to issue 35284: apply fix in DbsmTest

---
M src-test/src/org/openbravo/dbsm/test/base/DbsmTest.java
---
(0094642)
caristu   
2017-02-27 14:01   
Code reviewed + tested in pi@1f961fdb2035.
(0095195)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test