Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035258
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Y. DBSourceManagerminoralways2017-02-14 13:082017-03-15 20:19
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revision82274fe3c23e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-01-20
Regression introduced in release3.0PR16Q2
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/9cbd94b17c8829193f42387b92d1d098b018637f [^]
Triggers an Emergency PackNo
Summary

0035258: NullPointerException thrown when updating database having a wrong declaration in exclude filters

DescriptionA NullPointerException is thrown when updating the database having an exclude filter file with a line which does not define the name of the excluded object. For example:

<excludedTable name=""/>

Although this is NOT a valid configuration and the exclude filter file should not contain this kind of lines, DBSM should ignore such line instead of throwing a NPE.

The NPE exception raised:

 [java] java.lang.NullPointerException
     [java] at org.apache.ddlutils.platform.ModelLoaderBase.closeMetadataSentences(ModelLoaderBase.java:169)
     [java] at org.apache.ddlutils.platform.postgresql.PostgreSqlModelLoader.closeMetadataSentences(PostgreSqlModelLoader.java:441)
     [java] at org.apache.ddlutils.platform.ModelLoaderBase.getDatabase(ModelLoaderBase.java:134)
     [java] at org.apache.ddlutils.platform.PlatformImplBase.loadModelFromDatabase(PlatformImplBase.java:2335)
     [java] at org.apache.ddlutils.platform.PlatformImplBase.loadModelFromDatabase(PlatformImplBase.java:2326)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:131)
     [java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:86)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseJava.main(AlterDatabaseJava.java:57)
....
Steps To Reproduce1) Apply the attached path which adds this line <excludedTable name=""/> into the core exclude filter file

2) Run ant update.database
TagsNo tags attached.
Attached Filesdiff file icon wrongExcludedObject.diff [^] (399 bytes) 2017-02-14 13:38 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0031685 closedAugustoMauch Allow using SQL wildcards in the dbsourmanager exclude filter 

-  Notes
(0094312)
hgbot (developer)
2017-02-14 13:38

 Repository: erp/devel/dbsm-main
Changeset: 82274fe3c23e7c337940c9151f055916c7630e3d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Feb 14 13:30:56 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/82274fe3c23e7c337940c9151f055916c7630e3d [^]

fixes bug 35258: NPE on update.database having wrong exclusion in excludeFilter

A NPE was thrown in update.database task, having an exclusion in the excludeFilter file which was leaving the object name empty. The exception was being thrown when looking for elements using wildcard expressions. This exception is now avoided.

---
M src/org/apache/ddlutils/platform/ExcludeFilter.java
---
(0094313)
hgbot (developer)
2017-02-14 13:46

 Repository: erp/devel/pi
Changeset: ffd201fa609efe7e1cfd60e44cb2699c7f9f8fa3
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Feb 14 13:43:51 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ffd201fa609efe7e1cfd60e44cb2699c7f9f8fa3 [^]

related to bug 35258: updated dbsourcemanager library

---
M src-db/database/lib/dbsourcemanager.jar
---
(0094427)
alostale (viewer)
2017-02-17 07:28

 reviewed
(0094428)
alostale (viewer)
2017-02-17 07:33

 Not backporting because the issue is minor, and should not have a big impact as it to fail requires of already incorrectly defined filters.
(0095182)
hudsonbot (viewer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-02-14 13:08 caristu New Issue
2017-02-14 13:08 caristu Assigned To => platform
2017-02-14 13:08 caristu OBNetwork customer => No
2017-02-14 13:08 caristu Modules => Core
2017-02-14 13:08 caristu Triggers an Emergency Pack => No
2017-02-14 13:08 caristu Assigned To platform => caristu
2017-02-14 13:08 caristu Relationship added caused by 0031685
2017-02-14 13:12 caristu Description Updated View Revisions
2017-02-14 13:38 hgbot Checkin
2017-02-14 13:38 hgbot Note Added: 0094312
2017-02-14 13:38 hgbot Status new => resolved
2017-02-14 13:38 hgbot Resolution open => fixed
2017-02-14 13:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/82274fe3c23e7c337940c9151f055916c7630e3d [^]
2017-02-14 13:38 caristu File Added: wrongExcludedObject.diff
2017-02-14 13:46 hgbot Checkin
2017-02-14 13:46 hgbot Note Added: 0094313
2017-02-14 13:46 caristu Review Assigned To => alostale
2017-02-15 09:42 caristu Description Updated View Revisions
2017-02-17 07:28 alostale Note Added: 0094427
2017-02-17 07:28 alostale Status resolved => closed
2017-02-17 07:28 alostale Fixed in Version => 3.0PR17Q2
2017-02-17 07:31 alostale Regression level => Production - QA Approved
2017-02-17 07:31 alostale Regression date => 2016-01-20
2017-02-17 07:31 alostale Regression introduced in release => 3.0PR16Q2
2017-02-17 07:31 alostale Regression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/9cbd94b17c8829193f42387b92d1d098b018637f [^]
2017-02-17 07:32 alostale Regression level Production - QA Approved => Production - Confirmed Stable
2017-02-17 07:33 alostale Note Added: 0094428
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095182

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker