Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0035258 | Openbravo ERP | Y. DBSourceManager | public | 2017-02-14 13:08 | 2017-03-15 20:19 |
|
| Reporter | caristu | |
| Assigned To | caristu | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR17Q2 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | Production - Confirmed Stable |
| Regression date | 2016-01-20 |
| Regression introduced in release | 3.0PR16Q2 |
| Regression introduced by commit | http://code.openbravo.com/erp/devel/pi/rev/9cbd94b17c8829193f42387b92d1d098b018637f [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0035258: NullPointerException thrown when updating database having a wrong declaration in exclude filters |
| Description | A NullPointerException is thrown when updating the database having an exclude filter file with a line which does not define the name of the excluded object. For example:
<excludedTable name=""/>
Although this is NOT a valid configuration and the exclude filter file should not contain this kind of lines, DBSM should ignore such line instead of throwing a NPE.
The NPE exception raised:
[java] java.lang.NullPointerException
[java] at org.apache.ddlutils.platform.ModelLoaderBase.closeMetadataSentences(ModelLoaderBase.java:169)
[java] at org.apache.ddlutils.platform.postgresql.PostgreSqlModelLoader.closeMetadataSentences(PostgreSqlModelLoader.java:441)
[java] at org.apache.ddlutils.platform.ModelLoaderBase.getDatabase(ModelLoaderBase.java:134)
[java] at org.apache.ddlutils.platform.PlatformImplBase.loadModelFromDatabase(PlatformImplBase.java:2335)
[java] at org.apache.ddlutils.platform.PlatformImplBase.loadModelFromDatabase(PlatformImplBase.java:2326)
[java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:131)
[java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:86)
[java] at org.openbravo.ddlutils.task.AlterDatabaseJava.main(AlterDatabaseJava.java:57)
.... |
| Steps To Reproduce | 1) Apply the attached path which adds this line <excludedTable name=""/> into the core exclude filter file
2) Run ant update.database |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | caused by | feature request | 0031685 | | closed | AugustoMauch | Allow using SQL wildcards in the dbsourmanager exclude filter |
|
| Attached Files |  wrongExcludedObject.diff (399) 2017-02-14 13:38
https://issues.openbravo.com/file_download.php?file_id=10443&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-02-14 13:08 | caristu | New Issue | |
| 2017-02-14 13:08 | caristu | Assigned To | => platform |
| 2017-02-14 13:08 | caristu | OBNetwork customer | => No |
| 2017-02-14 13:08 | caristu | Modules | => Core |
| 2017-02-14 13:08 | caristu | Triggers an Emergency Pack | => No |
| 2017-02-14 13:08 | caristu | Assigned To | platform => caristu |
| 2017-02-14 13:08 | caristu | Relationship added | caused by 0031685 |
| 2017-02-14 13:12 | caristu | Description Updated | bug_revision_view_page.php?rev_id=14582#r14582 |
| 2017-02-14 13:38 | hgbot | Checkin | |
| 2017-02-14 13:38 | hgbot | Note Added: 0094312 | |
| 2017-02-14 13:38 | hgbot | Status | new => resolved |
| 2017-02-14 13:38 | hgbot | Resolution | open => fixed |
| 2017-02-14 13:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/dbsm-main/rev/82274fe3c23e7c337940c9151f055916c7630e3d [^] |
| 2017-02-14 13:38 | caristu | File Added: wrongExcludedObject.diff | |
| 2017-02-14 13:46 | hgbot | Checkin | |
| 2017-02-14 13:46 | hgbot | Note Added: 0094313 | |
| 2017-02-14 13:46 | caristu | Review Assigned To | => alostale |
| 2017-02-15 09:42 | caristu | Description Updated | bug_revision_view_page.php?rev_id=14594#r14594 |
| 2017-02-17 07:28 | alostale | Note Added: 0094427 | |
| 2017-02-17 07:28 | alostale | Status | resolved => closed |
| 2017-02-17 07:28 | alostale | Fixed in Version | => 3.0PR17Q2 |
| 2017-02-17 07:31 | alostale | Regression level | => Production - QA Approved |
| 2017-02-17 07:31 | alostale | Regression date | => 2016-01-20 |
| 2017-02-17 07:31 | alostale | Regression introduced in release | => 3.0PR16Q2 |
| 2017-02-17 07:31 | alostale | Regression introduced by commit | => http://code.openbravo.com/erp/devel/pi/rev/9cbd94b17c8829193f42387b92d1d098b018637f [^] |
| 2017-02-17 07:32 | alostale | Regression level | Production - QA Approved => Production - Confirmed Stable |
| 2017-02-17 07:33 | alostale | Note Added: 0094428 | |
| 2017-03-15 20:19 | hudsonbot | Checkin | |
| 2017-03-15 20:19 | hudsonbot | Note Added: 0095182 | |
|
Notes |
|
|
(0094312)
|
|
hgbot
|
|
2017-02-14 13:38
|
|
Repository: erp/devel/dbsm-main
Changeset: 82274fe3c23e7c337940c9151f055916c7630e3d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Feb 14 13:30:56 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/82274fe3c23e7c337940c9151f055916c7630e3d [^]
fixes bug 35258: NPE on update.database having wrong exclusion in excludeFilter
A NPE was thrown in update.database task, having an exclusion in the excludeFilter file which was leaving the object name empty. The exception was being thrown when looking for elements using wildcard expressions. This exception is now avoided.
---
M src/org/apache/ddlutils/platform/ExcludeFilter.java
---
|
|
|
|
(0094313)
|
|
hgbot
|
|
2017-02-14 13:46
|
|
|
|
|
|
|
|
|
|
|
Not backporting because the issue is minor, and should not have a big impact as it to fail requires of already incorrectly defined filters. |
|
|
|
|
|