Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0035191
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorrandom2017-02-07 17:582017-02-20 17:35
ReporterguillermogilView Statuspublic 
Assigned Tomarvintm 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisioneb0aecc1659e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035191: It is possible to have duplicated primary keys on WebSQL

DescriptionIt is possible to have duplicated primary keys on WebSQL if you have a lot of products with duplicated names and an small pagination.
When the query is done it orders by name and since there are a lot that have the same value it can rely on errors in WebPOS console and losses of some record.

It will be needed to review each masterdata to ensure the proper behavior of them.
Steps To ReproduceN/A
Proposed SolutionSee diff attached for product query and apply it on the other queries.
It is needed to order by a unique constraint.
TagsNo tags attached.
Attached Filesdiff file icon productQuery.diff [^] (1,951 bytes) 2017-02-07 17:58 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0035201RR17Q1 closedmarvintm It is possible to have duplicated primary keys on WebSQL 
depends on backport 0035202RR16Q4.2 closedmarvintm It is possible to have duplicated primary keys on WebSQL 
related to defect 0035312 closedrqueralta [External Modules] It is possible to have duplicated primary keys on WebSQL 

-  Notes
(0094158)
hgbot (developer)
2017-02-08 18:49

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eb0aecc1659ef5a32435c472474ac148eb410869
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Feb 08 15:45:00 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb0aecc1659ef5a32435c472474ac148eb410869 [^]

Fixed issue 35191. Added id in the order by of masterdata queries to ensure that pagination works even if several records have the same name

---
M src/org/openbravo/retail/posterminal/master/BPCategory.java
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M src/org/openbravo/retail/posterminal/master/Brand.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
M src/org/openbravo/retail/posterminal/master/Category.java
M src/org/openbravo/retail/posterminal/master/CategoryTree.java
M src/org/openbravo/retail/posterminal/master/Characteristic.java
M src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/Product.java
M src/org/openbravo/retail/posterminal/master/ReturnReason.java
M src/org/openbravo/retail/posterminal/master/SalesRepresentative.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleRange.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleVersion.java
M src/org/openbravo/retail/posterminal/master/ServiceProduct.java
M src/org/openbravo/retail/posterminal/master/ServiceProductCategory.java
M src/org/openbravo/retail/posterminal/master/TaxRate.java
---
(0094169)
hgbot (developer)
2017-02-09 09:43

Repository: erp/pmods/org.openbravo.retail.complementary
Changeset: 558a4f5d37277354b1b6b2e4ed7dedf3d8ce59d1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 09 09:43:12 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.complementary/rev/558a4f5d37277354b1b6b2e4ed7dedf3d8ce59d1 [^]

Related to issue 35191. Fix complementary products query.

---
M src/org/openbravo/retail/complementary/master/ComplementaryProducts.java
---
(0094449)
hgbot (developer)
2017-02-20 08:44

Repository: erp/pmods/org.openbravo.retail.levelpricing
Changeset: 6eb1743263df28ee0ffe3ee2c96bb324fce3d0f6
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Feb 20 08:43:51 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.levelpricing/rev/6eb1743263df28ee0ffe3ee2c96bb324fce3d0f6 [^]

Related to issue 35191: Fix Level Product Prices Query

---
M src/org/openbravo/retail/levelpricing/master/LevelProductPrices.java
---

- Issue History
Date Modified Username Field Change
2017-02-07 17:58 guillermogil New Issue
2017-02-07 17:58 guillermogil Assigned To => Retail
2017-02-07 17:58 guillermogil File Added: productQuery.diff
2017-02-07 17:58 guillermogil Resolution time => 1488236400
2017-02-07 17:58 guillermogil Triggers an Emergency Pack => No
2017-02-08 15:34 marvintm Status new => scheduled
2017-02-08 15:34 marvintm Assigned To Retail => marvintm
2017-02-08 18:49 hgbot Checkin
2017-02-08 18:49 hgbot Note Added: 0094158
2017-02-08 18:49 hgbot Status scheduled => resolved
2017-02-08 18:49 hgbot Resolution open => fixed
2017-02-08 18:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb0aecc1659ef5a32435c472474ac148eb410869 [^]
2017-02-09 09:43 hgbot Checkin
2017-02-09 09:43 hgbot Note Added: 0094169
2017-02-20 08:44 hgbot Checkin
2017-02-20 08:44 hgbot Note Added: 0094449
2017-02-20 17:35 migueldejuana Review Assigned To => migueldejuana
2017-02-20 17:35 migueldejuana Status resolved => closed
2017-02-20 17:38 migueldejuana Relationship added related to 0035312


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker