Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035191Retail ModulesWeb POSpublic2017-02-07 17:582017-02-20 17:35
Reporterguillermogil 
Assigned Tomarvintm 
PriorityhighSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035191: It is possible to have duplicated primary keys on WebSQL
DescriptionIt is possible to have duplicated primary keys on WebSQL if you have a lot of products with duplicated names and an small pagination.
When the query is done it orders by name and since there are a lot that have the same value it can rely on errors in WebPOS console and losses of some record.

It will be needed to review each masterdata to ensure the proper behavior of them.
Steps To ReproduceN/A
Proposed SolutionSee diff attached for product query and apply it on the other queries.
It is needed to order by a unique constraint.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0035201RR17Q1 closed marvintm It is possible to have duplicated primary keys on WebSQL 
depends on backport 0035202RR16Q4.2 closed marvintm It is possible to have duplicated primary keys on WebSQL 
related to defect 0035312 closed rqueralta [External Modules] It is possible to have duplicated primary keys on WebSQL 
Attached Filesdiff productQuery.diff (1,951) 2017-02-07 17:58
https://issues.openbravo.com/file_download.php?file_id=10426&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-02-07 17:58guillermogilNew Issue
2017-02-07 17:58guillermogilAssigned To => Retail
2017-02-07 17:58guillermogilFile Added: productQuery.diff
2017-02-07 17:58guillermogilResolution time => 1488236400
2017-02-07 17:58guillermogilTriggers an Emergency Pack => No
2017-02-08 15:34marvintmStatusnew => scheduled
2017-02-08 15:34marvintmAssigned ToRetail => marvintm
2017-02-08 18:49hgbotCheckin
2017-02-08 18:49hgbotNote Added: 0094158
2017-02-08 18:49hgbotStatusscheduled => resolved
2017-02-08 18:49hgbotResolutionopen => fixed
2017-02-08 18:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb0aecc1659ef5a32435c472474ac148eb410869 [^]
2017-02-09 09:43hgbotCheckin
2017-02-09 09:43hgbotNote Added: 0094169
2017-02-20 08:44hgbotCheckin
2017-02-20 08:44hgbotNote Added: 0094449
2017-02-20 17:35migueldejuanaReview Assigned To => migueldejuana
2017-02-20 17:35migueldejuanaStatusresolved => closed
2017-02-20 17:38migueldejuanaRelationship addedrelated to 0035312

Notes
(0094158)
hgbot   
2017-02-08 18:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eb0aecc1659ef5a32435c472474ac148eb410869
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Feb 08 15:45:00 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb0aecc1659ef5a32435c472474ac148eb410869 [^]

Fixed issue 35191. Added id in the order by of masterdata queries to ensure that pagination works even if several records have the same name

---
M src/org/openbravo/retail/posterminal/master/BPCategory.java
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M src/org/openbravo/retail/posterminal/master/Brand.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
M src/org/openbravo/retail/posterminal/master/Category.java
M src/org/openbravo/retail/posterminal/master/CategoryTree.java
M src/org/openbravo/retail/posterminal/master/Characteristic.java
M src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/Product.java
M src/org/openbravo/retail/posterminal/master/ReturnReason.java
M src/org/openbravo/retail/posterminal/master/SalesRepresentative.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleRange.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleVersion.java
M src/org/openbravo/retail/posterminal/master/ServiceProduct.java
M src/org/openbravo/retail/posterminal/master/ServiceProductCategory.java
M src/org/openbravo/retail/posterminal/master/TaxRate.java
---
(0094169)
hgbot   
2017-02-09 09:43   
Repository: erp/pmods/org.openbravo.retail.complementary
Changeset: 558a4f5d37277354b1b6b2e4ed7dedf3d8ce59d1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 09 09:43:12 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.complementary/rev/558a4f5d37277354b1b6b2e4ed7dedf3d8ce59d1 [^]

Related to issue 35191. Fix complementary products query.

---
M src/org/openbravo/retail/complementary/master/ComplementaryProducts.java
---
(0094449)
hgbot   
2017-02-20 08:44   
Repository: erp/pmods/org.openbravo.retail.levelpricing
Changeset: 6eb1743263df28ee0ffe3ee2c96bb324fce3d0f6
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Feb 20 08:43:51 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.levelpricing/rev/6eb1743263df28ee0ffe3ee2c96bb324fce3d0f6 [^]

Related to issue 35191: Fix Level Product Prices Query

---
M src/org/openbravo/retail/levelpricing/master/LevelProductPrices.java
---