Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035157
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementcriticalalways2017-02-03 12:512022-06-07 17:09
ReporteregoitzView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityimmediateResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revision05bc767bcda2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarkmm82
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035157: The report general ledger journal colapse the system when the query gets thousands of rows

Description
When executing the report for a period and schema where there are thousands of entries to show, the reports takes long and consume thousand of resources.

Steps To ReproduceExecute the report on an environment with a big amount of data.

Or check the code to see that the scrollable is not implemented:

http://wiki.openbravo.com/wiki/SQLC#Scrollable_Queries_.28memory-efficient.29 [^]
Proposed SolutionApply a solution similar than the one done in the following commit for the report general ledger:

https://code.openbravo.com/erp/devel/pi/rev/89155988f108 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0049498 newTriage Omni OMS General Ledger Journal Report does not properly implement xsql-scrollable interface (and uses too much memory) 
related to design defect 0036070 acknowledgedTriage Omni OMS Performance problems on the journal entries report. 
related to defect 0036738 closedAtulOpenbravo Performance problems in General Ledger Report when grouping it by Business Partner 

-  Notes
(0094162)
AtulOpenbravo (developer)
2017-02-08 20:26

 Test Plan in pi to make sure the report behaviour is same as earlier before this change

- Navigate to Journal Entries Report. Apply any filters.
  - Check Html view report. Check the Previous and Next button, Data shown in each page.
  - Export PDF report and check the data.
  - Export Xls report and check the data.

- Navigate to General Ledger Report. Apply any filters.
  - for any one of the record in the detail section click on the link shown on date.
  - Check that Journal Entries Report opens up with the necessary details.
  

- Navigate to any posted document for eg:- Sales Invoice.
  - Unpost the document.
  - Post the document again.
  - Check that Journal Entries Report opens with the necessary details.

Note:- Compare above steps with same filters applied before and after applying the patch for this issue.
(0094222)
hgbot (developer)
2017-02-10 19:18

 Repository: erp/devel/pi
Changeset: 05bc767bcda24e0eb1c05ce3d7d1ca82946b0eae
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Feb 09 00:40:22 2017 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/05bc767bcda24e0eb1c05ce3d7d1ca82946b0eae [^]

Fixes Issue 35157:The report general ledger journal colapse the system
when the query gets thousands of rows

Use scrollable queries in General Ledger Journal Report. Made use of
limit/offset or rownum as per the used DBMS to maintain the pagination in
the html report.

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql
---
(0094223)
hgbot (developer)
2017-02-10 19:18

 Repository: erp/devel/pi
Changeset: 180790d540d5294fabb48a34b175fb29a2f936f4
Author: Mark <markmm82 <at> gmail.com>
Date: Fri Feb 10 10:11:34 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/180790d540d5294fabb48a34b175fb29a2f936f4 [^]

Related to issue 35157: Removed unused limit variable

The limit var was declared but it values doesn't changes in any other area of the
code. So the validation to display the message will never be fulfilled.

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
---
(0094224)
markmm82 (developer)
2017-02-10 19:21

 Code review + Testing OK
(0095177)
hudsonbot (developer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095178)
hudsonbot (developer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-02-03 12:51 egoitz New Issue
2017-02-03 12:51 egoitz Assigned To => Triage Finance
2017-02-03 12:51 egoitz Modules => Core
2017-02-03 12:51 egoitz Resolution time => 1486508400
2017-02-03 12:51 egoitz Triggers an Emergency Pack => No
2017-02-03 16:13 markmm82 Assigned To Triage Finance => AtulOpenbravo
2017-02-06 07:24 AtulOpenbravo Status new => scheduled
2017-02-08 20:26 AtulOpenbravo Note Added: 0094162
2017-02-10 19:18 hgbot Checkin
2017-02-10 19:18 hgbot Note Added: 0094222
2017-02-10 19:18 hgbot Status scheduled => resolved
2017-02-10 19:18 hgbot Resolution open => fixed
2017-02-10 19:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/05bc767bcda24e0eb1c05ce3d7d1ca82946b0eae [^]
2017-02-10 19:18 hgbot Checkin
2017-02-10 19:18 hgbot Note Added: 0094223
2017-02-10 19:21 markmm82 Review Assigned To => markmm82
2017-02-10 19:21 markmm82 Note Added: 0094224
2017-02-10 19:21 markmm82 Status resolved => closed
2017-02-10 19:21 markmm82 Fixed in Version => 3.0PR17Q2
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095177
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095178
2017-05-29 16:39 aferraz Relationship added related to 0036070
2017-08-29 12:51 ngarcia Relationship added related to 0036738
2022-06-07 17:09 shuehner Relationship added related to 0049498

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker