Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034840
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2017-01-03 14:212018-02-22 18:18
ReporterpsanjuanView Statuspublic 
Assigned Tononofrancisco 
PriorityurgentResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision79530e9c288f
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034840: Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable.

DescriptionMovement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable.
Steps To ReproduceIn pi:

Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
Go to lines and create a new one.
Click on product field, down arrow and select "Cerveza Ale 0.5L".
Verify that Movement Qty field is "automatically" updated with 24415.
See image 34840-1

Remove that line and close Goods Shipment form and leave session.
Log in.
Select System Admin role.

Go to Preference window and create a new record with below setup:

Client = System.
Organization = *
Property = Enable UOM Management.
Value = Y
Visible at = all empty.
Save it.
Log out and Log in.

Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
Go to lines and create a new one.
Click on product field, down arrow and select "Cerveza Ale 0.5L".
Verify that Operative Qty field is empty.

See image 34840-2

Proposed SolutionOperative Quantity field should be automatically populated at least for those product do not having an alternative UOM but the same one they are stored in.

To be discussed whether this behaviour can be extended to products having an alternative UOM configured.
TagsNo tags attached.
Attached Filesjpg file icon 34840-1.jpg [^] (44,041 bytes) 2017-01-03 14:28


jpg file icon 34840-2.jpg [^] (51,178 bytes) 2017-01-03 14:28

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00370693.0PR17Q4.1 closednonofrancisco Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable. 
depends on backport 00370703.0PR17Q3.3 closednonofrancisco Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable. 
depends on backport 00377183.0PR18Q1 closednonofrancisco Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable. 

-  Notes
(0093169)
psanjuan (viewer)
2017-01-04 11:51

 Fix need to be backported to 17Q1
(0099877)
nonofrancisco (viewer)
2017-10-12 21:00
edited on: 2017-10-12 21:01

 Test Plan

As F&B España Group Admin:

1.- Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
2.- Go to lines and create a new one.
3.- Click on product field, down arrow and select "Cerveza Ale 0.5L".
4.- Verify that Movement Qty field is "automatically" updated with 35915.
5.- Remove that line and close Goods Shipment form and leave session.

As System Admin role.

1.- Go to Preference window and create a new record with below setup:

Client = System.
Organization = *
Property = Enable UOM Management.
Value = Y
Visible at = all empty.
Save it.

As F&B España Group Admin:

1.- Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
2.- Go to lines and create a new one.
3.- Click on product field, down arrow and select "Cerveza Ale 0.5L".
4.- Verify that Operative Quantity = Movement Quantity = 35915.
5.- Verify thal Alternative UOM = Unit
(0101952)
hgbot (developer)
2018-01-25 16:45

 Repository: erp/devel/pi
Changeset: 79530e9c288f8310d469916c1f30bc64b17a7680
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Jan 22 12:12:44 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/79530e9c288f8310d469916c1f30bc64b17a7680 [^]

Fixes issue 34840: Movement Qty column info not updated once a product with stock
is selected in Goods Shipment if Alt UOM Preference is enable.

Operative Quantity field isautomatically populated if the selected product
do not have a default Alternative UOM configured and the product has
quantity on hand.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
---
(0101953)
hgbot (developer)
2018-01-25 16:45

 Repository: erp/devel/pi
Changeset: 85c01f98ce2050ba8478f004c5edeee87cb1ea6b
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 22 12:30:04 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/85c01f98ce2050ba8478f004c5edeee87cb1ea6b [^]

Related to issue 34840: Code Review changes

* Added final modifier to product object again
* Removed unused methods
* When setting the AUM, set also the Quantity expresed in AUM
  and for that, convert the original quantity to the AUM equivalent.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
---
(0101955)
hgbot (developer)
2018-01-25 16:45

 Repository: erp/devel/pi
Changeset: 889d74074bf0a78c9c84147d9fa2937e5c849623
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jan 24 16:21:27 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/889d74074bf0a78c9c84147d9fa2937e5c849623 [^]

Related to Issue 34840. Change done to reload the qty in stock for a product
instead of 0 after the line has been saved

---
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
---
(0101956)
dmiguelez (viewer)
2018-01-25 16:49

 The expected behavior after this change is the following:

Without AUM:
When a new line is created for a Goods Shipment, every time a Product is selected, the movement quantity is updated with the Stock of that Product.
After a line has been saved, or if this line has been created using the Create From button, if the Product is changed, the quantity remains the same one as before, it is not updated.


With AUM:
When a new line is created for a Goods Shipment, every time a Product is selected, the movement quantity is updated with the Stock of that Product.
After a line has been saved, or if this line has been created using the Create From button, if the Product is changed, the quantity is updated with the quantity in Stock converted using the AUM.
This is done because the AUM combo of the Product is updated with the available AUM's for that Product and the Operative Quantity is calculated based on it. Keeping the same quantity as before would imply keeping the same AUM, but this can be different from Product to Product.
(0101957)
dmiguelez (viewer)
2018-01-25 16:50

 Code Review + Testing Ok
(0102684)
hudsonbot (viewer)
2018-02-22 18:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102685)
hudsonbot (viewer)
2018-02-22 18:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102687)
hudsonbot (viewer)
2018-02-22 18:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-01-03 14:21 psanjuan New Issue
2017-01-03 14:21 psanjuan Assigned To => Triage Finance
2017-01-03 14:21 psanjuan OBNetwork customer => No
2017-01-03 14:21 psanjuan Modules => Core
2017-01-03 14:21 psanjuan Triggers an Emergency Pack => No
2017-01-03 14:27 psanjuan Steps to Reproduce Updated View Revisions
2017-01-03 14:27 psanjuan Proposed Solution updated
2017-01-03 14:28 psanjuan File Added: 34840-1.jpg
2017-01-03 14:28 psanjuan File Added: 34840-2.jpg
2017-01-03 17:46 markmm82 Assigned To Triage Finance => rqueralta
2017-01-04 11:51 psanjuan Note Added: 0093169
2017-10-12 15:13 nonofrancisco Assigned To rqueralta => nonofrancisco
2017-10-12 21:00 nonofrancisco Note Added: 0099877
2017-10-12 21:01 nonofrancisco Note Edited: 0099877 View Revisions
2017-10-13 15:13 nonofrancisco Status new => scheduled
2018-01-24 17:18 dmiguelez Status scheduled => acknowledged
2018-01-24 17:18 dmiguelez Status acknowledged => scheduled
2018-01-25 16:45 hgbot Checkin
2018-01-25 16:45 hgbot Note Added: 0101952
2018-01-25 16:45 hgbot Status scheduled => resolved
2018-01-25 16:45 hgbot Resolution open => fixed
2018-01-25 16:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/79530e9c288f8310d469916c1f30bc64b17a7680 [^]
2018-01-25 16:45 hgbot Checkin
2018-01-25 16:45 hgbot Note Added: 0101953
2018-01-25 16:45 hgbot Checkin
2018-01-25 16:45 hgbot Note Added: 0101955
2018-01-25 16:49 dmiguelez Note Added: 0101956
2018-01-25 16:50 dmiguelez Review Assigned To => dmiguelez
2018-01-25 16:50 dmiguelez Note Added: 0101957
2018-01-25 16:50 dmiguelez Status resolved => closed
2018-01-25 16:50 dmiguelez Fixed in Version => 3.0PR18Q2
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102684
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102685
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102687

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker