Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034840Openbravo ERP07. Sales managementpublic2017-01-03 14:212018-02-22 18:18
psanjuan 
nonofrancisco 
urgentmajoralways
closedfixed 
20Professional Appliance
 
3.0PR18Q2 
dmiguelez
Core
No
0034840: Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable.
Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable.
In pi:

Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
Go to lines and create a new one.
Click on product field, down arrow and select "Cerveza Ale 0.5L".
Verify that Movement Qty field is "automatically" updated with 24415.
See image 34840-1

Remove that line and close Goods Shipment form and leave session.
Log in.
Select System Admin role.

Go to Preference window and create a new record with below setup:

Client = System.
Organization = *
Property = Enable UOM Management.
Value = Y
Visible at = all empty.
Save it.
Log out and Log in.

Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
Go to lines and create a new one.
Click on product field, down arrow and select "Cerveza Ale 0.5L".
Verify that Operative Qty field is empty.

See image 34840-2

Operative Quantity field should be automatically populated at least for those product do not having an alternative UOM but the same one they are stored in.

To be discussed whether this behaviour can be extended to products having an alternative UOM configured.
No tags attached.
depends on backport 00370693.0PR17Q4.1 closed nonofrancisco Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable. 
depends on backport 00370703.0PR17Q3.3 closed nonofrancisco Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable. 
depends on backport 00377183.0PR18Q1 closed nonofrancisco Movement Qty column info not updated once a product with stock is selected in Goods Shipment if Alt UOM Preference is enable. 
jpg 34840-1.jpg (44,041) 2017-01-03 14:28
https://issues.openbravo.com/file_download.php?file_id=10234&type=bug
jpg

jpg 34840-2.jpg (51,178) 2017-01-03 14:28
https://issues.openbravo.com/file_download.php?file_id=10235&type=bug
jpg
Issue History
2017-01-03 14:21psanjuanNew Issue
2017-01-03 14:21psanjuanAssigned To => Triage Finance
2017-01-03 14:21psanjuanModules => Core
2017-01-03 14:21psanjuanTriggers an Emergency Pack => No
2017-01-03 14:27psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14202#r14202
2017-01-03 14:27psanjuanProposed Solution updated
2017-01-03 14:28psanjuanFile Added: 34840-1.jpg
2017-01-03 14:28psanjuanFile Added: 34840-2.jpg
2017-01-03 17:46markmm82Assigned ToTriage Finance => rqueralta
2017-01-04 11:51psanjuanNote Added: 0093169
2017-10-12 15:13nonofranciscoAssigned Torqueralta => nonofrancisco
2017-10-12 21:00nonofranciscoNote Added: 0099877
2017-10-12 21:01nonofranciscoNote Edited: 0099877bug_revision_view_page.php?bugnote_id=0099877#r16068
2017-10-13 15:13nonofranciscoStatusnew => scheduled
2018-01-24 17:18dmiguelezStatusscheduled => acknowledged
2018-01-24 17:18dmiguelezStatusacknowledged => scheduled
2018-01-25 16:45hgbotCheckin
2018-01-25 16:45hgbotNote Added: 0101952
2018-01-25 16:45hgbotStatusscheduled => resolved
2018-01-25 16:45hgbotResolutionopen => fixed
2018-01-25 16:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/79530e9c288f8310d469916c1f30bc64b17a7680 [^]
2018-01-25 16:45hgbotCheckin
2018-01-25 16:45hgbotNote Added: 0101953
2018-01-25 16:45hgbotCheckin
2018-01-25 16:45hgbotNote Added: 0101955
2018-01-25 16:49dmiguelezNote Added: 0101956
2018-01-25 16:50dmiguelezReview Assigned To => dmiguelez
2018-01-25 16:50dmiguelezNote Added: 0101957
2018-01-25 16:50dmiguelezStatusresolved => closed
2018-01-25 16:50dmiguelezFixed in Version => 3.0PR18Q2
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102684
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102685
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102687

Notes
(0093169)
psanjuan   
2017-01-04 11:51   
Fix need to be backported to 17Q1
(0099877)
nonofrancisco   
2017-10-12 21:00   
(edited on: 2017-10-12 21:01)
Test Plan

As F&B España Group Admin:

1.- Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
2.- Go to lines and create a new one.
3.- Click on product field, down arrow and select "Cerveza Ale 0.5L".
4.- Verify that Movement Qty field is "automatically" updated with 35915.
5.- Remove that line and close Goods Shipment form and leave session.

As System Admin role.

1.- Go to Preference window and create a new record with below setup:

Client = System.
Organization = *
Property = Enable UOM Management.
Value = Y
Visible at = all empty.
Save it.

As F&B España Group Admin:

1.- Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
2.- Go to lines and create a new one.
3.- Click on product field, down arrow and select "Cerveza Ale 0.5L".
4.- Verify that Operative Quantity = Movement Quantity = 35915.
5.- Verify thal Alternative UOM = Unit

(0101952)
hgbot   
2018-01-25 16:45   
Repository: erp/devel/pi
Changeset: 79530e9c288f8310d469916c1f30bc64b17a7680
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Jan 22 12:12:44 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/79530e9c288f8310d469916c1f30bc64b17a7680 [^]

Fixes issue 34840: Movement Qty column info not updated once a product with stock
is selected in Goods Shipment if Alt UOM Preference is enable.

Operative Quantity field isautomatically populated if the selected product
do not have a default Alternative UOM configured and the product has
quantity on hand.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
---
(0101953)
hgbot   
2018-01-25 16:45   
Repository: erp/devel/pi
Changeset: 85c01f98ce2050ba8478f004c5edeee87cb1ea6b
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 22 12:30:04 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/85c01f98ce2050ba8478f004c5edeee87cb1ea6b [^]

Related to issue 34840: Code Review changes

* Added final modifier to product object again
* Removed unused methods
* When setting the AUM, set also the Quantity expresed in AUM
  and for that, convert the original quantity to the AUM equivalent.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
---
(0101955)
hgbot   
2018-01-25 16:45   
Repository: erp/devel/pi
Changeset: 889d74074bf0a78c9c84147d9fa2937e5c849623
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jan 24 16:21:27 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/889d74074bf0a78c9c84147d9fa2937e5c849623 [^]

Related to Issue 34840. Change done to reload the qty in stock for a product
instead of 0 after the line has been saved

---
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
---
(0101956)
dmiguelez   
2018-01-25 16:49   
The expected behavior after this change is the following:

Without AUM:
When a new line is created for a Goods Shipment, every time a Product is selected, the movement quantity is updated with the Stock of that Product.
After a line has been saved, or if this line has been created using the Create From button, if the Product is changed, the quantity remains the same one as before, it is not updated.


With AUM:
When a new line is created for a Goods Shipment, every time a Product is selected, the movement quantity is updated with the Stock of that Product.
After a line has been saved, or if this line has been created using the Create From button, if the Product is changed, the quantity is updated with the quantity in Stock converted using the AUM.
This is done because the AUM combo of the Product is updated with the available AUM's for that Product and the Operative Quantity is calculated based on it. Keeping the same quantity as before would imply keeping the same AUM, but this can be different from Product to Product.
(0101957)
dmiguelez   
2018-01-25 16:50   
Code Review + Testing Ok
(0102684)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102685)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102687)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test