Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034813
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2016-12-22 12:522016-12-23 20:42
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revision6bb7a6451f5c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034813: clean up ComboTableData unneeded cached pool

DescriptionFix for 0026664, removes cached pool in ComboTableData, but it preserved pool field which now is always null. In some parts it is making direct use of it which would always result in a NPE.
Steps To Reproduce-
Proposed Solutioncompletely remove pool field, and use getPool method to ensure not null value.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0026664 closedalostale Useless ConnectionProvider caching in ApplicationDictionaryCachedStructures 
blocks design defect 0032688 acknowledgedplatform remove unused resources 

-  Notes
(0092941)
hgbot (developer)
2016-12-22 12:58

Repository: erp/devel/pi
Changeset: 6bb7a6451f5c3228d4f6ba6a167b09e493cf3728
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Dec 22 12:57:49 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6bb7a6451f5c3228d4f6ba6a167b09e493cf3728 [^]

fixed bug 34813: clean up ComboTableData unneeded cached pool

  Removed pool field and replaced internally by getPool

---
M src/org/openbravo/erpCommon/utility/ComboTableData.java
---
(0092969)
caristu (developer)
2016-12-23 12:41
edited on: 2016-12-23 12:41

Code reviewed: now getPool() does not make use of any cached pool, it always returns a new DalConnectionProvider.

(0092987)
hudsonbot (developer)
2016-12-23 20:42

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/17b1229a255e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-12-22 12:52 alostale New Issue
2016-12-22 12:52 alostale Assigned To => platform
2016-12-22 12:52 alostale Modules => Core
2016-12-22 12:52 alostale Triggers an Emergency Pack => No
2016-12-22 12:54 alostale Relationship added related to 0026664
2016-12-22 12:54 alostale Relationship added blocks 0032688
2016-12-22 12:54 alostale Assigned To platform => alostale
2016-12-22 12:55 alostale Review Assigned To => caristu
2016-12-22 12:58 hgbot Checkin
2016-12-22 12:58 hgbot Note Added: 0092941
2016-12-22 12:58 hgbot Status new => resolved
2016-12-22 12:58 hgbot Resolution open => fixed
2016-12-22 12:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6bb7a6451f5c3228d4f6ba6a167b09e493cf3728 [^]
2016-12-23 12:41 caristu Note Added: 0092969
2016-12-23 12:41 caristu Status resolved => closed
2016-12-23 12:41 caristu Fixed in Version => 3.0PR17Q1
2016-12-23 12:41 caristu Note Edited: 0092969 View Revisions
2016-12-23 20:42 hudsonbot Checkin
2016-12-23 20:42 hudsonbot Note Added: 0092987


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker