Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034813Openbravo ERPA. Platformpublic2016-12-22 12:522016-12-23 20:42
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034813: clean up ComboTableData unneeded cached pool
DescriptionFix for 0026664, removes cached pool in ComboTableData, but it preserved pool field which now is always null. In some parts it is making direct use of it which would always result in a NPE.
Steps To Reproduce-
Proposed Solutioncompletely remove pool field, and use getPool method to ensure not null value.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0026664 closed alostale Useless ConnectionProvider caching in ApplicationDictionaryCachedStructures 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-22 12:52alostaleNew Issue
2016-12-22 12:52alostaleAssigned To => platform
2016-12-22 12:52alostaleModules => Core
2016-12-22 12:52alostaleTriggers an Emergency Pack => No
2016-12-22 12:54alostaleRelationship addedrelated to 0026664
2016-12-22 12:54alostaleRelationship addedblocks 0032688
2016-12-22 12:54alostaleAssigned Toplatform => alostale
2016-12-22 12:55alostaleReview Assigned To => caristu
2016-12-22 12:58hgbotCheckin
2016-12-22 12:58hgbotNote Added: 0092941
2016-12-22 12:58hgbotStatusnew => resolved
2016-12-22 12:58hgbotResolutionopen => fixed
2016-12-22 12:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6bb7a6451f5c3228d4f6ba6a167b09e493cf3728 [^]
2016-12-23 12:41caristuNote Added: 0092969
2016-12-23 12:41caristuStatusresolved => closed
2016-12-23 12:41caristuFixed in Version => 3.0PR17Q1
2016-12-23 12:41caristuNote Edited: 0092969bug_revision_view_page.php?bugnote_id=0092969#r14122
2016-12-23 20:42hudsonbotCheckin
2016-12-23 20:42hudsonbotNote Added: 0092987

Notes
(0092941)
hgbot   
2016-12-22 12:58   
Repository: erp/devel/pi
Changeset: 6bb7a6451f5c3228d4f6ba6a167b09e493cf3728
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Dec 22 12:57:49 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6bb7a6451f5c3228d4f6ba6a167b09e493cf3728 [^]

fixed bug 34813: clean up ComboTableData unneeded cached pool

  Removed pool field and replaced internally by getPool

---
M src/org/openbravo/erpCommon/utility/ComboTableData.java
---
(0092969)
caristu   
2016-12-23 12:41   
Code reviewed: now getPool() does not make use of any cached pool, it always returns a new DalConnectionProvider.
(0092987)
hudsonbot   
2016-12-23 20:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/17b1229a255e [^]
Maturity status: Test