Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034785
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2016-12-20 12:342016-12-26 22:16
ReportermaiteView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityurgentResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revisionbf8836816014
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarkmm82
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034785: Report's general ledger should be defaulted to organization's general ledger, when organization is filled by default

DescriptionFix for issue "https://issues.openbravo.com/view.php?id=32535" [^] is not properly working when Organization field is already set when accessing the report. In that case, General Ledger field shows first value of the list instead of organization's general ledger
Steps To Reproduce1. Access Role window and edit role with name "F&B España, S.A - Finance" to set User Level=Organization
2. Access General Ledger Configuration and edit International Group record to set name "aF&B International Group US/A/US Dollar"
3. Change role to "F&B España, S.A - Finance"
4. Access Trial Balance report and realize that Organization "España Region Norte" is set by default but General Ledger field by default is "International Group" instead of "España" general ledger

Following list of reports needs to be reviewed to behave the same:

Customer Statement
General Ledger Report
Journal Entries Report
Multi-dimensional Profit and Loss
Multidimensional Trial Balance
Payable Aging Schedule
Receivable Aging Schedule
Trial Balance Report
Balance Sheet and P&L structure
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00325353.0PR16Q3 closedmarkmm82 Report's currency and report's general ledger should be defaulted to organization's currency and organization's general ledger 

-  Notes
(0092921)
AtulOpenbravo (developer)
2016-12-21 20:42
edited on: 2016-12-23 06:42

 Commit https://code.openbravo.com/erp/devel/pi/rev/65a012587054eb184c2b6f44dcdf59333b31c876 [^]

removes the call of setDefaultLedger() method as a part of On Load functions. Code review improvement changes tries to get Ledger information in the default method itself. At this time the Organization is blank, so the Proper Ledger is not set as reported in this issue.

Proposed solution is to get Default Organization from role of current login user session.
(0092983)
AtulOpenbravo (developer)
2016-12-23 17:25

 Test Plan
1. Navigate to Role window and edit role with name "F&B España, S.A - Finance" to set User Level=Organization
2. Navigate to General Ledger Configuration and edit International Group record to set name "aF&B International Group US/A/US Dollar"
3. Change role to "F&B España, S.A - Finance"
4. Navigate to Trial Balance report and realize that Organization "España Region Norte" is set by default and General Ledger field by default is "España" general ledger.
5. Navigate to General Ledger Report, Journal Entries Report and the check that behaviour is same as in Step 5.
   Organization is set as "F&B España - Region Norte"
   General Ledger is set as "F&B España S.A US/A/Euro"
(0092995)
hgbot (developer)
2016-12-26 17:05

 Repository: erp/devel/pi
Changeset: bf8836816014e50b0fb23ed2fbfddbf38a62bd5e
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Dec 23 22:18:43 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/bf8836816014e50b0fb23ed2fbfddbf38a62bd5e [^]

Fixes Issue 34785:Report's general ledger should be defaulted to
organization's general ledger, when organization is filled by default

In Default method, organization is blank, in this case get the organization
information from current user session and get the Default Ledger for
selected organization.

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java
---
(0092996)
markmm82 (developer)
2016-12-26 17:10

 Code review + Testing OK
(0093001)
hudsonbot (developer)
2016-12-26 22:16

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8760895ea957 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-12-20 12:34 maite New Issue
2016-12-20 12:34 maite Assigned To => Triage Finance
2016-12-20 12:34 maite Modules => Core
2016-12-20 12:34 maite Resolution time => 1484002800
2016-12-20 12:34 maite Triggers an Emergency Pack => No
2016-12-20 12:35 maite Relationship added related to 0032535
2016-12-20 12:36 maite Issue Monitored: networkb
2016-12-20 12:36 maite Steps to Reproduce Updated View Revisions
2016-12-20 15:59 markmm82 Assigned To Triage Finance => AtulOpenbravo
2016-12-21 20:42 AtulOpenbravo Note Added: 0092921
2016-12-23 06:42 AtulOpenbravo Note Edited: 0092921 View Revisions
2016-12-23 10:29 AtulOpenbravo Status new => scheduled
2016-12-23 17:25 AtulOpenbravo Note Added: 0092983
2016-12-26 17:05 hgbot Checkin
2016-12-26 17:05 hgbot Note Added: 0092995
2016-12-26 17:05 hgbot Status scheduled => resolved
2016-12-26 17:05 hgbot Resolution open => fixed
2016-12-26 17:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bf8836816014e50b0fb23ed2fbfddbf38a62bd5e [^]
2016-12-26 17:10 markmm82 Review Assigned To => markmm82
2016-12-26 17:10 markmm82 Note Added: 0092996
2016-12-26 17:10 markmm82 Status resolved => closed
2016-12-26 17:10 markmm82 Fixed in Version => 3.0PR17Q1
2016-12-26 22:16 hudsonbot Checkin
2016-12-26 22:16 hudsonbot Note Added: 0093001

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker