Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034785Openbravo ERP09. Financial managementpublic2016-12-20 12:342016-12-26 22:16
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Tomarkmm82
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034785: Report's general ledger should be defaulted to organization's general ledger, when organization is filled by default
DescriptionFix for issue "https://issues.openbravo.com/view.php?id=32535" [^] is not properly working when Organization field is already set when accessing the report. In that case, General Ledger field shows first value of the list instead of organization's general ledger
Steps To Reproduce1. Access Role window and edit role with name "F&B España, S.A - Finance" to set User Level=Organization
2. Access General Ledger Configuration and edit International Group record to set name "aF&B International Group US/A/US Dollar"
3. Change role to "F&B España, S.A - Finance"
4. Access Trial Balance report and realize that Organization "España Region Norte" is set by default but General Ledger field by default is "International Group" instead of "España" general ledger

Following list of reports needs to be reviewed to behave the same:

Customer Statement
General Ledger Report
Journal Entries Report
Multi-dimensional Profit and Loss
Multidimensional Trial Balance
Payable Aging Schedule
Receivable Aging Schedule
Trial Balance Report
Balance Sheet and P&L structure
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00325353.0PR16Q3 closed markmm82 Report's currency and report's general ledger should be defaulted to organization's currency and organization's general ledger 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-20 12:34maiteNew Issue
2016-12-20 12:34maiteAssigned To => Triage Finance
2016-12-20 12:34maiteModules => Core
2016-12-20 12:34maiteResolution time => 1484002800
2016-12-20 12:34maiteTriggers an Emergency Pack => No
2016-12-20 12:35maiteRelationship addedrelated to 0032535
2016-12-20 12:36maiteIssue Monitored: networkb
2016-12-20 12:36maiteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14080#r14080
2016-12-20 15:59markmm82Assigned ToTriage Finance => AtulOpenbravo
2016-12-21 20:42AtulOpenbravoNote Added: 0092921
2016-12-23 06:42AtulOpenbravoNote Edited: 0092921bug_revision_view_page.php?bugnote_id=0092921#r14118
2016-12-23 10:29AtulOpenbravoStatusnew => scheduled
2016-12-23 17:25AtulOpenbravoNote Added: 0092983
2016-12-26 17:05hgbotCheckin
2016-12-26 17:05hgbotNote Added: 0092995
2016-12-26 17:05hgbotStatusscheduled => resolved
2016-12-26 17:05hgbotResolutionopen => fixed
2016-12-26 17:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bf8836816014e50b0fb23ed2fbfddbf38a62bd5e [^]
2016-12-26 17:10markmm82Review Assigned To => markmm82
2016-12-26 17:10markmm82Note Added: 0092996
2016-12-26 17:10markmm82Statusresolved => closed
2016-12-26 17:10markmm82Fixed in Version => 3.0PR17Q1
2016-12-26 22:16hudsonbotCheckin
2016-12-26 22:16hudsonbotNote Added: 0093001

Notes
(0092921)
AtulOpenbravo   
2016-12-21 20:42   
(edited on: 2016-12-23 06:42)
Commit https://code.openbravo.com/erp/devel/pi/rev/65a012587054eb184c2b6f44dcdf59333b31c876 [^]

removes the call of setDefaultLedger() method as a part of On Load functions. Code review improvement changes tries to get Ledger information in the default method itself. At this time the Organization is blank, so the Proper Ledger is not set as reported in this issue.

Proposed solution is to get Default Organization from role of current login user session.
(0092983)
AtulOpenbravo   
2016-12-23 17:25   
Test Plan
1. Navigate to Role window and edit role with name "F&B España, S.A - Finance" to set User Level=Organization
2. Navigate to General Ledger Configuration and edit International Group record to set name "aF&B International Group US/A/US Dollar"
3. Change role to "F&B España, S.A - Finance"
4. Navigate to Trial Balance report and realize that Organization "España Region Norte" is set by default and General Ledger field by default is "España" general ledger.
5. Navigate to General Ledger Report, Journal Entries Report and the check that behaviour is same as in Step 5.
   Organization is set as "F&B España - Region Norte"
   General Ledger is set as "F&B España S.A US/A/Euro"
(0092995)
hgbot   
2016-12-26 17:05   
Repository: erp/devel/pi
Changeset: bf8836816014e50b0fb23ed2fbfddbf38a62bd5e
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Dec 23 22:18:43 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/bf8836816014e50b0fb23ed2fbfddbf38a62bd5e [^]

Fixes Issue 34785:Report's general ledger should be defaulted to
organization's general ledger, when organization is filled by default

In Default method, organization is blank, in this case get the organization
information from current user session and get the Default Ledger for
selected organization.

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java
---
(0092996)
markmm82   
2016-12-26 17:10   
Code review + Testing OK
(0093001)
hudsonbot   
2016-12-26 22:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8760895ea957 [^]
Maturity status: Test