Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034782
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Accounting tab for transactionsminorhave not tried2016-12-20 11:212017-01-25 17:14
ReportershuehnerView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiond674678c5690
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tomarkmm82
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0034782: Tabs based on views should be marked as read-only as per warning message in openbravo.log

DescriptionSee issue: 34780
Some code at runtime has a check for uipattern=RO if a tab is based on a view.

Many tabs in this module seem to be wrongly defined here.
 STD | Goods Receipt | Accounting | OBACCT_InOut_Acct_v | Y
 STD | Cash Journal | Accounting | OBACCT_Cash_Acct_v | Y
 STD | Bank Statement | Accounting | OBACCT_BankStatement_Acct_v | Y
 STD | Goods Shipment | Accounting | OBACCT_InOut_Acct_v | Y
 STD | Purchase Invoice | Accounting | OBACCT_Invoice_Acct_v | Y
 STD | G/L Journal | Accounting | OBACCT_Journal_Acct_v | Y
 STD | Bill of Materials Production | Accounting | OBACCT_Production_Acct_v | Y
 STD | Goods Movements | Accounting | OBACCT_Movement_Acct_v | Y
 STD | Physical Inventory | Accounting | OBACCT_Inventory_Acct_v | Y
 STD | Amortization | Accounting | OBACCT_Amortization_Acct_v | Y
 STD | Work Effort | Accounting | OBACCT_Production_Acct_v | Y
 STD | Payment Status Management | Accounting | OBACCT_DP_Management_Acct_v | Y
 STD | Sales Invoice | Accounting | OBACCT_Invoice_Acct_v | Y
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0034780 scheduledTriage Platform Base Openbravo ERP Check in WindowSettingsActionHandler about: Tab set to read-only as it is based on a view should be probably done at comple time 

-  Notes
(0093063)
rqueralta (viewer)
2016-12-29 23:43

 Test plan:

As System Admin
  - Install "Accounting tab for transactions" module
  - Run the example the below SQL to find candidates:
    select t.uipattern, w.name,t.name, tabl.tablename, tabl.isview from ad_tab t, ad_table tabl, ad_window w where w.ad_window_id = t.ad_window_id and t.ad_table_id = tabl.ad_table_id and t.name = 'Accounting' and tabl.tablename ilike '%_V';
  - Verify that all recovered records have uipattern = RO
(0093760)
hgbot (developer)
2017-01-20 22:18

 Repository: erp/pmods/org.openbravo.acctTab
Changeset: d674678c56900011aec22deded7ace930f33e46c
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Dec 28 14:18:06 2016 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.acctTab/rev/d674678c56900011aec22deded7ace930f33e46c [^]

Fixes issue 34782: Tabs based on views should be marked as read-only

Changed uipattern into some tabs from STD to RO

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0093829)
markmm82 (viewer)
2017-01-25 17:14

 Code review + Testing OK

- Issue History
Date Modified Username Field Change
2016-12-20 11:21 shuehner New Issue
2016-12-20 11:21 shuehner Assigned To => Triage Finance
2016-12-20 11:21 shuehner OBNetwork customer => No
2016-12-20 11:22 shuehner Relationship added related to 0034780
2016-12-20 21:24 markmm82 Assigned To Triage Finance => rqueralta
2016-12-20 21:25 markmm82 Status new => scheduled
2016-12-27 18:33 alekosmp86 Assigned To rqueralta => alekosmp86
2016-12-29 23:42 rqueralta Assigned To alekosmp86 => rqueralta
2016-12-29 23:43 rqueralta Note Added: 0093063
2017-01-20 22:18 hgbot Checkin
2017-01-20 22:18 hgbot Note Added: 0093760
2017-01-20 22:18 hgbot Status scheduled => resolved
2017-01-20 22:18 hgbot Resolution open => fixed
2017-01-20 22:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.acctTab/rev/d674678c56900011aec22deded7ace930f33e46c [^]
2017-01-25 17:14 markmm82 Review Assigned To => markmm82
2017-01-25 17:14 markmm82 Note Added: 0093829
2017-01-25 17:14 markmm82 Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker