Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034782ModulesAccounting tab for transactionspublic2016-12-20 11:212017-01-25 17:14
Reportershuehner 
Assigned Torqueralta 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tomarkmm82
Support ticket
OBNetwork customer
Regression introduced in release
Summary0034782: Tabs based on views should be marked as read-only as per warning message in openbravo.log
DescriptionSee issue: 34780
Some code at runtime has a check for uipattern=RO if a tab is based on a view.

Many tabs in this module seem to be wrongly defined here.
 STD | Goods Receipt | Accounting | OBACCT_InOut_Acct_v | Y
 STD | Cash Journal | Accounting | OBACCT_Cash_Acct_v | Y
 STD | Bank Statement | Accounting | OBACCT_BankStatement_Acct_v | Y
 STD | Goods Shipment | Accounting | OBACCT_InOut_Acct_v | Y
 STD | Purchase Invoice | Accounting | OBACCT_Invoice_Acct_v | Y
 STD | G/L Journal | Accounting | OBACCT_Journal_Acct_v | Y
 STD | Bill of Materials Production | Accounting | OBACCT_Production_Acct_v | Y
 STD | Goods Movements | Accounting | OBACCT_Movement_Acct_v | Y
 STD | Physical Inventory | Accounting | OBACCT_Inventory_Acct_v | Y
 STD | Amortization | Accounting | OBACCT_Amortization_Acct_v | Y
 STD | Work Effort | Accounting | OBACCT_Production_Acct_v | Y
 STD | Payment Status Management | Accounting | OBACCT_DP_Management_Acct_v | Y
 STD | Sales Invoice | Accounting | OBACCT_Invoice_Acct_v | Y
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0034780 scheduled Triage Platform Base Openbravo ERP Check in WindowSettingsActionHandler about: Tab set to read-only as it is based on a view should be probably done at comple time 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-20 11:21shuehnerNew Issue
2016-12-20 11:21shuehnerAssigned To => Triage Finance
2016-12-20 11:22shuehnerRelationship addedrelated to 0034780
2016-12-20 21:24markmm82Assigned ToTriage Finance => rqueralta
2016-12-20 21:25markmm82Statusnew => scheduled
2016-12-27 18:33alekosmp86Assigned Torqueralta => alekosmp86
2016-12-29 23:42rqueraltaAssigned Toalekosmp86 => rqueralta
2016-12-29 23:43rqueraltaNote Added: 0093063
2017-01-20 22:18hgbotCheckin
2017-01-20 22:18hgbotNote Added: 0093760
2017-01-20 22:18hgbotStatusscheduled => resolved
2017-01-20 22:18hgbotResolutionopen => fixed
2017-01-20 22:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.acctTab/rev/d674678c56900011aec22deded7ace930f33e46c [^]
2017-01-25 17:14markmm82Review Assigned To => markmm82
2017-01-25 17:14markmm82Note Added: 0093829
2017-01-25 17:14markmm82Statusresolved => closed

Notes
(0093063)
rqueralta   
2016-12-29 23:43   
Test plan:

As System Admin
  - Install "Accounting tab for transactions" module
  - Run the example the below SQL to find candidates:
    select t.uipattern, w.name,t.name, tabl.tablename, tabl.isview from ad_tab t, ad_table tabl, ad_window w where w.ad_window_id = t.ad_window_id and t.ad_table_id = tabl.ad_table_id and t.name = 'Accounting' and tabl.tablename ilike '%_V';
  - Verify that all recovered records have uipattern = RO
(0093760)
hgbot   
2017-01-20 22:18   
Repository: erp/pmods/org.openbravo.acctTab
Changeset: d674678c56900011aec22deded7ace930f33e46c
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Dec 28 14:18:06 2016 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.acctTab/rev/d674678c56900011aec22deded7ace930f33e46c [^]

Fixes issue 34782: Tabs based on views should be marked as read-only

Changed uipattern into some tabs from STD to RO

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0093829)
markmm82   
2017-01-25 17:14   
Code review + Testing OK