Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034756
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServermajorhave not tried2016-12-16 12:002016-12-20 09:29
ReporterAugustoMauchView Statuspublic 
Assigned ToSandrahuguet 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision64da711454b7
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2016-08-19
Regression introduced in releaseRR16Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6ccbd09b41f4 [^]
Triggers an Emergency PackNo
Summary

0034756: Transaction left open leads to database locks when updating entries from the Mobile Server window

DescriptionThere is a bug in SetCurrentMobileServerListener that results in a transaction being left open if the mobile.server.key property is not defined in Openbravo.properties.

As a result of that transaction being left open, it will not be possible to update a mobile server that was already defined when Tomcat was last started because the uncommited transaction will cause a database lock.
Steps To Reproduce- Make sure there is at least one entry in the obmobc_server_definition table.
- Make sure the mobile.server.key parameter is not defined in Openbravo.properties
- Start Tomcat
- After starting Tomcat, run this query in the database to check that one transaction has been left open: select * from pg_stat_activity where state <> 'idle' and query ilike '%server%';
- Open the Mobile Server window and try to modify an existing mobile server. The record will not be saved due to a lock in the database.
Proposed SolutionMake sure under all circumstances the connection is either commited or rolled back
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0034767RR16Q4.1 closedSandrahuguet Transact left open leads to database locks when updating entries from the Mobile Server window 
caused by defect 0033692RR16Q4 closedmtaal Prevent NPE in case no mobile server definition present but still server key is set 
has duplicate defect 0034173 closedSandrahuguet Connection leak in SetCurrentMobileServerListener 
has duplicate defect 0034967 closedplatform the delete client process is not finishing 

-  Notes
(0092491)
hgbot (developer)
2016-12-16 13:18

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 64da711454b7732e30477ac0598f9844442eb41d
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Dec 16 13:17:42 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/64da711454b7732e30477ac0598f9844442eb41d [^]

Fixed issue 34756 properly commitAndClose in SetCurrentMobileServerListener

properly commitAndClose in SetCurrentMobileServerListener to avoid the
transaction left open leads to database locks when updating entries
from the Mobile Server window

---
M src/org/openbravo/mobile/core/listener/SetCurrentMobileServerListener.java
---
(0092492)
AugustoMauch (administrator)
2016-12-16 13:19

 Code reviewed and verified
(0092762)
shuehner (administrator)
2016-12-19 11:18

 Note: This will also prevent any exclusive locks on the table which are used for some maintenance.

This will block (while tomcat us running) indefinitely:
a.) ant import.sample.data
b.) Probably MMC rebuild if that update.database needs to touch obmobc_mobile_server table

- Issue History
Date Modified Username Field Change
2016-12-16 12:00 AugustoMauch New Issue
2016-12-16 12:00 AugustoMauch Assigned To => Sandrahuguet
2016-12-16 12:00 AugustoMauch OBNetwork customer => No
2016-12-16 12:00 AugustoMauch Triggers an Emergency Pack => No
2016-12-16 13:18 hgbot Checkin
2016-12-16 13:18 hgbot Note Added: 0092491
2016-12-16 13:18 hgbot Status new => resolved
2016-12-16 13:18 hgbot Resolution open => fixed
2016-12-16 13:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/64da711454b7732e30477ac0598f9844442eb41d [^]
2016-12-16 13:19 AugustoMauch Review Assigned To => AugustoMauch
2016-12-16 13:19 AugustoMauch Note Added: 0092492
2016-12-16 13:19 AugustoMauch Status resolved => closed
2016-12-16 13:24 Sandrahuguet Regression level => Production - QA Approved
2016-12-16 13:24 Sandrahuguet Regression date => 2016-08-19
2016-12-16 13:24 Sandrahuguet Regression introduced in release => RR16Q4
2016-12-16 13:24 Sandrahuguet Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6ccbd09b41f4 [^]
2016-12-19 11:06 Sandrahuguet Status closed => new
2016-12-19 11:06 Sandrahuguet Resolution fixed => open
2016-12-19 11:12 Sandrahuguet Status new => scheduled
2016-12-19 11:16 AugustoMauch Summary Transact left open leads to database locks when updating entries from the Mobile Server window => Transaction left open leads to database locks when updating entries from the Mobile Server window
2016-12-19 11:18 shuehner Note Added: 0092762
2016-12-19 11:19 AugustoMauch Status scheduled => resolved
2016-12-19 11:19 AugustoMauch Resolution open => fixed
2016-12-19 11:19 AugustoMauch Status resolved => closed
2016-12-20 09:29 dmitry_mezentsev Relationship added caused by 0033692
2017-01-03 16:35 Sandrahuguet Relationship added duplicate of 0034173
2017-01-03 16:36 Sandrahuguet Relationship replaced has duplicate 0034173
2017-01-16 16:20 caristu Relationship added has duplicate 0034967

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker