Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0034733

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

have not tried

2016-12-14 16:54

2016-12-19 11:30

Reporter

guilleaer

View Status

public

Assigned To

guilleaer

Priority

normal

Resolution

fixed

Fixed in Version

RR17Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

RR17Q1

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

No

Support ticket

Regression level

Pre packaging ( pi )

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0034733: Confirmation popup is not hiding scrim properly when 2 dialogs are shown at the same time

Description

Confirmation popup is not hiding scrim properly when 2 confirmation popups are shown at the same time

Steps To Reproduce

- login into web POS
- open developer tools
- execute the following command using the console:
OB.UTIL.showConfirmation.display("popup1", "This is popup 1");
- Without close the popup execute the following command
OB.UTIL.showConfirmation.display("popup2", "This is popup 2");
- Press OK button
Fine: 1st popup has gone, 2nd Popup is properly closed
Wrong: The scrim is still there.

Proposed Solution

Currently when a confirmation dialog is shown, previous components are destroyed but the scrim is still there.

I suggest to hide the current popup (This action will close the scrim) and then destroy the components.

Doing it the problems should dissapear

Tags

No tags attached.

possiblediffScrim.diff [^] (1,781 bytes) 2016-12-14 17:44 [Show Content] [Hide Content]

changeset:   2479:b42390e29b47
tag:         tip
user:        Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com>
date:        Wed Dec 14 16:59:54 2016 +0100
summary:     Fixed issue 34733: Confirmation popups are hidden before destroy them.

diff -r 06badbbc9fbe -r b42390e29b47 web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
--- a/web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js	Wed Dec 14 14:10:14 2016 +0100
+++ b/web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js	Wed Dec 14 16:59:54 2016 +0100
@@ -308,8 +308,12 @@
   },
   hide: function (args) {
     var resp = true;
+    var executeOBEvents = true;
+    if (args && args.ignoreOBEvents && args.ignoreOBEvents === true) {
+      executeOBEvents = false;
+    }
     this._addArgsToComponent(args);
-    if (this.executeBeforeHide) {
+    if (this.executeBeforeHide && executeOBEvents) {
       resp = this.executeBeforeHide();
       if (_.isUndefined(resp) || _.isNull(resp)) {
         resp = true;
@@ -329,7 +333,7 @@
       }
       // Restore focus keeper
       OB.MobileApp.view.scanningFocus(this.originalScanMode);
-      if (this.executeOnHide) {
+      if (this.executeOnHide && executeOBEvents) {
         this.executeOnHide();
       }
     }
diff -r 06badbbc9fbe -r b42390e29b47 web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
--- a/web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js	Wed Dec 14 14:10:14 2016 +0100
+++ b/web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js	Wed Dec 14 16:59:54 2016 +0100
@@ -323,6 +323,7 @@
 
       // remove old confirmation box
       for (i = 0; i < components.length; i++) {
+        components[i].hide({ignoreOBEvents: true});
         components[i].destroy();
       }

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0034577		closed	guilleaer	The component 'OB.UI.DatePicker' does not work properly.
has duplicate	defect	0034750		closed	Retail	can't operate webPOS after cash management

Notes
(0092429) hgbot (developer) 2016-12-16 08:37	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 5142ec05c60e911e99fdace344fbcfb1afdafe3e Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu Dec 15 13:54:52 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5142ec05c60e911e99fdace344fbcfb1afdafe3e [^] Fixed issue 34733: Confirmation popups are hidden before destroy them --- M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js ---

Issue History
Date Modified	Username	Field	Change
2016-12-14 16:54	guilleaer	New Issue
2016-12-14 16:54	guilleaer	Assigned To	=> guilleaer
2016-12-14 16:54	guilleaer	OBNetwork customer	=> No
2016-12-14 16:54	guilleaer	Triggers an Emergency Pack	=> No
2016-12-14 16:55	guilleaer	Relationship added	related to 0034577
2016-12-14 17:44	guilleaer	File Added: possiblediffScrim.diff
2016-12-15 17:49	marvintm	Relationship added	has duplicate 0034750
2016-12-15 17:52	marvintm	Regression level	=> Pre packaging ( pi )
2016-12-16 08:37	hgbot	Checkin
2016-12-16 08:37	hgbot	Note Added: 0092429
2016-12-16 08:37	hgbot	Status	new => resolved
2016-12-16 08:37	hgbot	Resolution	open => fixed
2016-12-16 08:37	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5142ec05c60e911e99fdace344fbcfb1afdafe3e [^]
2016-12-19 11:30	marvintm	Review Assigned To	=> marvintm
2016-12-19 11:30	marvintm	Status	resolved => closed
2016-12-19 11:30	marvintm	Fixed in Version	=> RR17Q1

Copyright © 2000 - 2009 MantisBT Group