Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034577
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-11-18 12:372016-12-19 09:33
ReporterjorgewederagoView Statuspublic 
Assigned Toguilleaer 
PriorityhighResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision6cce74429ee1
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034577: The component 'OB.UI.DatePicker' does not work properly.

DescriptionIf you click the x in the component strange symbols appear.

When the component is used the paddings of the components makes the component bigger than it should be. The top and bottom margins should be removed or set to 0px.

Sometimes when you click on the component the selector appears below the rest of the component making difficult to choose a value. In the case that a scrim is already there you cannot even choose the value.

All these issues can be seen in the attached screenshot.
Steps To ReproduceCreate a component which uses 'OB.UI.DatePicker' and try to use it. In case that you need a module which uses it you can ask to JWE.
TagsNo tags attached.
Attached Filespng file icon Screenshot.png [^] (124,641 bytes) 2016-11-18 12:37


diff file icon issue34577_possiblepatch.diff [^] (782 bytes) 2016-11-25 17:05 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0033901 closedmario_castello [SER-QA 1597] Date Picker shows incorrect character for empty day, month and year 
related to defect 0034733RR17Q1 closedguilleaer Confirmation popup is not hiding scrim properly when 2 dialogs are shown at the same time 

-  Notes
(0091895)
hgbot (developer)
2016-11-28 14:37

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6c7c4eaa77794dcda2ff3180a1b06192c0429709
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Nov 28 19:06:33 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6c7c4eaa77794dcda2ff3180a1b06192c0429709 [^]

Fixes issue 34577 : Modified onyx Popup source for calculation of z-index

* z-index will always be calculated taking into account which is the max z-index of the application

---
M web/org.openbravo.mobile.core/build/lib.js
M web/org.openbravo.mobile.core/lib/onyx/source/Popup.js
---
(0091896)
guillermogil (viewer)
2016-11-28 14:54

 There are more topics to solve:
If you click the x in the component strange symbols appear.

When the component is used the paddings of the components makes the component bigger than it should be. The top and bottom margins should be removed or set to 0px.
(0091897)
marvintm (viewer)
2016-11-28 15:34

 The visualization adjustments and the strange characters when clicking on "x" are still pending to be fixed.
(0091922)
hgbot (developer)
2016-11-30 09:59

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6cce74429ee17026a2a8038be1ebd043a5348ca3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 30 14:28:57 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6cce74429ee17026a2a8038be1ebd043a5348ca3 [^]

Fixes issue 34577 : Added CSS to reduce Datepicker button size

* Modified DatePicker Button CSS(by adding margin), to reduce the size of the buttons

---
M web/org.openbravo.mobile.core/lib/onyx/source/DatePicker.js
M web/org.openbravo.mobile.core/source/component/ob-datepicker.js
---
(0091938)
hgbot (developer)
2016-11-30 17:20

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d40ef71f920cbe4dcf42c210d2de2b11fa197c35
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Nov 30 17:20:22 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d40ef71f920cbe4dcf42c210d2de2b11fa197c35 [^]

Related to issue 34577. Some additional changes:
- Reverted change in onyx library. It's better not to change it directly.
- Implemented equivalent change in JS in subcomponent.
- Some previously applied changes in the styling were not necessary and have been removed.

---
M web/org.openbravo.mobile.core/lib/onyx/source/DatePicker.js
---
(0091939)
hgbot (developer)
2016-11-30 17:21

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0d7bcfc60eb85a2498c7c56a948d992eea63f3e8
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Nov 30 17:20:38 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0d7bcfc60eb85a2498c7c56a948d992eea63f3e8 [^]

Related to issue 34577. Some additional changes:
- Reverted change in onyx library. It's better not to change it directly.
- Implemented equivalent change in JS in subcomponent.
- Some previously applied changes in the styling were not necessary and have been removed.

---
M web/org.openbravo.mobile.core/source/component/ob-datepicker.js
---
(0091981)
marvintm (viewer)
2016-12-01 16:33

 It seems the change in the z-index in Enyo has caused some problems with some flows:
- Configure the hardware url in the POS Terminal, but don't open the hardware manager.
- Log in the Web POS
- Go to the cashup window, and complete the cashup.
- A popup will be shown, explaining that printing failed, and prompting the user to choose whether to print again, or to cancel.
- Choose cancel. Realize that a scrim is permanently shown over the POS window, and the application cannot be used anymore, unless a refresh of the page is donw.
(0092238)
marvintm (viewer)
2016-12-09 10:35

 Finally after further analyzing the described situation happening in the Cashup window, we have found that the root cause of the problem is two asynchronous threads not being properly handled in the cashup itself, and not a problem with this fix per se, so we are closing the issue.
(0092753)
hgbot (developer)
2016-12-19 09:33

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: bc1fc419acea1990631c267af60d5ec0285a48a4
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Dec 19 09:32:29 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/bc1fc419acea1990631c267af60d5ec0285a48a4 [^]

Related to issue 34577: Scrim zIndex is not recalculated if it is valid

---
M web/org.openbravo.mobile.core/build/lib.js
M web/org.openbravo.mobile.core/lib/onyx/source/Popup.js
---

- Issue History
Date Modified Username Field Change
2016-11-18 12:37 jorgewederago New Issue
2016-11-18 12:37 jorgewederago Assigned To => Retail
2016-11-18 12:37 jorgewederago File Added: Screenshot.png
2016-11-18 12:37 jorgewederago OBNetwork customer => Yes
2016-11-18 12:37 jorgewederago Resolution time => 1512774000
2016-11-18 12:37 jorgewederago Triggers an Emergency Pack => No
2016-11-18 12:41 guillermogil Resolution time 1512774000 => 1481238000
2016-11-24 12:50 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2016-11-24 12:50 ranjith_qualiantech_com Status new => scheduled
2016-11-25 17:05 guilleaer File Added: issue34577_possiblepatch.diff
2016-11-28 14:37 hgbot Checkin
2016-11-28 14:37 hgbot Note Added: 0091895
2016-11-28 14:37 hgbot Status scheduled => resolved
2016-11-28 14:37 hgbot Resolution open => fixed
2016-11-28 14:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6c7c4eaa77794dcda2ff3180a1b06192c0429709 [^]
2016-11-28 14:54 guillermogil Note Added: 0091896
2016-11-28 15:34 marvintm Note Added: 0091897
2016-11-28 15:34 marvintm Status resolved => new
2016-11-28 15:34 marvintm Resolution fixed => open
2016-11-29 11:24 ranjith_qualiantech_com Relationship added related to 0033901
2016-11-30 09:59 hgbot Checkin
2016-11-30 09:59 hgbot Note Added: 0091922
2016-11-30 09:59 hgbot Status new => resolved
2016-11-30 09:59 hgbot Resolution open => fixed
2016-11-30 09:59 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6c7c4eaa77794dcda2ff3180a1b06192c0429709 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6cce74429ee17026a2a8038be1ebd043a5348ca3 [^]
2016-11-30 17:20 hgbot Checkin
2016-11-30 17:20 hgbot Note Added: 0091938
2016-11-30 17:21 hgbot Checkin
2016-11-30 17:21 hgbot Note Added: 0091939
2016-11-30 17:21 marvintm Review Assigned To => marvintm
2016-11-30 17:21 marvintm Status resolved => closed
2016-11-30 17:21 marvintm Fixed in Version => RR17Q1
2016-12-01 16:33 marvintm Assigned To ranjith_qualiantech_com => guilleaer
2016-12-01 16:33 marvintm Note Added: 0091981
2016-12-01 16:33 marvintm Status closed => new
2016-12-01 16:33 marvintm Resolution fixed => open
2016-12-01 16:33 marvintm Fixed in Version RR17Q1 =>
2016-12-09 10:34 marvintm Status new => scheduled
2016-12-09 10:34 marvintm Status scheduled => resolved
2016-12-09 10:34 marvintm Resolution open => fixed
2016-12-09 10:35 marvintm Note Added: 0092238
2016-12-09 10:35 marvintm Status resolved => closed
2016-12-09 10:35 marvintm Fixed in Version => RR17Q1
2016-12-14 16:55 guilleaer Relationship added related to 0034733
2016-12-19 09:33 hgbot Checkin
2016-12-19 09:33 hgbot Note Added: 0092753

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker