Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034690 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Invoices Register Book | major | always | 2016-12-05 10:34 | 2016-12-14 15:58 | |||
| Reporter | egoitz | View Status | public | |||||
| Assigned To | collazoandy4 | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 60cdcf9fa32b | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Oracle | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | aferraz | |||||||
| Regression introduced in release | ||||||||
| Summary | 0034690: Performance problems on the invoice register book | |||||||
| Description | The execution on the invoice register book takes one hour to get the report for one month. | |||||||
| Steps To Reproduce | ON an environment with big amount of data. 0-Install the Spanish professional localization pack and apply the datasets 1-Go to the invoice register book 2-Create a new entry for "==Libro Registro Recibidas" for a a year/month where there are thousands of invoices. 3-Click on create. The process takes long. http://forge.openbravo.com/plugins/mwiki/index.php/Invoicesregisterbook/UserDocumentation [^] | |||||||
| Proposed Solution | 1) ON the file CreateBookLines change the method getIRBLOperationDate by using a obcriteria instead of invoice.getReversedInvoicesList(); 2) On the file CreateBookLinesDao change the method getInvoicesRegisterBookLine to not execute a .list but a unique result as only the first value is used. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0092227) markmm82 (developer) 2016-12-08 20:14 |
Please add more details to be able to reproduce the issue. Can you specify the report is needed to run? |
|
(0092300) egoitz (manager) 2016-12-13 08:41 |
steps to reproduce updated |
|
(0092354) hgbot (developer) 2016-12-14 15:41 |
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook Changeset: 918836dc74c8a95e501a4b1975b57e4836616fa1 Author: Armaignac <collazoandy4 <at> gmail.com> Date: Mon Dec 12 18:58:17 2016 -0800 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/918836dc74c8a95e501a4b1975b57e4836616fa1 [^] Fixes issue 34690: Performance problems on the invoice register book Implemented a proposed solution from the issue, changing the methods CreateBookLines.getIRBLOperationDate instance of using invoice.getReversedInvoicesList() a OBCriteria is now created to get the ReversedInvoicesList and CreateBookLinesDao.getInvoicesRegisterBookLine signature was change instance return a List<InvoicesRegisterBookLine> now the first InvoicesRegisterBookLine is return if exist and null if not also the CreateBookLines.getExistingLineInBook was refactor for the api change. --- M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java --- |
|
(0092355) hgbot (developer) 2016-12-14 15:42 |
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook Changeset: 5d1dfe7bb15c53ecc6dad7550b9053bda7e82e09 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Wed Dec 14 13:41:42 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/5d1dfe7bb15c53ecc6dad7550b9053bda7e82e09 [^] Related to issue 34690: Fix warnings in CreateBookLines and CreateBookLinesDao --- M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java --- |
|
(0092356) hgbot (developer) 2016-12-14 15:42 |
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook Changeset: 0d536bf87678b4757efcd96073905c8840d7b72c Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Wed Dec 14 13:43:46 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/0d536bf87678b4757efcd96073905c8840d7b72c [^] Related to issue 34690: Update module version --- M src-db/database/sourcedata/AD_MODULE.xml --- |
|
(0092360) hgbot (developer) 2016-12-14 15:54 |
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook Changeset: 60cdcf9fa32bfa90ca7625db0d17017e1060e015 Author: Armaignac <collazoandy4 <at> gmail.com> Date: Mon Dec 12 18:58:17 2016 -0800 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/60cdcf9fa32bfa90ca7625db0d17017e1060e015 [^] Fixes issue 34690: Performance problems on the invoice register book Implemented a proposed solution from the issue, changing the methods CreateBookLines.getIRBLOperationDate instance of using invoice.getReversedInvoicesList() a OBCriteria is now created to get the ReversedInvoicesList and CreateBookLinesDao.getInvoicesRegisterBookLine signature was change instance return a List<InvoicesRegisterBookLine> now the first InvoicesRegisterBookLine is return if exist and null if not also the CreateBookLines.getExistingLineInBook was refactor for the api change. --- M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java --- |
|
(0092361) hgbot (developer) 2016-12-14 15:54 |
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook Changeset: b5ff090ffec03177674f9bb9b62520c3d0a1951f Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Wed Dec 14 13:58:58 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/b5ff090ffec03177674f9bb9b62520c3d0a1951f [^] Related to issue 34690: Fix warnings in CreateBookLinesDao --- M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java --- |
|
(0092362) hgbot (developer) 2016-12-14 15:55 |
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook Changeset: 24459c60680c77934ec59357273b873db8f34aa8 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Wed Dec 14 13:59:59 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/24459c60680c77934ec59357273b873db8f34aa8 [^] Related to issue 34690: Update module version --- M src-db/database/sourcedata/AD_MODULE.xml --- |
|
(0092363) aferraz (manager) 2016-12-14 15:58 |
Code review + Testing OK |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-12-05 10:34 | egoitz | New Issue | |
| 2016-12-05 10:34 | egoitz | Assigned To | => Triage Finance |
| 2016-12-05 10:34 | egoitz | Resolution time | => 1482879600 |
| 2016-12-07 17:49 | collazoandy4 | Assigned To | Triage Finance => markmm82 |
| 2016-12-07 17:50 | collazoandy4 | Status | new => scheduled |
| 2016-12-08 20:13 | markmm82 | Note Added: 0092225 | |
| 2016-12-08 20:14 | markmm82 | Note Added: 0092227 | |
| 2016-12-08 20:14 | markmm82 | Status | scheduled => feedback |
| 2016-12-08 20:15 | markmm82 | Note Deleted: 0092225 | |
| 2016-12-12 16:32 | aferraz | Assigned To | markmm82 => collazoandy4 |
| 2016-12-12 16:32 | aferraz | Status | feedback => new |
| 2016-12-12 16:33 | aferraz | Relationship added | related to 0034642 |
| 2016-12-13 08:41 | egoitz | Steps to Reproduce Updated | View Revisions |
| 2016-12-13 08:41 | egoitz | Note Added: 0092300 | |
| 2016-12-14 15:41 | hgbot | Checkin | |
| 2016-12-14 15:41 | hgbot | Note Added: 0092354 | |
| 2016-12-14 15:41 | hgbot | Status | new => resolved |
| 2016-12-14 15:41 | hgbot | Resolution | open => fixed |
| 2016-12-14 15:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/918836dc74c8a95e501a4b1975b57e4836616fa1 [^] |
| 2016-12-14 15:42 | hgbot | Checkin | |
| 2016-12-14 15:42 | hgbot | Note Added: 0092355 | |
| 2016-12-14 15:42 | hgbot | Checkin | |
| 2016-12-14 15:42 | hgbot | Note Added: 0092356 | |
| 2016-12-14 15:54 | hgbot | Checkin | |
| 2016-12-14 15:54 | hgbot | Note Added: 0092360 | |
| 2016-12-14 15:54 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/918836dc74c8a95e501a4b1975b57e4836616fa1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/60cdcf9fa32bfa90ca7625db0d17017e1060e015 [^] |
| 2016-12-14 15:54 | hgbot | Checkin | |
| 2016-12-14 15:54 | hgbot | Note Added: 0092361 | |
| 2016-12-14 15:55 | hgbot | Checkin | |
| 2016-12-14 15:55 | hgbot | Note Added: 0092362 | |
| 2016-12-14 15:58 | aferraz | Review Assigned To | => aferraz |
| 2016-12-14 15:58 | aferraz | Note Added: 0092363 | |
| 2016-12-14 15:58 | aferraz | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |