Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034690ModulesInvoices Register Bookpublic2016-12-05 10:342016-12-14 15:58
Reporteregoitz 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0034690: Performance problems on the invoice register book
DescriptionThe execution on the invoice register book takes one hour to get the report for one month.
Steps To ReproduceON an environment with big amount of data.
0-Install the Spanish professional localization pack and apply the datasets
1-Go to the invoice register book
2-Create a new entry for "==Libro Registro Recibidas" for a a year/month where there are thousands of invoices.
3-Click on create. The process takes long.

http://forge.openbravo.com/plugins/mwiki/index.php/Invoicesregisterbook/UserDocumentation [^]
Proposed Solution1) ON the file CreateBookLines
change the method
getIRBLOperationDate
by using a obcriteria instead of invoice.getReversedInvoicesList();


2) On the file
CreateBookLinesDao
change the method
getInvoicesRegisterBookLine
to not execute a .list but a unique result
as only the first value is used.


Additional Information
TagsNo tags attached.
Relationships
related to defect 0034642 closed Sanjota Localization Pack: Spain performance problem with "create register book" process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-05 10:34egoitzNew Issue
2016-12-05 10:34egoitzAssigned To => Triage Finance
2016-12-05 10:34egoitzResolution time => 1482879600
2016-12-07 17:49collazoandy4Assigned ToTriage Finance => markmm82
2016-12-07 17:50collazoandy4Statusnew => scheduled
2016-12-08 20:13markmm82Note Added: 0092225
2016-12-08 20:14markmm82Note Added: 0092227
2016-12-08 20:14markmm82Statusscheduled => feedback
2016-12-08 20:15markmm82Note Deleted: 0092225
2016-12-12 16:32aferrazAssigned Tomarkmm82 => collazoandy4
2016-12-12 16:32aferrazStatusfeedback => new
2016-12-12 16:33aferrazRelationship addedrelated to 0034642
2016-12-13 08:41egoitzSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13979#r13979
2016-12-13 08:41egoitzNote Added: 0092300
2016-12-14 15:41hgbotCheckin
2016-12-14 15:41hgbotNote Added: 0092354
2016-12-14 15:41hgbotStatusnew => resolved
2016-12-14 15:41hgbotResolutionopen => fixed
2016-12-14 15:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/918836dc74c8a95e501a4b1975b57e4836616fa1 [^]
2016-12-14 15:42hgbotCheckin
2016-12-14 15:42hgbotNote Added: 0092355
2016-12-14 15:42hgbotCheckin
2016-12-14 15:42hgbotNote Added: 0092356
2016-12-14 15:54hgbotCheckin
2016-12-14 15:54hgbotNote Added: 0092360
2016-12-14 15:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/918836dc74c8a95e501a4b1975b57e4836616fa1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/60cdcf9fa32bfa90ca7625db0d17017e1060e015 [^]
2016-12-14 15:54hgbotCheckin
2016-12-14 15:54hgbotNote Added: 0092361
2016-12-14 15:55hgbotCheckin
2016-12-14 15:55hgbotNote Added: 0092362
2016-12-14 15:58aferrazReview Assigned To => aferraz
2016-12-14 15:58aferrazNote Added: 0092363
2016-12-14 15:58aferrazStatusresolved => closed

Notes
(0092227)
markmm82   
2016-12-08 20:14   
Please add more details to be able to reproduce the issue. Can you specify the report is needed to run?
(0092300)
egoitz   
2016-12-13 08:41   
steps to reproduce updated
(0092354)
hgbot   
2016-12-14 15:41   
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook
Changeset: 918836dc74c8a95e501a4b1975b57e4836616fa1
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Dec 12 18:58:17 2016 -0800
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/918836dc74c8a95e501a4b1975b57e4836616fa1 [^]

Fixes issue 34690: Performance problems on the invoice register book

Implemented a proposed solution from the issue, changing the methods CreateBookLines.getIRBLOperationDate instance of using
invoice.getReversedInvoicesList() a OBCriteria is now created to get the ReversedInvoicesList and CreateBookLinesDao.getInvoicesRegisterBookLine
signature was change instance return a List<InvoicesRegisterBookLine> now the first InvoicesRegisterBookLine is return if exist and null if not
also the CreateBookLines.getExistingLineInBook was refactor for the api change.

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java
---
(0092355)
hgbot   
2016-12-14 15:42   
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook
Changeset: 5d1dfe7bb15c53ecc6dad7550b9053bda7e82e09
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 14 13:41:42 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/5d1dfe7bb15c53ecc6dad7550b9053bda7e82e09 [^]

Related to issue 34690: Fix warnings in CreateBookLines and CreateBookLinesDao

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java
---
(0092356)
hgbot   
2016-12-14 15:42   
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook
Changeset: 0d536bf87678b4757efcd96073905c8840d7b72c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 14 13:43:46 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/0d536bf87678b4757efcd96073905c8840d7b72c [^]

Related to issue 34690: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0092360)
hgbot   
2016-12-14 15:54   
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook
Changeset: 60cdcf9fa32bfa90ca7625db0d17017e1060e015
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Dec 12 18:58:17 2016 -0800
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/60cdcf9fa32bfa90ca7625db0d17017e1060e015 [^]

Fixes issue 34690: Performance problems on the invoice register book

Implemented a proposed solution from the issue, changing the methods CreateBookLines.getIRBLOperationDate instance of using
invoice.getReversedInvoicesList() a OBCriteria is now created to get the ReversedInvoicesList and CreateBookLinesDao.getInvoicesRegisterBookLine
signature was change instance return a List<InvoicesRegisterBookLine> now the first InvoicesRegisterBookLine is return if exist and null if not
also the CreateBookLines.getExistingLineInBook was refactor for the api change.

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java
---
(0092361)
hgbot   
2016-12-14 15:54   
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook
Changeset: b5ff090ffec03177674f9bb9b62520c3d0a1951f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 14 13:58:58 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/b5ff090ffec03177674f9bb9b62520c3d0a1951f [^]

Related to issue 34690: Fix warnings in CreateBookLinesDao

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java
---
(0092362)
hgbot   
2016-12-14 15:55   
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook
Changeset: 24459c60680c77934ec59357273b873db8f34aa8
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 14 13:59:59 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/24459c60680c77934ec59357273b873db8f34aa8 [^]

Related to issue 34690: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0092363)
aferraz   
2016-12-14 15:58   
Code review + Testing OK