0034523: Some static fields of OBScheduler should be declared as private

Notes
(0092888) hgbot (developer) 2016-12-21 09:39	Repository: erp/devel/pi Changeset: f743e6a8fb9a0a15736d255d44279ed4fdef9a48 Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Tue Dec 20 10:58:44 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/f743e6a8fb9a0a15736d255d44279ed4fdef9a48 [^] Fixed issue 34523: Two OBScheduler fields are now private There was a problem with the "dateTimeFormat" and the "sqlDateTimeFormat" fields of the OBScheduler class. These static fields were public, so, anyone could access them and change their value. That could cause problems, for example in clustered envirnoments. The OBScheduler is a singleton, so it makes no sense to have those fields set as static. Now the fields are now declared as private, so the proper getters have been created. --- M src/org/openbravo/scheduling/OBScheduler.java M src/org/openbravo/scheduling/ProcessMonitor.java ---

(0092889) hgbot (developer) 2016-12-21 09:52	Repository: erp/devel/pi Changeset: 9464c0252b01729a148c285d8180271db19343f6 Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Wed Dec 21 09:50:56 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/9464c0252b01729a148c285d8180271db19343f6 [^] Related with issue 34523: The copyright date updated. The year of the copyright of "ProcessMonitor" have been updated. --- M src/org/openbravo/scheduling/ProcessMonitor.java ---

(0092906) hudsonbot (developer) 2016-12-21 14:48	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3ac66db84fc1 [^] Maturity status: Test

(0092922) hudsonbot (developer) 2016-12-21 20:51	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/abc21394bfb8 [^] Maturity status: Test

(0092958) hgbot (developer) 2016-12-23 08:47	Repository: erp/devel/pi Changeset: 304cd8d235f9da3d5d3fc15e3c272aabd151f769 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Dec 23 08:46:42 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/304cd8d235f9da3d5d3fc15e3c272aabd151f769 [^] related to issue 34523: downgraded visibility of new methods - getDateTimeFormat wasn't invoked anywhere, it's been removed - getSqlDateTimeFormat visibility downgraded from public to package --- M src/org/openbravo/scheduling/OBScheduler.java ---

(0092959) alostale (manager) 2016-12-23 08:48	code reviewed and tested: everywhere these fields are used their value is correctly set.

(0092988) hudsonbot (developer) 2016-12-23 20:42	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/17b1229a255e [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2016-11-15 10:40	caristu	New Issue
2016-11-15 10:40	caristu	Assigned To	=> platform
2016-11-15 10:40	caristu	Modules	=> Core
2016-11-15 10:40	caristu	Triggers an Emergency Pack	=> No
2016-11-15 10:41	caristu	Description Updated	View Revisions
2016-11-15 10:41	caristu	Relationship added	related to 0034490
2016-11-15 11:15	caristu	Summary	[clustering] some static fields of OBScheduler should be declared as private => Some static fields of OBScheduler should be declared as private
2016-11-16 16:39	alostale	Relationship deleted	related to 0034490
2016-12-01 12:19	alostale	Status	new => acknowledged
2016-12-01 13:20	alostale	Priority	high => normal
2016-12-01 14:03	alostale	Priority	normal => high
2016-12-09 15:40	NaroaIriarte	Assigned To	platform => NaroaIriarte
2016-12-09 15:40	NaroaIriarte	Status	acknowledged => scheduled
2016-12-09 15:40	NaroaIriarte	Review Assigned To	=> alostale
2016-12-13 07:53	alostale	Relationship added	related to 0034664
2016-12-13 10:59	NaroaIriarte	Status	scheduled => acknowledged
2016-12-20 11:07	NaroaIriarte	Status	acknowledged => scheduled
2016-12-21 09:35	NaroaIriarte	Relationship added	related to 0034788
2016-12-21 09:39	hgbot	Checkin
2016-12-21 09:39	hgbot	Note Added: 0092888
2016-12-21 09:39	hgbot	Status	scheduled => resolved
2016-12-21 09:39	hgbot	Resolution	open => fixed
2016-12-21 09:39	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/f743e6a8fb9a0a15736d255d44279ed4fdef9a48 [^]
2016-12-21 09:52	hgbot	Checkin
2016-12-21 09:52	hgbot	Note Added: 0092889
2016-12-21 14:48	hudsonbot	Checkin
2016-12-21 14:48	hudsonbot	Note Added: 0092906
2016-12-21 20:51	hudsonbot	Checkin
2016-12-21 20:51	hudsonbot	Note Added: 0092922
2016-12-23 08:47	hgbot	Checkin
2016-12-23 08:47	hgbot	Note Added: 0092958
2016-12-23 08:48	alostale	Note Added: 0092959
2016-12-23 08:48	alostale	Status	resolved => closed
2016-12-23 08:48	alostale	Fixed in Version	=> 3.0PR17Q1
2016-12-23 20:42	hudsonbot	Checkin
2016-12-23 20:42	hudsonbot	Note Added: 0092988