Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034523Openbravo ERPA. Platformpublic2016-11-15 10:402016-12-23 20:42
Reportercaristu 
Assigned ToNaroaIriarte 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034523: Some static fields of OBScheduler should be declared as private
DescriptionThe following two static fields of OBScheduler class should be declared as private:

 - dateTimeFormat
 - sqlDateTimeFormat

Currently as both fields are public they are behaving like caches, that can cause bad behavior on clustered environments.
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0034664 acknowledged Triage Platform Base multi thread unsafeties 
related to defect 0034788 closed NaroaIriarte API change because two fields of OBScheduler have changed to private 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-15 10:40caristuNew Issue
2016-11-15 10:40caristuAssigned To => platform
2016-11-15 10:40caristuModules => Core
2016-11-15 10:40caristuTriggers an Emergency Pack => No
2016-11-15 10:41caristuDescription Updatedbug_revision_view_page.php?rev_id=13722#r13722
2016-11-15 10:41caristuRelationship addedrelated to 0034490
2016-11-15 11:15caristuSummary[clustering] some static fields of OBScheduler should be declared as private => Some static fields of OBScheduler should be declared as private
2016-11-16 16:39alostaleRelationship deletedrelated to 0034490
2016-12-01 12:19alostaleStatusnew => acknowledged
2016-12-01 13:20alostalePriorityhigh => normal
2016-12-01 14:03alostalePrioritynormal => high
2016-12-09 15:40NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-12-09 15:40NaroaIriarteStatusacknowledged => scheduled
2016-12-09 15:40NaroaIriarteReview Assigned To => alostale
2016-12-13 07:53alostaleRelationship addedrelated to 0034664
2016-12-13 10:59NaroaIriarteStatusscheduled => acknowledged
2016-12-20 11:07NaroaIriarteStatusacknowledged => scheduled
2016-12-21 09:35NaroaIriarteRelationship addedrelated to 0034788
2016-12-21 09:39hgbotCheckin
2016-12-21 09:39hgbotNote Added: 0092888
2016-12-21 09:39hgbotStatusscheduled => resolved
2016-12-21 09:39hgbotResolutionopen => fixed
2016-12-21 09:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f743e6a8fb9a0a15736d255d44279ed4fdef9a48 [^]
2016-12-21 09:52hgbotCheckin
2016-12-21 09:52hgbotNote Added: 0092889
2016-12-21 14:48hudsonbotCheckin
2016-12-21 14:48hudsonbotNote Added: 0092906
2016-12-21 20:51hudsonbotCheckin
2016-12-21 20:51hudsonbotNote Added: 0092922
2016-12-23 08:47hgbotCheckin
2016-12-23 08:47hgbotNote Added: 0092958
2016-12-23 08:48alostaleNote Added: 0092959
2016-12-23 08:48alostaleStatusresolved => closed
2016-12-23 08:48alostaleFixed in Version => 3.0PR17Q1
2016-12-23 20:42hudsonbotCheckin
2016-12-23 20:42hudsonbotNote Added: 0092988

Notes
(0092888)
hgbot   
2016-12-21 09:39   
Repository: erp/devel/pi
Changeset: f743e6a8fb9a0a15736d255d44279ed4fdef9a48
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Tue Dec 20 10:58:44 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f743e6a8fb9a0a15736d255d44279ed4fdef9a48 [^]

Fixed issue 34523: Two OBScheduler fields are now private

There was a problem with the "dateTimeFormat" and the "sqlDateTimeFormat" fields of the OBScheduler class. These static fields were public, so, anyone could access them and change their value. That could cause problems, for example in clustered envirnoments.
The OBScheduler is a singleton, so it makes no sense to have those fields set as static.
Now the fields are now declared as private, so the proper getters have been created.

---
M src/org/openbravo/scheduling/OBScheduler.java
M src/org/openbravo/scheduling/ProcessMonitor.java
---
(0092889)
hgbot   
2016-12-21 09:52   
Repository: erp/devel/pi
Changeset: 9464c0252b01729a148c285d8180271db19343f6
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Dec 21 09:50:56 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9464c0252b01729a148c285d8180271db19343f6 [^]

Related with issue 34523: The copyright date updated.

The year of the copyright of "ProcessMonitor" have been updated.

---
M src/org/openbravo/scheduling/ProcessMonitor.java
---
(0092906)
hudsonbot   
2016-12-21 14:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3ac66db84fc1 [^]
Maturity status: Test
(0092922)
hudsonbot   
2016-12-21 20:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/abc21394bfb8 [^]
Maturity status: Test
(0092958)
hgbot   
2016-12-23 08:47   
Repository: erp/devel/pi
Changeset: 304cd8d235f9da3d5d3fc15e3c272aabd151f769
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Dec 23 08:46:42 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/304cd8d235f9da3d5d3fc15e3c272aabd151f769 [^]

related to issue 34523: downgraded visibility of new methods

  - getDateTimeFormat wasn't invoked anywhere, it's been removed
  - getSqlDateTimeFormat visibility downgraded from public to package

---
M src/org/openbravo/scheduling/OBScheduler.java
---
(0092959)
alostale   
2016-12-23 08:48   
code reviewed and tested: everywhere these fields are used their value is correctly set.
(0092988)
hudsonbot   
2016-12-23 20:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/17b1229a255e [^]
Maturity status: Test