Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034519 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | always | 2016-11-15 10:24 | 2016-12-16 18:39 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | NaroaIriarte | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 9639ef48df7d | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034519: Some constants are not declared as final | |||||||
| Description | There exists some constants which are not declared as final and they should be: src/org/openbravo/erpCommon/businessUtility/Preferences.java - public static String YES = "Y"; - public static String NO = "N"; src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java - public static String REVERSE_PREFIX = "*R*"; - public static String ZERO_PAYMENT_SUFIX = "*Z*"; - public static String DOCTYPE_MatShipment = "MMS"; - public static int PAYMENT_DOCNO_LENGTH = 30; modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinitionController.java - public static String SHORTFORMAT_QUALIFIER = "Relation"; - public static String INPUTFORMAT_QUALIFIER = "Edition"; - public static String NORMALFORMAT_QUALIFIER = "Inform"; src-core/src/org/openbravo/uiTranslation/WindowLabel.java - public static int FIELD_LABEL = 0; - public static int FIELD_GROUP_LABEL = 1; - public static int BUTTON_LABEL = 2; src-core/src/org/openbravo/uiTranslation/InterfaceInfo.java - public static int TAB = 0, PROCESS = 1, FORM = 2; | |||||||
| Steps To Reproduce | In description | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0092188) hgbot (developer) 2016-12-07 13:48 |
Repository: erp/devel/pi Changeset: 9639ef48df7dc6f78e3dab0da900e7bb44b8a648 Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Mon Dec 05 13:35:59 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/9639ef48df7dc6f78e3dab0da900e7bb44b8a648 [^] Fixed issue 34519: Some constans needed to be final. There were some constants that needed to be declared as final but they wherent. --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinitionController.java M src-core/src/org/openbravo/uiTranslation/InterfaceInfo.java M src-core/src/org/openbravo/uiTranslation/WindowLabel.java M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java M src/org/openbravo/erpCommon/businessUtility/Preferences.java --- |
|
(0092299) alostale (manager) 2016-12-13 08:34 |
code reviewed |
|
(0092693) hudsonbot (developer) 2016-12-16 18:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-11-15 10:24 | caristu | New Issue | |
| 2016-11-15 10:24 | caristu | Assigned To | => platform |
| 2016-11-15 10:24 | caristu | Modules | => Core |
| 2016-11-15 10:24 | caristu | Triggers an Emergency Pack | => No |
| 2016-11-15 10:24 | caristu | Description Updated | View Revisions |
| 2016-11-15 10:25 | caristu | Relationship added | blocks 0034490 |
| 2016-11-15 10:25 | caristu | Relationship deleted | blocks 0034490 |
| 2016-11-15 10:25 | caristu | Relationship added | related to 0034490 |
| 2016-11-15 11:15 | caristu | Summary | [clustering] Some constants are not declared as final => Some constants are not declared as final |
| 2016-11-16 16:39 | alostale | Relationship deleted | related to 0034490 |
| 2016-12-01 12:53 | alostale | Status | new => acknowledged |
| 2016-12-01 13:20 | alostale | Priority | high => normal |
| 2016-12-05 13:13 | NaroaIriarte | Assigned To | platform => NaroaIriarte |
| 2016-12-05 13:22 | NaroaIriarte | Status | acknowledged => scheduled |
| 2016-12-07 13:32 | alostale | Relationship added | depends on 0034698 |
| 2016-12-07 13:44 | NaroaIriarte | Review Assigned To | => alostale |
| 2016-12-07 13:48 | hgbot | Checkin | |
| 2016-12-07 13:48 | hgbot | Note Added: 0092188 | |
| 2016-12-07 13:48 | hgbot | Status | scheduled => resolved |
| 2016-12-07 13:48 | hgbot | Resolution | open => fixed |
| 2016-12-07 13:48 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/9639ef48df7dc6f78e3dab0da900e7bb44b8a648 [^] |
| 2016-12-13 08:32 | alostale | Relationship added | blocks 0034664 |
| 2016-12-13 08:34 | alostale | Note Added: 0092299 | |
| 2016-12-13 08:34 | alostale | Status | resolved => closed |
| 2016-12-13 08:34 | alostale | Fixed in Version | => 3.0PR17Q1 |
| 2016-12-16 18:39 | hudsonbot | Checkin | |
| 2016-12-16 18:39 | hudsonbot | Note Added: 0092693 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |