Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034519Openbravo ERPA. Platformpublic2016-11-15 10:242016-12-16 18:39
Reportercaristu 
Assigned ToNaroaIriarte 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034519: Some constants are not declared as final
DescriptionThere exists some constants which are not declared as final and they should be:

src/org/openbravo/erpCommon/businessUtility/Preferences.java
  - public static String YES = "Y";
  - public static String NO = "N";

src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
  - public static String REVERSE_PREFIX = "*R*";
  - public static String ZERO_PAYMENT_SUFIX = "*Z*";
  - public static String DOCTYPE_MatShipment = "MMS";
  - public static int PAYMENT_DOCNO_LENGTH = 30;

modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinitionController.java
  - public static String SHORTFORMAT_QUALIFIER = "Relation";
  - public static String INPUTFORMAT_QUALIFIER = "Edition";
  - public static String NORMALFORMAT_QUALIFIER = "Inform";

src-core/src/org/openbravo/uiTranslation/WindowLabel.java
  - public static int FIELD_LABEL = 0;
  - public static int FIELD_GROUP_LABEL = 1;
  - public static int BUTTON_LABEL = 2;

src-core/src/org/openbravo/uiTranslation/InterfaceInfo.java
  - public static int TAB = 0, PROCESS = 1, FORM = 2;
  
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0034698 closed NaroaIriarte API change because some constants need to be final 
blocks design defect 0034664 acknowledged Triage Platform Base multi thread unsafeties 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-15 10:24caristuNew Issue
2016-11-15 10:24caristuAssigned To => platform
2016-11-15 10:24caristuModules => Core
2016-11-15 10:24caristuTriggers an Emergency Pack => No
2016-11-15 10:24caristuDescription Updatedbug_revision_view_page.php?rev_id=13720#r13720
2016-11-15 10:25caristuRelationship addedblocks 0034490
2016-11-15 10:25caristuRelationship deletedblocks 0034490
2016-11-15 10:25caristuRelationship addedrelated to 0034490
2016-11-15 11:15caristuSummary[clustering] Some constants are not declared as final => Some constants are not declared as final
2016-11-16 16:39alostaleRelationship deletedrelated to 0034490
2016-12-01 12:53alostaleStatusnew => acknowledged
2016-12-01 13:20alostalePriorityhigh => normal
2016-12-05 13:13NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-12-05 13:22NaroaIriarteStatusacknowledged => scheduled
2016-12-07 13:32alostaleRelationship addeddepends on 0034698
2016-12-07 13:44NaroaIriarteReview Assigned To => alostale
2016-12-07 13:48hgbotCheckin
2016-12-07 13:48hgbotNote Added: 0092188
2016-12-07 13:48hgbotStatusscheduled => resolved
2016-12-07 13:48hgbotResolutionopen => fixed
2016-12-07 13:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9639ef48df7dc6f78e3dab0da900e7bb44b8a648 [^]
2016-12-13 08:32alostaleRelationship addedblocks 0034664
2016-12-13 08:34alostaleNote Added: 0092299
2016-12-13 08:34alostaleStatusresolved => closed
2016-12-13 08:34alostaleFixed in Version => 3.0PR17Q1
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092693

Notes
(0092188)
hgbot   
2016-12-07 13:48   
Repository: erp/devel/pi
Changeset: 9639ef48df7dc6f78e3dab0da900e7bb44b8a648
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Dec 05 13:35:59 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9639ef48df7dc6f78e3dab0da900e7bb44b8a648 [^]

Fixed issue 34519: Some constans needed to be final.

There were some constants that needed to be declared as final but they wherent.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinitionController.java
M src-core/src/org/openbravo/uiTranslation/InterfaceInfo.java
M src-core/src/org/openbravo/uiTranslation/WindowLabel.java
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
M src/org/openbravo/erpCommon/businessUtility/Preferences.java
---
(0092299)
alostale   
2016-12-13 08:34   
code reviewed
(0092693)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test