Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0034495

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2016-11-14 15:42

2016-11-30 11:26

Reporter

guillermogil

View Status

public

Assigned To

mario_castello

Priority

urgent

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

migueldejuana

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0034495: If you add an approval over prePaymentHook scope function is getting lost

Description

If you add an approval over prePaymentHook scope function is getting lost.
It is triggering approvalChecked and it is not taking into account the hooks structure.

Steps To Reproduce

Implement a hook on OBPOS_prePaymentHook
On that create an approval

Validate the approval and you will see how the tab gets changed even without callig to the callbackExecutor of the hook.

Proposed Solution

Talk to GIG

Tags

No tags attached.

issue34495.diff [^] (1,514 bytes) 2016-11-21 14:36 [Show Content] [Hide Content]

diff -r 87c1e0574f75 web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js	Wed Nov 16 16:30:04 2016 +0100
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js	Mon Nov 21 14:36:26 2016 +0100
@@ -963,6 +963,12 @@
         context: me,
         caller: caller
       }, function () {
+        me.on('approvalChecked', function (event) {
+          me.off('approvalChecked');
+          if (event.approved) {
+            me.trigger('showPaymentTab');
+          }
+        }, this);
         me.checkPaymentApproval(caller);
       });
     });
diff -r 87c1e0574f75 web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js	Wed Nov 16 16:30:04 2016 +0100
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js	Mon Nov 21 14:36:26 2016 +0100
@@ -447,11 +447,9 @@
         return;
       }
       var synchId = OB.UTIL.SynchronizationHelper.busyUntilFinishes('toolbarButtonTabTap');
-      this.model.on('approvalChecked', function (event) {
-        this.model.off('approvalChecked');
-        if (event.approved) {
+      this.model.on('showPaymentTab', function (event) {
+        this.model.off('showPaymentTab');
           this.showPaymentTab();
-        }
       }, this);
 
       if (OB.MobileApp.model.hasPermission('OBPOS_remote.product', true)) {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0091852) hgbot (developer) 2016-11-25 15:06	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d574954bc0c30e6aaf960ae074b955c17253b9b3 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Fri Nov 25 08:00:43 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d574954bc0c30e6aaf960ae074b955c17253b9b3 [^] Fixed issue 0034495: If you add an approval over prePaymentHook scope function is getting lost - Added validation to prevent show PaymentTab before finish the execution of hook OBPOS_CheckPaymentApproval --- M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js ---

(0091928) migueldejuana (viewer) 2016-11-30 11:26	Tested and reviewed

Issue History
Date Modified	Username	Field	Change
2016-11-14 15:42	guillermogil	New Issue
2016-11-14 15:42	guillermogil	Assigned To	=> Retail
2016-11-14 15:42	guillermogil	OBNetwork customer	=> Yes
2016-11-14 15:42	guillermogil	Resolution time	=> 1480892400
2016-11-14 15:42	guillermogil	Triggers an Emergency Pack	=> No
2016-11-21 14:36	marvintm	File Added: issue34495.diff
2016-11-21 16:06	mario_castello	Assigned To	Retail => mario_castello
2016-11-21 16:06	mario_castello	Status	new => acknowledged
2016-11-22 15:49	mario_castello	Status	acknowledged => scheduled
2016-11-25 15:06	hgbot	Checkin
2016-11-25 15:06	hgbot	Note Added: 0091852
2016-11-25 15:06	hgbot	Status	scheduled => resolved
2016-11-25 15:06	hgbot	Resolution	open => fixed
2016-11-25 15:06	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d574954bc0c30e6aaf960ae074b955c17253b9b3 [^]
2016-11-30 11:26	migueldejuana	Review Assigned To	=> migueldejuana
2016-11-30 11:26	migueldejuana	Note Added: 0091928
2016-11-30 11:26	migueldejuana	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group