Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034495
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-11-14 15:422016-11-30 11:26
ReporterguillermogilView Statuspublic 
Assigned Tomario_castello 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiond574954bc0c3
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034495: If you add an approval over prePaymentHook scope function is getting lost

DescriptionIf you add an approval over prePaymentHook scope function is getting lost.
It is triggering approvalChecked and it is not taking into account the hooks structure.
Steps To ReproduceImplement a hook on OBPOS_prePaymentHook
On that create an approval

Validate the approval and you will see how the tab gets changed even without callig to the callbackExecutor of the hook.
Proposed SolutionTalk to GIG
TagsNo tags attached.
Attached Filesdiff file icon issue34495.diff [^] (1,514 bytes) 2016-11-21 14:36 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0091852)
hgbot (developer)
2016-11-25 15:06

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d574954bc0c30e6aaf960ae074b955c17253b9b3
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 25 08:00:43 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d574954bc0c30e6aaf960ae074b955c17253b9b3 [^]

Fixed issue 0034495: If you add an approval over prePaymentHook scope function is getting lost

- Added validation to prevent show PaymentTab before finish the execution of hook OBPOS_CheckPaymentApproval

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0091928)
migueldejuana (developer)
2016-11-30 11:26

Tested and reviewed

- Issue History
Date Modified Username Field Change
2016-11-14 15:42 guillermogil New Issue
2016-11-14 15:42 guillermogil Assigned To => Retail
2016-11-14 15:42 guillermogil Resolution time => 1480892400
2016-11-14 15:42 guillermogil Triggers an Emergency Pack => No
2016-11-21 14:36 marvintm File Added: issue34495.diff
2016-11-21 16:06 mario_castello Assigned To Retail => mario_castello
2016-11-21 16:06 mario_castello Status new => acknowledged
2016-11-22 15:49 mario_castello Status acknowledged => scheduled
2016-11-25 15:06 hgbot Checkin
2016-11-25 15:06 hgbot Note Added: 0091852
2016-11-25 15:06 hgbot Status scheduled => resolved
2016-11-25 15:06 hgbot Resolution open => fixed
2016-11-25 15:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d574954bc0c30e6aaf960ae074b955c17253b9b3 [^]
2016-11-30 11:26 migueldejuana Review Assigned To => migueldejuana
2016-11-30 11:26 migueldejuana Note Added: 0091928
2016-11-30 11:26 migueldejuana Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker