Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034495Retail ModulesWeb POSpublic2016-11-14 15:422016-11-30 11:26
Reporterguillermogil 
Assigned Tomario_castello 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034495: If you add an approval over prePaymentHook scope function is getting lost
DescriptionIf you add an approval over prePaymentHook scope function is getting lost.
It is triggering approvalChecked and it is not taking into account the hooks structure.
Steps To ReproduceImplement a hook on OBPOS_prePaymentHook
On that create an approval

Validate the approval and you will see how the tab gets changed even without callig to the callbackExecutor of the hook.
Proposed SolutionTalk to GIG
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue34495.diff (1,514) 2016-11-21 14:36
https://issues.openbravo.com/file_download.php?file_id=10079&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-14 15:42guillermogilNew Issue
2016-11-14 15:42guillermogilAssigned To => Retail
2016-11-14 15:42guillermogilOBNetwork customer => Yes
2016-11-14 15:42guillermogilResolution time => 1480892400
2016-11-14 15:42guillermogilTriggers an Emergency Pack => No
2016-11-21 14:36marvintmFile Added: issue34495.diff
2016-11-21 16:06mario_castelloAssigned ToRetail => mario_castello
2016-11-21 16:06mario_castelloStatusnew => acknowledged
2016-11-22 15:49mario_castelloStatusacknowledged => scheduled
2016-11-25 15:06hgbotCheckin
2016-11-25 15:06hgbotNote Added: 0091852
2016-11-25 15:06hgbotStatusscheduled => resolved
2016-11-25 15:06hgbotResolutionopen => fixed
2016-11-25 15:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d574954bc0c30e6aaf960ae074b955c17253b9b3 [^]
2016-11-30 11:26migueldejuanaReview Assigned To => migueldejuana
2016-11-30 11:26migueldejuanaNote Added: 0091928
2016-11-30 11:26migueldejuanaStatusresolved => closed

Notes
(0091852)
hgbot   
2016-11-25 15:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d574954bc0c30e6aaf960ae074b955c17253b9b3
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 25 08:00:43 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d574954bc0c30e6aaf960ae074b955c17253b9b3 [^]

Fixed issue 0034495: If you add an approval over prePaymentHook scope function is getting lost

- Added validation to prevent show PaymentTab before finish the execution of hook OBPOS_CheckPaymentApproval

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0091928)
migueldejuana   
2016-11-30 11:26   
Tested and reviewed