Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034462
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformtrivialalways2016-11-10 13:592016-12-16 18:39
ReportervmromanosView Statuspublic 
Assigned Tocaristu 
PrioritylowResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revisione9f96baecaae
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034462: Process Definition icon in menu should depend on the UI Pattern

DescriptionThe icon in the menu entries depends only on the menu action.
For process definition the icon is like a gear. However inside the process definition window we can now define JR reports too. In this case the icon shouldn't be a gear but a graph as any other report.
Steps To ReproduceAs System Admin

Create a Process Definition. UI Pattern = Report (Using JR templates).
Create a menu entry associated to the previous process definition.
Open the menu and verify the icon is a gear, which is a bit confusing. It should be a graph
Proposed SolutionWhen the menu entry is a Process Definition, check its UI Pattern and set the icon based on it
TagsNo tags attached.
Attached Filespng file icon process_definition_icons.png [^] (347,688 bytes) 2016-11-10 13:59
png file icon report-icon-quick-launch-ok.png [^] (9,256 bytes) 2016-12-02 08:23


png file icon Selection_132.png [^] (20,826 bytes) 2016-12-02 08:23

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0091979)
hgbot (developer)
2016-12-01 16:04

 Repository: erp/devel/pi
Changeset: e9f96baecaae64773cc68841e477d143592b9846
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Dec 01 16:03:13 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e9f96baecaae64773cc68841e477d143592b9846 [^]

fixes issue 34462: Process Definition menu icon should depend on the UI Pattern

The report icon is now selected both when using the quick launch search and the application menu. For this second case, now the UI Pattern is also sent to the client as part of the process definition menu entry. This helps to identify the type of process definition when retrieving the icon for the application menu entry.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationConstants.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/GlobalMenu.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/QuickLaunchDataSource.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/templates/application-menu.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ParameterWindowComponent.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js
---
(0092000)
alostale (viewer)
2016-12-02 08:26

 Reopening:

Created 2 process definitions:

* "p1" -> Standard UI
* "r1" -> Report

Checked icons (see attached images):

* In Quick Launch: correct
* In Application Menu: incorrect, still appears gear icon
(0092004)
alostale (viewer)
2016-12-02 08:39

 Previous comment was incorrect.

Code reviewed

Tested by creating a process definition report: icon is correctly shown in Application Menu, Quick Launch and Recent Views
(0092679)
hudsonbot (viewer)
2016-12-16 18:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-11-10 13:59 vmromanos New Issue
2016-11-10 13:59 vmromanos Assigned To => platform
2016-11-10 13:59 vmromanos File Added: process_definition_icons.png
2016-11-10 13:59 vmromanos OBNetwork customer => No
2016-11-10 13:59 vmromanos Modules => Core
2016-11-10 13:59 vmromanos Triggers an Emergency Pack => No
2016-12-01 12:14 alostale Status new => scheduled
2016-12-01 12:14 alostale Assigned To platform => caristu
2016-12-01 13:15 alostale Priority normal => low
2016-12-01 16:04 hgbot Checkin
2016-12-01 16:04 hgbot Note Added: 0091979
2016-12-01 16:04 hgbot Status scheduled => resolved
2016-12-01 16:04 hgbot Resolution open => fixed
2016-12-01 16:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e9f96baecaae64773cc68841e477d143592b9846 [^]
2016-12-01 16:06 caristu Review Assigned To => alostale
2016-12-02 08:23 alostale File Added: report-icon-quick-launch-ok.png
2016-12-02 08:23 alostale File Added: Selection_132.png
2016-12-02 08:26 alostale Note Added: 0092000
2016-12-02 08:26 alostale Status resolved => new
2016-12-02 08:26 alostale Resolution fixed => open
2016-12-02 08:38 alostale Status new => scheduled
2016-12-02 08:38 alostale Status scheduled => resolved
2016-12-02 08:38 alostale Resolution open => fixed
2016-12-02 08:39 alostale Note Added: 0092004
2016-12-02 08:39 alostale Status resolved => closed
2016-12-02 08:39 alostale Fixed in Version => 3.0PR17Q2
2016-12-02 08:40 alostale Fixed in Version 3.0PR17Q2 => 3.0PR17Q1
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092679

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker