Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034462Openbravo ERPA. Platformpublic2016-11-10 13:592016-12-16 18:39
Reportervmromanos 
Assigned Tocaristu 
PrioritylowSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034462: Process Definition icon in menu should depend on the UI Pattern
DescriptionThe icon in the menu entries depends only on the menu action.
For process definition the icon is like a gear. However inside the process definition window we can now define JR reports too. In this case the icon shouldn't be a gear but a graph as any other report.
Steps To ReproduceAs System Admin

Create a Process Definition. UI Pattern = Report (Using JR templates).
Create a menu entry associated to the previous process definition.
Open the menu and verify the icon is a gear, which is a bit confusing. It should be a graph
Proposed SolutionWhen the menu entry is a Process Definition, check its UI Pattern and set the icon based on it
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng process_definition_icons.png (347,688) 2016-11-10 13:59
https://issues.openbravo.com/file_download.php?file_id=10033&type=bug
png report-icon-quick-launch-ok.png (9,256) 2016-12-02 08:23
https://issues.openbravo.com/file_download.php?file_id=10143&type=bug
png

png Selection_132.png (20,826) 2016-12-02 08:23
https://issues.openbravo.com/file_download.php?file_id=10144&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-11-10 13:59vmromanosNew Issue
2016-11-10 13:59vmromanosAssigned To => platform
2016-11-10 13:59vmromanosFile Added: process_definition_icons.png
2016-11-10 13:59vmromanosModules => Core
2016-11-10 13:59vmromanosTriggers an Emergency Pack => No
2016-12-01 12:14alostaleStatusnew => scheduled
2016-12-01 12:14alostaleAssigned Toplatform => caristu
2016-12-01 13:15alostalePrioritynormal => low
2016-12-01 16:04hgbotCheckin
2016-12-01 16:04hgbotNote Added: 0091979
2016-12-01 16:04hgbotStatusscheduled => resolved
2016-12-01 16:04hgbotResolutionopen => fixed
2016-12-01 16:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e9f96baecaae64773cc68841e477d143592b9846 [^]
2016-12-01 16:06caristuReview Assigned To => alostale
2016-12-02 08:23alostaleFile Added: report-icon-quick-launch-ok.png
2016-12-02 08:23alostaleFile Added: Selection_132.png
2016-12-02 08:26alostaleNote Added: 0092000
2016-12-02 08:26alostaleStatusresolved => new
2016-12-02 08:26alostaleResolutionfixed => open
2016-12-02 08:38alostaleStatusnew => scheduled
2016-12-02 08:38alostaleStatusscheduled => resolved
2016-12-02 08:38alostaleResolutionopen => fixed
2016-12-02 08:39alostaleNote Added: 0092004
2016-12-02 08:39alostaleStatusresolved => closed
2016-12-02 08:39alostaleFixed in Version => 3.0PR17Q2
2016-12-02 08:40alostaleFixed in Version3.0PR17Q2 => 3.0PR17Q1
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092679

Notes
(0091979)
hgbot   
2016-12-01 16:04   
Repository: erp/devel/pi
Changeset: e9f96baecaae64773cc68841e477d143592b9846
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Dec 01 16:03:13 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e9f96baecaae64773cc68841e477d143592b9846 [^]

fixes issue 34462: Process Definition menu icon should depend on the UI Pattern

The report icon is now selected both when using the quick launch search and the application menu. For this second case, now the UI Pattern is also sent to the client as part of the process definition menu entry. This helps to identify the type of process definition when retrieving the icon for the application menu entry.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationConstants.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/GlobalMenu.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/QuickLaunchDataSource.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/templates/application-menu.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ParameterWindowComponent.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js
---
(0092000)
alostale   
2016-12-02 08:26   
Reopening:

Created 2 process definitions:

* "p1" -> Standard UI
* "r1" -> Report

Checked icons (see attached images):

* In Quick Launch: correct
* In Application Menu: incorrect, still appears gear icon
(0092004)
alostale   
2016-12-02 08:39   
Previous comment was incorrect.

Code reviewed

Tested by creating a process definition report: icon is correctly shown in Application Menu, Quick Launch and Recent Views
(0092679)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test