Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034430
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-11-08 16:552016-12-16 10:00
ReporterxabiermerinoView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revisionb9663b2c9a23
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034430: [SERQA 2039] The initial count window appears with a POS Terminal type without payment method of type 'cash'

DescriptionThe initial count window appears with a POS Terminal type without payment method of type 'cash'
Steps To Reproduce
- Log into backoffice
- Go to POS terminal type and deactive all payment methods
- Close the store
- Log into webPOS in a store closed
- realize tha the Initial Count window appears"
TagsSER-QA
Attached Filesdiff file icon 2039.diff [^] (2,883 bytes) 2016-11-28 17:45 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0034663 closedjorge-garcia If users deactivate a payment in POS Terminal Type window the payment is still loaded in the terminal 

-  Notes
(0091456)
hgbot (developer)
2016-11-14 13:31

Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: b9663b2c9a235fdb6e929af81fed767593391852
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 14 12:18:26 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/b9663b2c9a235fdb6e929af81fed767593391852 [^]

Fixed issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

If the terminal doesn’t have any paymentMethod defined as Cash and as Count
Cash, the count cash window should be avoided. Even in this scenario, the
OpenTill object must be send anyway.

Now, the sessions module works as expected.

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0091564)
hgbot (developer)
2016-11-15 14:50

Repository: tools/automation/pi-mobile
Changeset: 415709e1444b84d027cb38a6ea87c679adb974aa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 14 13:26:01 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/415709e1444b84d027cb38a6ea87c679adb974aa [^]

Verifies issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

Added test I34430_AvoidCountCashWithNoPaymentTypeCash.

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I34430_AvoidCountCashWithNoPaymentTypeCash.java
---
(0091903)
adrianromero (manager)
2016-11-28 17:44

Issue is not completely fixed in all cases. Consider including the attached fix.

* Do not include inactive payment methods when checking available "cash" methods. In the attached fix, this is done using the "active" property. This can also be done in the server side filtering only for active payment methods.

* Include also the check in the BusinessDateModel class, because when changing the business date it also navigates to the count cash window and it is needed to check whether there are cash payment methods or not.
(0091967)
hgbot (developer)
2016-12-01 13:58

Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: aeb7d980048381cfd740621d795f75ff3d7b85c6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 01 12:41:55 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/aeb7d980048381cfd740621d795f75ff3d7b85c6 [^]

Related to issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

Added the same logic we use in countCash window with the businessDate window.

---
M web/org.openbravo.retail.sessions/js/components/BusinessDateModel.js
---
(0092001)
hgbot (developer)
2016-12-02 08:37

Repository: tools/automation/pi-mobile
Changeset: a9e49c0450bd855656c78ac1f0d847f3b07c3392
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 01 13:51:23 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a9e49c0450bd855656c78ac1f0d847f3b07c3392 [^]

Related to issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

Change test to cover all scenarios.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I34430_AvoidCountCashWithNoPaymentTypeCash.java
---
(0092088)
marvintm (manager)
2016-12-05 11:03

There is now a lot of mainly duplicated code in BusinessDateModel.js and loginhook.js. This should be refactored so that the code is centralized.
(0092280)
hgbot (developer)
2016-12-12 12:14

Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 8b5badd66fdaa8e52f1370e3ba4ee9ef587f1bad
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Dec 12 12:08:45 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/8b5badd66fdaa8e52f1370e3ba4ee9ef587f1bad [^]

Related to issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

Eliminate duplicated code from loginhook and businessdatemodel. The new function
is located in countcash-model file and can be called using
OB.OBPOSSession.CountCash.Model.AvoidCountCashAndSendOpenTill().

---
M web/org.openbravo.retail.sessions/js/components/BusinessDateModel.js
M web/org.openbravo.retail.sessions/js/components/loginhook.js
M web/org.openbravo.retail.sessions/js/countcash/countcash-model.js
---

- Issue History
Date Modified Username Field Change
2016-11-08 16:55 xabiermerino New Issue
2016-11-08 16:55 xabiermerino Assigned To => Retail
2016-11-08 16:55 xabiermerino Resolution time => 1479164400
2016-11-08 16:55 xabiermerino Triggers an Emergency Pack => No
2016-11-08 16:55 xabiermerino Tag Attached: SER-QA
2016-11-14 12:16 jorge-garcia Status new => scheduled
2016-11-14 12:16 jorge-garcia Assigned To Retail => jorge-garcia
2016-11-14 13:31 hgbot Checkin
2016-11-14 13:31 hgbot Note Added: 0091456
2016-11-14 13:31 hgbot Status scheduled => resolved
2016-11-14 13:31 hgbot Resolution open => fixed
2016-11-14 13:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/b9663b2c9a235fdb6e929af81fed767593391852 [^]
2016-11-14 13:32 jorge-garcia Status resolved => new
2016-11-14 13:32 jorge-garcia Resolution fixed => open
2016-11-14 13:32 jorge-garcia Status new => scheduled
2016-11-15 14:50 hgbot Checkin
2016-11-15 14:50 hgbot Note Added: 0091564
2016-11-15 14:51 jorge-garcia Status scheduled => resolved
2016-11-15 14:51 jorge-garcia Fixed in Version => RR17Q1
2016-11-15 14:51 jorge-garcia Resolution open => fixed
2016-11-23 19:01 marvintm Review Assigned To => marvintm
2016-11-23 19:01 marvintm Status resolved => closed
2016-11-28 17:44 adrianromero Note Added: 0091903
2016-11-28 17:44 adrianromero Status closed => new
2016-11-28 17:44 adrianromero Resolution fixed => open
2016-11-28 17:44 adrianromero Fixed in Version RR17Q1 =>
2016-11-28 17:45 adrianromero File Added: 2039.diff
2016-11-30 11:24 jorge-garcia Status new => scheduled
2016-12-01 11:38 jorge-garcia Relationship added related to 0034663
2016-12-01 13:58 hgbot Checkin
2016-12-01 13:58 hgbot Note Added: 0091967
2016-12-02 08:37 hgbot Checkin
2016-12-02 08:37 hgbot Note Added: 0092001
2016-12-02 08:39 jorge-garcia Status scheduled => resolved
2016-12-02 08:39 jorge-garcia Fixed in Version => RR17Q1
2016-12-02 08:39 jorge-garcia Resolution open => fixed
2016-12-05 11:03 marvintm Note Added: 0092088
2016-12-08 18:22 marvintm Status resolved => new
2016-12-08 18:22 marvintm Resolution fixed => open
2016-12-08 18:22 marvintm Fixed in Version RR17Q1 =>
2016-12-08 18:22 marvintm Status new => scheduled
2016-12-12 12:14 hgbot Checkin
2016-12-12 12:14 hgbot Note Added: 0092280
2016-12-12 17:39 jorge-garcia Status scheduled => resolved
2016-12-12 17:39 jorge-garcia Resolution open => fixed
2016-12-16 10:00 marvintm Status resolved => closed
2016-12-16 10:00 marvintm Fixed in Version => RR17Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker