Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034430Retail ModulesWeb POSpublic2016-11-08 16:552016-12-16 10:00
Reporterxabiermerino 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034430: [SERQA 2039] The initial count window appears with a POS Terminal type without payment method of type 'cash'
DescriptionThe initial count window appears with a POS Terminal type without payment method of type 'cash'
Steps To Reproduce
- Log into backoffice
- Go to POS terminal type and deactive all payment methods
- Close the store
- Log into webPOS in a store closed
- realize tha the Initial Count window appears"
Proposed Solution
Additional Information
TagsSER-QA
Relationships
related to defect 0034663 closed jorge-garcia If users deactivate a payment in POS Terminal Type window the payment is still loaded in the terminal 
Attached Filesdiff 2039.diff (2,883) 2016-11-28 17:45
https://issues.openbravo.com/file_download.php?file_id=10128&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-08 16:55xabiermerinoNew Issue
2016-11-08 16:55xabiermerinoAssigned To => Retail
2016-11-08 16:55xabiermerinoResolution time => 1479164400
2016-11-08 16:55xabiermerinoTriggers an Emergency Pack => No
2016-11-08 16:55xabiermerinoTag Attached: SER-QA
2016-11-14 12:16jorge-garciaStatusnew => scheduled
2016-11-14 12:16jorge-garciaAssigned ToRetail => jorge-garcia
2016-11-14 13:31hgbotCheckin
2016-11-14 13:31hgbotNote Added: 0091456
2016-11-14 13:31hgbotStatusscheduled => resolved
2016-11-14 13:31hgbotResolutionopen => fixed
2016-11-14 13:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/b9663b2c9a235fdb6e929af81fed767593391852 [^]
2016-11-14 13:32jorge-garciaStatusresolved => new
2016-11-14 13:32jorge-garciaResolutionfixed => open
2016-11-14 13:32jorge-garciaStatusnew => scheduled
2016-11-15 14:50hgbotCheckin
2016-11-15 14:50hgbotNote Added: 0091564
2016-11-15 14:51jorge-garciaStatusscheduled => resolved
2016-11-15 14:51jorge-garciaFixed in Version => RR17Q1
2016-11-15 14:51jorge-garciaResolutionopen => fixed
2016-11-23 19:01marvintmReview Assigned To => marvintm
2016-11-23 19:01marvintmStatusresolved => closed
2016-11-28 17:44adrianromeroNote Added: 0091903
2016-11-28 17:44adrianromeroStatusclosed => new
2016-11-28 17:44adrianromeroResolutionfixed => open
2016-11-28 17:44adrianromeroFixed in VersionRR17Q1 =>
2016-11-28 17:45adrianromeroFile Added: 2039.diff
2016-11-30 11:24jorge-garciaStatusnew => scheduled
2016-12-01 11:38jorge-garciaRelationship addedrelated to 0034663
2016-12-01 13:58hgbotCheckin
2016-12-01 13:58hgbotNote Added: 0091967
2016-12-02 08:37hgbotCheckin
2016-12-02 08:37hgbotNote Added: 0092001
2016-12-02 08:39jorge-garciaStatusscheduled => resolved
2016-12-02 08:39jorge-garciaFixed in Version => RR17Q1
2016-12-02 08:39jorge-garciaResolutionopen => fixed
2016-12-05 11:03marvintmNote Added: 0092088
2016-12-08 18:22marvintmStatusresolved => new
2016-12-08 18:22marvintmResolutionfixed => open
2016-12-08 18:22marvintmFixed in VersionRR17Q1 =>
2016-12-08 18:22marvintmStatusnew => scheduled
2016-12-12 12:14hgbotCheckin
2016-12-12 12:14hgbotNote Added: 0092280
2016-12-12 17:39jorge-garciaStatusscheduled => resolved
2016-12-12 17:39jorge-garciaResolutionopen => fixed
2016-12-16 10:00marvintmStatusresolved => closed
2016-12-16 10:00marvintmFixed in Version => RR17Q1

Notes
(0091456)
hgbot   
2016-11-14 13:31   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: b9663b2c9a235fdb6e929af81fed767593391852
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 14 12:18:26 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/b9663b2c9a235fdb6e929af81fed767593391852 [^]

Fixed issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

If the terminal doesn’t have any paymentMethod defined as Cash and as Count
Cash, the count cash window should be avoided. Even in this scenario, the
OpenTill object must be send anyway.

Now, the sessions module works as expected.

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0091564)
hgbot   
2016-11-15 14:50   
Repository: tools/automation/pi-mobile
Changeset: 415709e1444b84d027cb38a6ea87c679adb974aa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 14 13:26:01 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/415709e1444b84d027cb38a6ea87c679adb974aa [^]

Verifies issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

Added test I34430_AvoidCountCashWithNoPaymentTypeCash.

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I34430_AvoidCountCashWithNoPaymentTypeCash.java
---
(0091903)
adrianromero   
2016-11-28 17:44   
Issue is not completely fixed in all cases. Consider including the attached fix.

* Do not include inactive payment methods when checking available "cash" methods. In the attached fix, this is done using the "active" property. This can also be done in the server side filtering only for active payment methods.

* Include also the check in the BusinessDateModel class, because when changing the business date it also navigates to the count cash window and it is needed to check whether there are cash payment methods or not.
(0091967)
hgbot   
2016-12-01 13:58   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: aeb7d980048381cfd740621d795f75ff3d7b85c6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 01 12:41:55 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/aeb7d980048381cfd740621d795f75ff3d7b85c6 [^]

Related to issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

Added the same logic we use in countCash window with the businessDate window.

---
M web/org.openbravo.retail.sessions/js/components/BusinessDateModel.js
---
(0092001)
hgbot   
2016-12-02 08:37   
Repository: tools/automation/pi-mobile
Changeset: a9e49c0450bd855656c78ac1f0d847f3b07c3392
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 01 13:51:23 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a9e49c0450bd855656c78ac1f0d847f3b07c3392 [^]

Related to issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

Change test to cover all scenarios.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I34430_AvoidCountCashWithNoPaymentTypeCash.java
---
(0092088)
marvintm   
2016-12-05 11:03   
There is now a lot of mainly duplicated code in BusinessDateModel.js and loginhook.js. This should be refactored so that the code is centralized.
(0092280)
hgbot   
2016-12-12 12:14   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 8b5badd66fdaa8e52f1370e3ba4ee9ef587f1bad
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Dec 12 12:08:45 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/8b5badd66fdaa8e52f1370e3ba4ee9ef587f1bad [^]

Related to issue 34430: [SERQA 2039] The initial count window appears with a POS
Terminal type without payment method of type 'cash'

Eliminate duplicated code from loginhook and businessdatemodel. The new function
is located in countcash-model file and can be called using
OB.OBPOSSession.CountCash.Model.AvoidCountCashAndSendOpenTill().

---
M web/org.openbravo.retail.sessions/js/components/BusinessDateModel.js
M web/org.openbravo.retail.sessions/js/components/loginhook.js
M web/org.openbravo.retail.sessions/js/countcash/countcash-model.js
---