Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034416
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2016-11-08 08:242016-12-09 10:32
Reporterprakashmurugesan88View Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision2b1c0a42cb5f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034416: [SER-QA 2020] Quantity issue while "Remove" a product added to line and while "Undo" a deleted product

DescriptionThis issue occurs when preference "Web POS Save Removed Tickets" is set to 'Y'.

When a product added to a receipt is removed it displays message with zero quantity(Deleted lines: 0 x <Product Name>).
But however the quantity of removed product is not zero.

Similarly when we undo the deleted product it adds product of quantity zero to the line instead of exact quantity.
Steps To ReproduceBackend:
Preference "Web POS Save Removed Tickets" is must be set to 'Y'.

Front office:
  Remove:
    Add a product to the receipt
    Click on product.
    Click on remove button

    The message says that we have removed quantity =0.
    'Deleted lines: 0 x <Product Name>'
    But the quantity is not zero.

  Undo:
    Click on undo button.

    The product is inserted again on the ticket, but quantity =0.
Proposed SolutionPlease check the patch in the attachment
TagsSER-QA
Attached Filespatch file icon QuantityIssue.patch [^] (2,857 bytes) 2016-11-08 08:47 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0091263)
hgbot (developer)
2016-11-09 11:42

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7a346920190eb25b8e22a136451c133ff217e2a2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 09 16:11:41 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2 [^]

Fixes issue 34416 : Update Delete UNDO Text if the Save Removed Ticket preference is set

---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091265)
hgbot (developer)
2016-11-09 11:46

Repository: tools/automation/pi-mobile
Changeset: 28f7f61cdce9be219dc8295ebe01e464b49777ab
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 09 15:05:25 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/28f7f61cdce9be219dc8295ebe01e464b49777ab [^]

Verifies issue 34416 : Added automated test 'I34416_VerifyUndoOnDeleteLineWithPref'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34416_VerifyUndoOnDeleteLineWithPref.java
---
(0091713)
migueldejuana (developer)
2016-11-21 17:07
edited on: 2016-11-21 17:10

1.- Why is is needed model.has('obposQtyDeleted') validation in:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2#l1.10 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2#l2.7 [^]

If the preference is set, it always will have this attribute( https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/7a346920190e/web/org.openbravo.retail.posterminal/js/model/order.js#l1376 [^] )

2.- line.get('obposQtyDeleted') > 0 is really needed? What happens if we delete a line with negative qty and we want to undo it?
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2#l1.10 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2#l2.7 [^]

3.- The commit MUST have a description of the change.

(0091757)
hgbot (developer)
2016-11-23 09:44

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e00544cc1618198b3cffec403574d0072ae147fd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 23 14:13:18 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e00544cc1618198b3cffec403574d0072ae147fd [^]

Fixes issue 34416 : Update Delete UNDO Text if the Save Removed Ticket preference is set

* If "Save Removed Ticket" preference is enabled, Undo Text should be updated with deletedQty instead of line quantity

---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091902)
migueldejuana (developer)
2016-11-28 16:56

Backend:
Preference "Web POS Save Removed Tickets" is must be set to 'Y'.

Front office:
  Remove:
    Add a Bed to the receipt
    Click on Tools icon and add Delivery Service
    Click on products to select both.
    Click on remove button

    The message says that we have removed 0 Delivery Services quantity =0.
    'Deleted lines: 1 x Bed, 0 x Delivery Service'
    But the quantity is not zero. I we do the undo, it works well.

    Ensure that it also works fine with complementary products(a complementary product can have also a complementary product, test also this nested case)
(0091917)
hgbot (developer)
2016-11-30 09:53

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2b1c0a42cb5fc808bc5fa56e7f3b212380e75ed6
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 30 14:23:01 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2b1c0a42cb5fc808bc5fa56e7f3b212380e75ed6 [^]

Fixes issue 34416 : Modified receipt calculation while deleting lines

* While deleting last line in receipt, calculateReceipt() function is removed to avoid multiple execution of this function

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091918)
hgbot (developer)
2016-11-30 09:54

Repository: tools/automation/pi-mobile
Changeset: 966bfbc47bb2c8bc45b4d5965767f470fe892038
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 30 14:20:45 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/966bfbc47bb2c8bc45b4d5965767f470fe892038 [^]

Verifies issue 34416 : Added automated test 'I34416_VerifyUndoOnDeleteLineWithPref'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34416_VerifyUndoOnDeleteLineWithPref.java
---

- Issue History
Date Modified Username Field Change
2016-11-08 08:24 prakashmurugesan88 New Issue
2016-11-08 08:24 prakashmurugesan88 Assigned To => prakashmurugesan88
2016-11-08 08:24 prakashmurugesan88 Triggers an Emergency Pack => No
2016-11-08 08:32 prakashmurugesan88 Summary Quantity issue while Remove / Undo a product added to line => Quantity issue while "Remove" a product added to line and while "Undo" a deleted product
2016-11-08 08:47 prakashmurugesan88 File Added: QuantityIssue.patch
2016-11-08 08:47 prakashmurugesan88 Proposed Solution updated
2016-11-08 11:41 adrianromero Resolution time => 1479769200
2016-11-08 11:41 adrianromero Assigned To prakashmurugesan88 => Retail
2016-11-08 11:41 adrianromero Priority normal => urgent
2016-11-08 11:41 adrianromero Summary Quantity issue while "Remove" a product added to line and while "Undo" a deleted product => [SER-QA 2020] Quantity issue while "Remove" a product added to line and while "Undo" a deleted product
2016-11-08 11:53 adrianromero Tag Attached: SER-QA
2016-11-08 13:30 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2016-11-08 13:30 ranjith_qualiantech_com Status new => scheduled
2016-11-09 11:42 hgbot Checkin
2016-11-09 11:42 hgbot Note Added: 0091263
2016-11-09 11:42 hgbot Status scheduled => resolved
2016-11-09 11:42 hgbot Resolution open => fixed
2016-11-09 11:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2 [^]
2016-11-09 11:46 hgbot Checkin
2016-11-09 11:46 hgbot Note Added: 0091265
2016-11-21 17:07 migueldejuana Note Added: 0091713
2016-11-21 17:07 migueldejuana Status resolved => new
2016-11-21 17:07 migueldejuana Resolution fixed => open
2016-11-21 17:09 migueldejuana Note Edited: 0091713 View Revisions
2016-11-21 17:10 migueldejuana Note Edited: 0091713 View Revisions
2016-11-22 06:04 ranjith_qualiantech_com Status new => scheduled
2016-11-23 09:44 hgbot Checkin
2016-11-23 09:44 hgbot Note Added: 0091757
2016-11-23 09:44 hgbot Status scheduled => resolved
2016-11-23 09:44 hgbot Resolution open => fixed
2016-11-23 09:44 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e00544cc1618198b3cffec403574d0072ae147fd [^]
2016-11-28 16:56 migueldejuana Note Added: 0091902
2016-11-28 16:56 migueldejuana Status resolved => new
2016-11-28 16:56 migueldejuana Resolution fixed => open
2016-11-30 09:53 hgbot Checkin
2016-11-30 09:53 hgbot Note Added: 0091917
2016-11-30 09:54 hgbot Status new => resolved
2016-11-30 09:54 hgbot Resolution open => fixed
2016-11-30 09:54 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e00544cc1618198b3cffec403574d0072ae147fd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2b1c0a42cb5fc808bc5fa56e7f3b212380e75ed6 [^]
2016-11-30 09:54 hgbot Checkin
2016-11-30 09:54 hgbot Note Added: 0091918
2016-12-09 10:32 marvintm Review Assigned To => marvintm
2016-12-09 10:32 marvintm Status resolved => closed
2016-12-09 10:32 marvintm Fixed in Version => RR17Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker