Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034416Retail ModulesWeb POSpublic2016-11-08 08:242016-12-09 10:32
Reporterprakashmurugesan88 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034416: [SER-QA 2020] Quantity issue while "Remove" a product added to line and while "Undo" a deleted product
DescriptionThis issue occurs when preference "Web POS Save Removed Tickets" is set to 'Y'.

When a product added to a receipt is removed it displays message with zero quantity(Deleted lines: 0 x <Product Name>).
But however the quantity of removed product is not zero.

Similarly when we undo the deleted product it adds product of quantity zero to the line instead of exact quantity.
Steps To ReproduceBackend:
Preference "Web POS Save Removed Tickets" is must be set to 'Y'.

Front office:
  Remove:
    Add a product to the receipt
    Click on product.
    Click on remove button

    The message says that we have removed quantity =0.
    'Deleted lines: 0 x <Product Name>'
    But the quantity is not zero.

  Undo:
    Click on undo button.

    The product is inserted again on the ticket, but quantity =0.
Proposed SolutionPlease check the patch in the attachment
Additional Information
TagsSER-QA
Relationships
Attached Filespatch QuantityIssue.patch (2,857) 2016-11-08 08:47
https://issues.openbravo.com/file_download.php?file_id=10021&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-08 08:24prakashmurugesan88New Issue
2016-11-08 08:24prakashmurugesan88Assigned To => prakashmurugesan88
2016-11-08 08:24prakashmurugesan88OBNetwork customer => No
2016-11-08 08:24prakashmurugesan88Triggers an Emergency Pack => No
2016-11-08 08:32prakashmurugesan88SummaryQuantity issue while Remove / Undo a product added to line => Quantity issue while "Remove" a product added to line and while "Undo" a deleted product
2016-11-08 08:47prakashmurugesan88File Added: QuantityIssue.patch
2016-11-08 08:47prakashmurugesan88Proposed Solution updated
2016-11-08 11:41adrianromeroOBNetwork customerNo => Yes
2016-11-08 11:41adrianromeroResolution time => 1479769200
2016-11-08 11:41adrianromeroAssigned Toprakashmurugesan88 => Retail
2016-11-08 11:41adrianromeroPrioritynormal => urgent
2016-11-08 11:41adrianromeroSummaryQuantity issue while "Remove" a product added to line and while "Undo" a deleted product => [SER-QA 2020] Quantity issue while "Remove" a product added to line and while "Undo" a deleted product
2016-11-08 11:53adrianromeroTag Attached: SER-QA
2016-11-08 13:30ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-11-08 13:30ranjith_qualiantech_comStatusnew => scheduled
2016-11-09 11:42hgbotCheckin
2016-11-09 11:42hgbotNote Added: 0091263
2016-11-09 11:42hgbotStatusscheduled => resolved
2016-11-09 11:42hgbotResolutionopen => fixed
2016-11-09 11:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2 [^]
2016-11-09 11:46hgbotCheckin
2016-11-09 11:46hgbotNote Added: 0091265
2016-11-21 17:07migueldejuanaNote Added: 0091713
2016-11-21 17:07migueldejuanaStatusresolved => new
2016-11-21 17:07migueldejuanaResolutionfixed => open
2016-11-21 17:09migueldejuanaNote Edited: 0091713bug_revision_view_page.php?bugnote_id=0091713#r13860
2016-11-21 17:10migueldejuanaNote Edited: 0091713bug_revision_view_page.php?bugnote_id=0091713#r13861
2016-11-22 06:04ranjith_qualiantech_comStatusnew => scheduled
2016-11-23 09:44hgbotCheckin
2016-11-23 09:44hgbotNote Added: 0091757
2016-11-23 09:44hgbotStatusscheduled => resolved
2016-11-23 09:44hgbotResolutionopen => fixed
2016-11-23 09:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e00544cc1618198b3cffec403574d0072ae147fd [^]
2016-11-28 16:56migueldejuanaNote Added: 0091902
2016-11-28 16:56migueldejuanaStatusresolved => new
2016-11-28 16:56migueldejuanaResolutionfixed => open
2016-11-30 09:53hgbotCheckin
2016-11-30 09:53hgbotNote Added: 0091917
2016-11-30 09:54hgbotStatusnew => resolved
2016-11-30 09:54hgbotResolutionopen => fixed
2016-11-30 09:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e00544cc1618198b3cffec403574d0072ae147fd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2b1c0a42cb5fc808bc5fa56e7f3b212380e75ed6 [^]
2016-11-30 09:54hgbotCheckin
2016-11-30 09:54hgbotNote Added: 0091918
2016-12-09 10:32marvintmReview Assigned To => marvintm
2016-12-09 10:32marvintmStatusresolved => closed
2016-12-09 10:32marvintmFixed in Version => RR17Q1

Notes
(0091263)
hgbot   
2016-11-09 11:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7a346920190eb25b8e22a136451c133ff217e2a2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 09 16:11:41 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2 [^]

Fixes issue 34416 : Update Delete UNDO Text if the Save Removed Ticket preference is set

---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091265)
hgbot   
2016-11-09 11:46   
Repository: tools/automation/pi-mobile
Changeset: 28f7f61cdce9be219dc8295ebe01e464b49777ab
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 09 15:05:25 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/28f7f61cdce9be219dc8295ebe01e464b49777ab [^]

Verifies issue 34416 : Added automated test 'I34416_VerifyUndoOnDeleteLineWithPref'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34416_VerifyUndoOnDeleteLineWithPref.java
---
(0091713)
migueldejuana   
2016-11-21 17:07   
(edited on: 2016-11-21 17:10)
1.- Why is is needed model.has('obposQtyDeleted') validation in:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2#l1.10 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2#l2.7 [^]

If the preference is set, it always will have this attribute( https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/7a346920190e/web/org.openbravo.retail.posterminal/js/model/order.js#l1376 [^] )

2.- line.get('obposQtyDeleted') > 0 is really needed? What happens if we delete a line with negative qty and we want to undo it?
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2#l1.10 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a346920190eb25b8e22a136451c133ff217e2a2#l2.7 [^]

3.- The commit MUST have a description of the change.
(0091757)
hgbot   
2016-11-23 09:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e00544cc1618198b3cffec403574d0072ae147fd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 23 14:13:18 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e00544cc1618198b3cffec403574d0072ae147fd [^]

Fixes issue 34416 : Update Delete UNDO Text if the Save Removed Ticket preference is set

* If "Save Removed Ticket" preference is enabled, Undo Text should be updated with deletedQty instead of line quantity

---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091902)
migueldejuana   
2016-11-28 16:56   
Backend:
Preference "Web POS Save Removed Tickets" is must be set to 'Y'.

Front office:
  Remove:
    Add a Bed to the receipt
    Click on Tools icon and add Delivery Service
    Click on products to select both.
    Click on remove button

    The message says that we have removed 0 Delivery Services quantity =0.
    'Deleted lines: 1 x Bed, 0 x Delivery Service'
    But the quantity is not zero. I we do the undo, it works well.

    Ensure that it also works fine with complementary products(a complementary product can have also a complementary product, test also this nested case)
(0091917)
hgbot   
2016-11-30 09:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2b1c0a42cb5fc808bc5fa56e7f3b212380e75ed6
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 30 14:23:01 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2b1c0a42cb5fc808bc5fa56e7f3b212380e75ed6 [^]

Fixes issue 34416 : Modified receipt calculation while deleting lines

* While deleting last line in receipt, calculateReceipt() function is removed to avoid multiple execution of this function

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091918)
hgbot   
2016-11-30 09:54   
Repository: tools/automation/pi-mobile
Changeset: 966bfbc47bb2c8bc45b4d5965767f470fe892038
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 30 14:20:45 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/966bfbc47bb2c8bc45b4d5965767f470fe892038 [^]

Verifies issue 34416 : Added automated test 'I34416_VerifyUndoOnDeleteLineWithPref'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34416_VerifyUndoOnDeleteLineWithPref.java
---