Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034321
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2016-10-27 14:032016-11-23 18:11
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revisiondf4d729c33f9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034321: We are saving order with id:null inside json

DescriptionWe are saving order with id:null inside json. When a new order changes, we save in local database. Client side dal generates an id for the order but json of the order will not have this id. Next order updates will update the json and will set id inside it.

We must to force to set id before saving the order, we need to do this to be able to set id inside the json before saving locally the new receipt.
Steps To Reproduce- Login in Web POS
- Open menu and tap "Layaway this receipt"
- Open Developers tools --> Applications --> Web SQL --> c_order
- ERROR! You will see an order with id:null in the json.
TagsNo tags attached.
Attached Filesdiff file icon issue34231Posterminal16Q1.2 (1).diff [^] (957 bytes) 2016-10-28 10:37 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0034641 closedmigueldejuana corrupted receipts are stored in c_order local database 

-  Notes
(0090957)
hgbot (developer)
2016-10-27 14:06

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 586c473db02cfb9aa3abdfefebae4d5eb3fa23bd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Oct 27 14:06:30 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/586c473db02cfb9aa3abdfefebae4d5eb3fa23bd [^]

Fixed issue 0034321: We are saving order with id:null inside json

- force to set id before saving the order, we need to do this to be able to set id inside the json before saving locally the new receipt.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0090958)
hgbot (developer)
2016-10-27 14:52

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3880be480206958173eaf9b15a27cc30f7172263
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Oct 27 14:51:52 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3880be480206958173eaf9b15a27cc30f7172263 [^]

Fixed issue 0034321: We are saving order with id:null inside json

- Do no set order id if the value is null. Add extra validation

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0090985)
hgbot (developer)
2016-10-28 10:21

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: df4d729c33f97f1c3646c2941eadb9ba2b92ecdb
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 28 10:21:28 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/df4d729c33f97f1c3646c2941eadb9ba2b92ecdb [^]

Fixed issue 0034321: We are saving order with id:null inside json

Backed out changeset 3880be480206

If id == null we are getting a wrong id, we prefer to give an error and avoid to have duplicate orders

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2016-10-27 14:03 migueldejuana New Issue
2016-10-27 14:03 migueldejuana Assigned To => migueldejuana
2016-10-27 14:03 migueldejuana OBNetwork customer => No
2016-10-27 14:03 migueldejuana Triggers an Emergency Pack => No
2016-10-27 14:06 hgbot Checkin
2016-10-27 14:06 hgbot Note Added: 0090957
2016-10-27 14:06 hgbot Status new => resolved
2016-10-27 14:06 hgbot Resolution open => fixed
2016-10-27 14:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/586c473db02cfb9aa3abdfefebae4d5eb3fa23bd [^]
2016-10-27 14:14 migueldejuana File Added: issue34231Posterminal16Q1.2.diff
2016-10-27 14:44 migueldejuana File Deleted: issue34231Posterminal16Q1.2.diff
2016-10-27 14:44 migueldejuana File Added: issue34231Posterminal16Q1.2.diff
2016-10-27 14:52 hgbot Checkin
2016-10-27 14:52 hgbot Note Added: 0090958
2016-10-27 14:52 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/586c473db02cfb9aa3abdfefebae4d5eb3fa23bd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3880be480206958173eaf9b15a27cc30f7172263 [^]
2016-10-28 10:21 hgbot Checkin
2016-10-28 10:21 hgbot Note Added: 0090985
2016-10-28 10:21 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3880be480206958173eaf9b15a27cc30f7172263 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/df4d729c33f97f1c3646c2941eadb9ba2b92ecdb [^]
2016-10-28 10:37 migueldejuana File Deleted: issue34231Posterminal16Q1.2.diff
2016-10-28 10:37 migueldejuana File Added: issue34231Posterminal16Q1.2 (1).diff
2016-11-22 08:56 migueldejuana Review Assigned To => Orekaria
2016-11-23 18:11 Orekaria Status resolved => closed
2016-11-23 18:11 Orekaria Fixed in Version => RR17Q1
2017-02-03 09:32 malsasua Relationship added related to 0034641

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker