Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034234
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2016-10-18 15:492016-12-16 18:38
ReporterpsanjuanView Statuspublic 
Assigned Toumartirena 
PriorityurgentResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revision2aed37b14eb3
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034234: It is posible to delete a "replacement" sales order lin, regardless it has been already delivered totally or partially.

DescriptionIt is posible to delete a "replacement" sales order lin, regardless it has been already delivered totally or partially.
Steps To Reproduce1. Log in as Openbravo
2. Select F&B International Group Admin role
3. Select F&B España organization
4. Press Set as default
5. Press Apply
6. Go to Sales Order
7. Create a new order for F&B España and "Alimentos y Supermercados" business partner.
8. Go to lines
9. Add one line for any product for 15 units
10. Add a second line for any product for 20 units
11. Book the order. Write down sales order number 1000301.
12. Go to Goods Shipment window and create a new one for F&B España and "Alimentos y Supermercados" business partner.
13. Press Create Lines From. Select the order. Select all lines and enter an storage bin, for instance RN-0-0-0.
15. Complete the shipment
16. Go to the order created. Verify order delivery status = 100% and delivered quantity for all the products is equal to ordered quantity
17. Press Cancel and Replace
18. Press Done
19. Go to Lines section of "temporary" order created (1000301-1) and try to delete each line.

Check it is possible to delete the lines while it should no.


Proposed SolutionAn error message should be shown saying something like:

"The line cannot be deleted because it is replacing a line that is delivered."
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0090742)
hgbot (developer)
2016-10-21 08:36

 Repository: erp/devel/pi
Changeset: 2aed37b14eb384bd1c1c8012718d2df3ecfcd7bb
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Fri Oct 21 08:34:49 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2aed37b14eb384bd1c1c8012718d2df3ecfcd7bb [^]

Fixes Issue 34234: Add Preupdate and Predelete actions for C&R in Order Line tab

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/common/actionhandler/CancelAndReplaceGetCancelledOrderLine.java
M web/js/cancelAndReplace.js
---
(0090775)
psanjuan (manager)
2016-10-21 14:47
edited on: 2016-11-03 10:22

 Test Plan

Test Case 1 - no line delivered, therefore can be delete.

1. Log in as Openbravo
2. Select F&B International Group Admin role
3. Select F&B España organization
4. Press Set as default
5. Press Apply
6. Go to Sales Order
7. Create a new order for F&B España and "Alimentos y Supermercados" business partner.
8. Go to lines
9. Add one line for Cerveza Ale, 15 units
10. Add a second line for Agua sin gas 1L, 20 units
11. Book the order.
12. Press Cancel and Replace
13. In the temporal order try to delete the lines.
Verify it is possible to delete the lines as none of them are delivered.

Test Case 2 - delivered quantity can not be deleted.

1. Log in as Openbravo
2. Select F&B International Group Admin role
3. Select F&B España organization
4. Press Set as default
5. Press Apply
6. Go to Sales Order
7. Create a new order for F&B España and "Alimentos y Supermercados" business partner.
8. Go to lines
9. Add one line for Cerveza Ale, 15 units
10. Add a second line for Agua sin gas 1L, 20 units
11. Book the order.
12. Go to Goods Shipment window and create a new one for F&B España and "Alimentos y Supermercados" business partner.
13. Press Create Lines From. Select the order. Select all lines and enter an storage bin, for instance RN-0-0-0.
15. Complete the shipment
16. Go to the order created
17 Press Cancel and Replace
18. Press Done
19. Go to Lines section of "temporary" order created and try to delete each line

Verify an error is shown saying "The line cannot be deleted because it is replacing a line that is delivered. Line nº 10. Cerveza Ale".

Test Case 3 - partially delivered quantity cannot be delivered.

1. Log in as Openbravo
2. Select F&B International Group Admin role
3. Select F&B España organization
4. Press Set as default
5. Press Apply
6. Go to Sales Order
7. Create a new order for F&B España and "Alimentos y Supermercados" business partner.
8. Go to lines
9. Add one line for Cerveza Ale 15 units
10. Add a second line for Agua sin Gas 1L 20 units
11. Book the order.
12. Go to Goods Shipment window and create a new one for F&B España and "Alimentos y Supermercados" business partner.
13. Press Create Lines From. Select the order. Select only Cerveza Ale related line. Ship 5 units. Enter an storage bin, for instance RN-0-0-0.
15. Complete the shipment
16. Go to the order created.
17. Press Cancel and Replace
18. Try to delete the line order of Agua sin Gas 1L.
Verify it is possible.
19. Try to delete the line order of Cerveza Ale
Verify an error message is shown
20. Change order line of Cerveza Ale product to 2 units
Verify an error message is shown
21. Change order line of Cerveza Ale product to 5 units. Save
Verify it can be saved.

Repeat same test cases as above having enabled either:
* Cancel and Replace - Associate shipment" preference
or
* Cancel and Replace - Create netting goods shipment" preference
(0091053)
hgbot (developer)
2016-11-02 10:27

 Repository: erp/devel/pi
Changeset: ff63adfc11bd3a7445a13d4a4e1f67401642e627
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Nov 02 10:26:46 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ff63adfc11bd3a7445a13d4a4e1f67401642e627 [^]

Related to bug 34234: Fix name after code review in PreDelete Event Handler

---
M web/js/cancelAndReplace.js
---
(0091072)
psanjuan (manager)
2016-11-03 10:38

 Test plan above verified.
Issue can be closed.
(0091163)
hgbot (developer)
2016-11-04 10:27

 Repository: erp/devel/pi
Changeset: 28a36b5b590504b262d24c443cc4effe0c22b29c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Nov 03 19:50:33 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/28a36b5b590504b262d24c443cc4effe0c22b29c [^]

Related to issue 34234: Code review improvements

---
M src/org/openbravo/common/actionhandler/CancelAndReplaceGetCancelledOrderLine.java
M web/js/cancelAndReplace.js
---
(0091165)
aferraz (manager)
2016-11-04 10:28

 Code review OK
(0092539)
hudsonbot (developer)
2016-12-16 18:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092583)
hudsonbot (developer)
2016-12-16 18:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092594)
hudsonbot (developer)
2016-12-16 18:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-10-18 15:49 psanjuan New Issue
2016-10-18 15:49 psanjuan Assigned To => Triage Finance
2016-10-18 15:49 psanjuan Modules => Core
2016-10-18 15:49 psanjuan Triggers an Emergency Pack => No
2016-10-18 15:52 psanjuan Steps to Reproduce Updated View Revisions
2016-10-18 15:52 psanjuan Proposed Solution updated
2016-10-21 08:36 hgbot Checkin
2016-10-21 08:36 hgbot Note Added: 0090742
2016-10-21 08:36 hgbot Status new => resolved
2016-10-21 08:36 hgbot Resolution open => fixed
2016-10-21 08:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2aed37b14eb384bd1c1c8012718d2df3ecfcd7bb [^]
2016-10-21 10:43 psanjuan Assigned To Triage Finance => umartirena
2016-10-21 14:47 psanjuan Note Added: 0090775
2016-10-21 14:50 psanjuan Note Edited: 0090775 View Revisions
2016-10-21 14:59 psanjuan Note Edited: 0090775 View Revisions
2016-11-02 10:27 hgbot Checkin
2016-11-02 10:27 hgbot Note Added: 0091053
2016-11-03 10:11 psanjuan Note Edited: 0090775 View Revisions
2016-11-03 10:22 psanjuan Note Edited: 0090775 View Revisions
2016-11-03 10:38 psanjuan Note Added: 0091072
2016-11-04 10:27 hgbot Checkin
2016-11-04 10:27 hgbot Note Added: 0091163
2016-11-04 10:28 aferraz Review Assigned To => aferraz
2016-11-04 10:28 aferraz Note Added: 0091165
2016-11-04 10:28 aferraz Status resolved => closed
2016-11-04 10:28 aferraz Fixed in Version => 3.0PR17Q1
2016-12-16 18:37 hudsonbot Checkin
2016-12-16 18:37 hudsonbot Note Added: 0092539
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092583
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092594

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker