Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034234Openbravo ERP07. Sales managementpublic2016-10-18 15:492016-12-16 18:38
Reporterpsanjuan 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034234: It is posible to delete a "replacement" sales order lin, regardless it has been already delivered totally or partially.
DescriptionIt is posible to delete a "replacement" sales order lin, regardless it has been already delivered totally or partially.
Steps To Reproduce1. Log in as Openbravo
2. Select F&B International Group Admin role
3. Select F&B España organization
4. Press Set as default
5. Press Apply
6. Go to Sales Order
7. Create a new order for F&B España and "Alimentos y Supermercados" business partner.
8. Go to lines
9. Add one line for any product for 15 units
10. Add a second line for any product for 20 units
11. Book the order. Write down sales order number 1000301.
12. Go to Goods Shipment window and create a new one for F&B España and "Alimentos y Supermercados" business partner.
13. Press Create Lines From. Select the order. Select all lines and enter an storage bin, for instance RN-0-0-0.
15. Complete the shipment
16. Go to the order created. Verify order delivery status = 100% and delivered quantity for all the products is equal to ordered quantity
17. Press Cancel and Replace
18. Press Done
19. Go to Lines section of "temporary" order created (1000301-1) and try to delete each line.

Check it is possible to delete the lines while it should no.


Proposed SolutionAn error message should be shown saying something like:

"The line cannot be deleted because it is replacing a line that is delivered."
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-18 15:49psanjuanNew Issue
2016-10-18 15:49psanjuanAssigned To => Triage Finance
2016-10-18 15:49psanjuanModules => Core
2016-10-18 15:49psanjuanTriggers an Emergency Pack => No
2016-10-18 15:52psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13401#r13401
2016-10-18 15:52psanjuanProposed Solution updated
2016-10-21 08:36hgbotCheckin
2016-10-21 08:36hgbotNote Added: 0090742
2016-10-21 08:36hgbotStatusnew => resolved
2016-10-21 08:36hgbotResolutionopen => fixed
2016-10-21 08:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2aed37b14eb384bd1c1c8012718d2df3ecfcd7bb [^]
2016-10-21 10:43psanjuanAssigned ToTriage Finance => umartirena
2016-10-21 14:47psanjuanNote Added: 0090775
2016-10-21 14:50psanjuanNote Edited: 0090775bug_revision_view_page.php?bugnote_id=0090775#r13448
2016-10-21 14:59psanjuanNote Edited: 0090775bug_revision_view_page.php?bugnote_id=0090775#r13449
2016-11-02 10:27hgbotCheckin
2016-11-02 10:27hgbotNote Added: 0091053
2016-11-03 10:11psanjuanNote Edited: 0090775bug_revision_view_page.php?bugnote_id=0090775#r13539
2016-11-03 10:22psanjuanNote Edited: 0090775bug_revision_view_page.php?bugnote_id=0090775#r13540
2016-11-03 10:38psanjuanNote Added: 0091072
2016-11-04 10:27hgbotCheckin
2016-11-04 10:27hgbotNote Added: 0091163
2016-11-04 10:28aferrazReview Assigned To => aferraz
2016-11-04 10:28aferrazNote Added: 0091165
2016-11-04 10:28aferrazStatusresolved => closed
2016-11-04 10:28aferrazFixed in Version => 3.0PR17Q1
2016-12-16 18:37hudsonbotCheckin
2016-12-16 18:37hudsonbotNote Added: 0092539
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092583
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092594

Notes
(0090742)
hgbot   
2016-10-21 08:36   
Repository: erp/devel/pi
Changeset: 2aed37b14eb384bd1c1c8012718d2df3ecfcd7bb
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Fri Oct 21 08:34:49 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2aed37b14eb384bd1c1c8012718d2df3ecfcd7bb [^]

Fixes Issue 34234: Add Preupdate and Predelete actions for C&R in Order Line tab

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/common/actionhandler/CancelAndReplaceGetCancelledOrderLine.java
M web/js/cancelAndReplace.js
---
(0090775)
psanjuan   
2016-10-21 14:47   
(edited on: 2016-11-03 10:22)
Test Plan

Test Case 1 - no line delivered, therefore can be delete.

1. Log in as Openbravo
2. Select F&B International Group Admin role
3. Select F&B España organization
4. Press Set as default
5. Press Apply
6. Go to Sales Order
7. Create a new order for F&B España and "Alimentos y Supermercados" business partner.
8. Go to lines
9. Add one line for Cerveza Ale, 15 units
10. Add a second line for Agua sin gas 1L, 20 units
11. Book the order.
12. Press Cancel and Replace
13. In the temporal order try to delete the lines.
Verify it is possible to delete the lines as none of them are delivered.

Test Case 2 - delivered quantity can not be deleted.

1. Log in as Openbravo
2. Select F&B International Group Admin role
3. Select F&B España organization
4. Press Set as default
5. Press Apply
6. Go to Sales Order
7. Create a new order for F&B España and "Alimentos y Supermercados" business partner.
8. Go to lines
9. Add one line for Cerveza Ale, 15 units
10. Add a second line for Agua sin gas 1L, 20 units
11. Book the order.
12. Go to Goods Shipment window and create a new one for F&B España and "Alimentos y Supermercados" business partner.
13. Press Create Lines From. Select the order. Select all lines and enter an storage bin, for instance RN-0-0-0.
15. Complete the shipment
16. Go to the order created
17 Press Cancel and Replace
18. Press Done
19. Go to Lines section of "temporary" order created and try to delete each line

Verify an error is shown saying "The line cannot be deleted because it is replacing a line that is delivered. Line nº 10. Cerveza Ale".

Test Case 3 - partially delivered quantity cannot be delivered.

1. Log in as Openbravo
2. Select F&B International Group Admin role
3. Select F&B España organization
4. Press Set as default
5. Press Apply
6. Go to Sales Order
7. Create a new order for F&B España and "Alimentos y Supermercados" business partner.
8. Go to lines
9. Add one line for Cerveza Ale 15 units
10. Add a second line for Agua sin Gas 1L 20 units
11. Book the order.
12. Go to Goods Shipment window and create a new one for F&B España and "Alimentos y Supermercados" business partner.
13. Press Create Lines From. Select the order. Select only Cerveza Ale related line. Ship 5 units. Enter an storage bin, for instance RN-0-0-0.
15. Complete the shipment
16. Go to the order created.
17. Press Cancel and Replace
18. Try to delete the line order of Agua sin Gas 1L.
Verify it is possible.
19. Try to delete the line order of Cerveza Ale
Verify an error message is shown
20. Change order line of Cerveza Ale product to 2 units
Verify an error message is shown
21. Change order line of Cerveza Ale product to 5 units. Save
Verify it can be saved.

Repeat same test cases as above having enabled either:
* Cancel and Replace - Associate shipment" preference
or
* Cancel and Replace - Create netting goods shipment" preference
(0091053)
hgbot   
2016-11-02 10:27   
Repository: erp/devel/pi
Changeset: ff63adfc11bd3a7445a13d4a4e1f67401642e627
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Nov 02 10:26:46 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ff63adfc11bd3a7445a13d4a4e1f67401642e627 [^]

Related to bug 34234: Fix name after code review in PreDelete Event Handler

---
M web/js/cancelAndReplace.js
---
(0091072)
psanjuan   
2016-11-03 10:38   
Test plan above verified.
Issue can be closed.
(0091163)
hgbot   
2016-11-04 10:27   
Repository: erp/devel/pi
Changeset: 28a36b5b590504b262d24c443cc4effe0c22b29c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Nov 03 19:50:33 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/28a36b5b590504b262d24c443cc4effe0c22b29c [^]

Related to issue 34234: Code review improvements

---
M src/org/openbravo/common/actionhandler/CancelAndReplaceGetCancelledOrderLine.java
M web/js/cancelAndReplace.js
---
(0091165)
aferraz   
2016-11-04 10:28   
Code review OK
(0092539)
hudsonbot   
2016-12-16 18:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092583)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092594)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test