Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034214
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2016-10-17 09:112017-09-09 11:07
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revisiondab052447577
ProjectionnoneETAnoneTarget Version3.0PR17Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034214: remove 2.50 support

DescriptionCurrently, it is still supported to compile windows using 2.50 WAD. This was implemented when starting with Openbravo 3 and it was intended as temporary solution to keep backwards compatibility while old windows were being migrated.

All the new developments are not guaranteed to continue working in 2.50, so being able to compile does not mean the windows are actually usable.

More details: http://wiki.openbravo.com/wiki/Projects:Remove_WAD_2.50_Generated_Code [^]
Steps To Reproduce-
Proposed SolutionCompletely remove 2.50 compilation support.

WiP repo: https://code.openbravo.com/erp/devel/pi-wad-cleanup [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0036818 closedshuehner Big code-cleanup in src-wad related to "2.50 code removal" done earlier in 17Q2 
depends on defect 0035155 closedalostale API change: removed sort tabs 

-  Notes
(0092095)
shuehner (administrator)
2016-12-05 16:34

 2 details to think about:
a.) How to warn/notify users if they still have modules requiring this technically installed? log4j.warn or log4j.error?
b.) the 'compileallwindowsin2.50mode wad switch or still required as we use it to compile all windows in 2.50 mode which is needed for the button implementation. However the behavior could be changed to only cover the code needed for the buttons and not just all.

c.) to think about: Delete 90% of the generated wad classes which are not needed for the button code. Could also help by reducing list of cases where we run into issues into the generated code sometimes (less code -> less risk)
(0094032)
hgbot (developer)
2017-02-03 10:40

 Repository: erp/devel/api-checks
Changeset: 3a1cac60b73b791e0d300badb98aa286b184672d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 03 10:34:52 2017 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/3a1cac60b73b791e0d300badb98aa286b184672d [^]

related to issue 34214: false API change positive

  VariablesSecureApp.commandIn(java.lang.String) now accepts a list of Strings
  so old API is still valid.

---
M java/reference/java.japi.gz
---
(0094034)
hgbot (developer)
2017-02-03 10:53

 Repository: erp/devel/pi
Changeset: dab052447577543438f53359b00598b3efda7786
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 03 10:20:01 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dab052447577543438f53359b00598b3efda7786 [^]

fixed issue 34214: remove 2.50 code generation

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowsInClassicModeTask.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-wad/src/org/openbravo/wad/EditionFields_data.xsql
M src-wad/src/org/openbravo/wad/Fields_data.xsql
M src-wad/src/org/openbravo/wad/TableRelation_data.xsql
M src-wad/src/org/openbravo/wad/Tabs_data.xsql
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/WadActionButton.java
M src-wad/src/org/openbravo/wad/WadUtility.java
M src-wad/src/org/openbravo/wad/Wad_data.xsql
M src-wad/src/org/openbravo/wad/datasource.xml
M src-wad/src/org/openbravo/wad/datasource.xsqlxml
M src-wad/src/org/openbravo/wad/javasource.javaxml
M src-wad/src/org/openbravo/wad/javasource.xml
M src/org/openbravo/base/secureApp/VariablesSecureApp.java
R src-wad/src/org/openbravo/wad/ComboReloads.javaxml
R src-wad/src/org/openbravo/wad/ComboReloads.xml
R src-wad/src/org/openbravo/wad/ConfigurationSortTab_Relation.xml
R src-wad/src/org/openbravo/wad/ConfigurationSortTab_Relation.xmlxml
R src-wad/src/org/openbravo/wad/Configuration_Edition.xml
R src-wad/src/org/openbravo/wad/Configuration_Edition.xmlxml
R src-wad/src/org/openbravo/wad/Configuration_Relation.xml
R src-wad/src/org/openbravo/wad/Configuration_Relation.xmlxml
R src-wad/src/org/openbravo/wad/TableLink_data.xsql
R src-wad/src/org/openbravo/wad/TemplateSortTab_Relation.html
R src-wad/src/org/openbravo/wad/TemplateSortTab_Relation.xml
R src-wad/src/org/openbravo/wad/Template_Edition.html
R src-wad/src/org/openbravo/wad/Template_Edition.xml
R src-wad/src/org/openbravo/wad/Template_Relation.html
R src-wad/src/org/openbravo/wad/Template_Relation.xml
R src-wad/src/org/openbravo/wad/controls/WADGrid.java
R src-wad/src/org/openbravo/wad/datasourceSortTab.xml
R src-wad/src/org/openbravo/wad/datasourceSortTab.xsqlxml
R src-wad/src/org/openbravo/wad/javasourceSortTab.javaxml
R src-wad/src/org/openbravo/wad/javasourceSortTab.xml
---
(0094036)
hgbot (developer)
2017-02-03 11:59

 Repository: erp/devel/api-checks
Changeset: d86ef921265d10b4eae219aa1cd268559c4c929a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 03 11:59:02 2017 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/d86ef921265d10b4eae219aa1cd268559c4c929a [^]

related to issue 34214: false API change positive

  fixed java.japi it was compiled with JDK8, it should be with 7

---
M java/reference/java.japi.gz
---
(0094214)
caristu (developer)
2017-02-10 10:26

 Code reviewed and tested as part of the project[1]

[1] http://wiki.openbravo.com/wiki/Projects:Remove_WAD_2.50_Generated_Code [^]
(0095155)
hudsonbot (developer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095997)
hgbot (developer)
2017-04-12 09:16

 Repository: erp/devel/pi
Changeset: fd990d9ed28b27a70da8ba4d0e9870c40143dcc8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 28 13:36:13 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fd990d9ed28b27a70da8ba4d0e9870c40143dcc8 [^]

[login-perf] related with issue 34214: removed support for 2.50 style windows

  Also it removes request to WindowDefinitionComponent

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/MenuManager.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
R modules/org.openbravo.client.application/src/org/openbravo/client/application/window/WindowDefinitionComponent.java
---
(0096885)
hudsonbot (developer)
2017-05-29 17:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-10-17 09:11 alostale New Issue
2016-10-17 09:11 alostale Assigned To => platform
2016-10-17 09:11 alostale Modules => Core
2016-10-17 09:11 alostale Triggers an Emergency Pack => No
2016-10-17 09:11 alostale Status new => acknowledged
2016-12-05 16:34 shuehner Note Added: 0092095
2016-12-05 16:34 shuehner Issue Monitored: shuehner
2016-12-13 15:52 alostale Target Version 3.0PR17Q1 => 3.0PR17Q2
2016-12-14 12:23 alostale Proposed Solution updated
2017-02-03 09:54 alostale Description Updated View Revisions
2017-02-03 10:37 alostale Relationship added depends on 0035155
2017-02-03 10:40 hgbot Checkin
2017-02-03 10:40 hgbot Note Added: 0094032
2017-02-03 10:44 alostale Assigned To platform => alostale
2017-02-03 10:53 hgbot Checkin
2017-02-03 10:53 hgbot Note Added: 0094034
2017-02-03 10:53 hgbot Status acknowledged => resolved
2017-02-03 10:53 hgbot Resolution open => fixed
2017-02-03 10:53 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dab052447577543438f53359b00598b3efda7786 [^]
2017-02-03 11:59 hgbot Checkin
2017-02-03 11:59 hgbot Note Added: 0094036
2017-02-10 07:22 alostale Review Assigned To => caristu
2017-02-10 10:26 caristu Note Added: 0094214
2017-02-10 10:26 caristu Status resolved => closed
2017-02-10 10:26 caristu Fixed in Version => 3.0PR17Q2
2017-03-02 16:14 caristu Relationship added related to 0035411
2017-03-02 17:37 caristu Relationship deleted related to 0035411
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095155
2017-04-12 09:16 hgbot Checkin
2017-04-12 09:16 hgbot Note Added: 0095997
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096885
2017-09-09 11:07 shuehner Relationship added related to 0036818

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker