Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036818 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2017-09-09 11:07 | 2017-09-12 11:01 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 788d0f44f3ff | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | alostale | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036818: Big code-cleanup in src-wad related to "2.50 code removal" done earlier in 17Q2 | |||||||
| Description | Issue 34214 done for 17Q2 release removed support for compiling 2.50 style windows and lots of support code inside the WAD code-generator. However a lot more code in src-wad is effectively dead and unused since that earlier change but not yet removed. Also the various subclasses implementing WADControl (implementation for the various possible GUI elements) still carry quite some code which is also no longer useful (only related to 2.50). That is also cleanup up in this issue | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Cleanup src-wad code generator to remove all the unused code. Cleanup all implementation of WADControl + sub-classes to also remove lots of no longer required generation code | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0098923) hgbot (developer) 2017-09-09 16:14 |
Repository: erp/devel/pi Changeset: 788d0f44f3ffc96da2516c11a69966361aec7083 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Sat Sep 09 11:09:06 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/788d0f44f3ffc96da2516c11a69966361aec7083 [^] Fixed 36818. Merge back project doing a lot more src-wad unused code removal. This merges back the pi-wad-cleanup2 branch doing follow up cleanup for 17q2 change which removed support to compile old style 2.50 windows. --- M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.xml M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorData.xsql M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorPrimitive.java M src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.xml M src-wad/src/org/openbravo/wad/ActionButton_Responser.xml M src-wad/src/org/openbravo/wad/ComboReloadsProcess.xml M src-wad/src/org/openbravo/wad/ComboReloadsProcessHelper.xml M src-wad/src/org/openbravo/wad/Fields_data.xsql M src-wad/src/org/openbravo/wad/Tabs_data.xsql M src-wad/src/org/openbravo/wad/Template_ActionButton.xml M src-wad/src/org/openbravo/wad/Wad.java M src-wad/src/org/openbravo/wad/WadActionButton.java M src-wad/src/org/openbravo/wad/WadUtility.java M src-wad/src/org/openbravo/wad/controls/WADButton.java M src-wad/src/org/openbravo/wad/controls/WADControl.java M src-wad/src/org/openbravo/wad/controls/WADDate.java M src-wad/src/org/openbravo/wad/controls/WADDateTime.java M src-wad/src/org/openbravo/wad/controls/WADDateXML.xml M src-wad/src/org/openbravo/wad/controls/WADID.java M src-wad/src/org/openbravo/wad/controls/WADImage.java M src-wad/src/org/openbravo/wad/controls/WADImageBLOB.java M src-wad/src/org/openbravo/wad/controls/WADInteger.java M src-wad/src/org/openbravo/wad/controls/WADLink.java M src-wad/src/org/openbravo/wad/controls/WADList.java M src-wad/src/org/openbravo/wad/controls/WADMemo.java M src-wad/src/org/openbravo/wad/controls/WADNumber.java M src-wad/src/org/openbravo/wad/controls/WADSearch.java M src-wad/src/org/openbravo/wad/controls/WADSearch_data.xsql M src-wad/src/org/openbravo/wad/controls/WADString.java M src-wad/src/org/openbravo/wad/controls/WADTable.java M src-wad/src/org/openbravo/wad/controls/WADTableDir.java M src-wad/src/org/openbravo/wad/controls/WADText.java M src-wad/src/org/openbravo/wad/controls/WADTime.java M src-wad/src/org/openbravo/wad/controls/WADYesNo.java M src-wad/src/org/openbravo/wad/javasource.xml M src-wad/src/org/openbravo/wad/webConf.xml M src-wad/src/org/openbravo/wad/webParams.xml M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup_data.xsql R src-wad/src/org/openbravo/wad/EditionFields_data.xsql R src-wad/src/org/openbravo/wad/TableRelation_data.xsql R src-wad/src/org/openbravo/wad/controls/WADTable_data.xsql --- |
|
(0098976) alostale (viewer) 2017-09-12 11:01 |
reviewed tested there is no change in WAD generated code |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-09-09 11:07 | shuehner | New Issue | |
| 2017-09-09 11:07 | shuehner | Assigned To | => shuehner |
| 2017-09-09 11:07 | shuehner | OBNetwork customer | => No |
| 2017-09-09 11:07 | shuehner | Modules | => Core |
| 2017-09-09 11:07 | shuehner | Triggers an Emergency Pack | => No |
| 2017-09-09 11:07 | shuehner | Relationship added | related to 0034214 |
| 2017-09-09 11:37 | shuehner | Relationship added | related to 0036819 |
| 2017-09-09 11:38 | shuehner | Review Assigned To | => alostale |
| 2017-09-09 16:14 | hgbot | Checkin | |
| 2017-09-09 16:14 | hgbot | Note Added: 0098923 | |
| 2017-09-09 16:14 | hgbot | Status | new => resolved |
| 2017-09-09 16:14 | hgbot | Resolution | open => fixed |
| 2017-09-09 16:14 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/788d0f44f3ffc96da2516c11a69966361aec7083 [^] |
| 2017-09-12 11:01 | alostale | Note Added: 0098976 | |
| 2017-09-12 11:01 | alostale | Status | resolved => closed |
| 2017-09-12 11:01 | alostale | Fixed in Version | => 3.0PR17Q4 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |