Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034214Openbravo ERPA. Platformpublic2016-10-17 09:112017-09-09 11:07
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q2Fixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034214: remove 2.50 support
DescriptionCurrently, it is still supported to compile windows using 2.50 WAD. This was implemented when starting with Openbravo 3 and it was intended as temporary solution to keep backwards compatibility while old windows were being migrated.

All the new developments are not guaranteed to continue working in 2.50, so being able to compile does not mean the windows are actually usable.

More details: http://wiki.openbravo.com/wiki/Projects:Remove_WAD_2.50_Generated_Code [^]
Steps To Reproduce-
Proposed SolutionCompletely remove 2.50 compilation support.

WiP repo: https://code.openbravo.com/erp/devel/pi-wad-cleanup [^]
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036818 closed shuehner Big code-cleanup in src-wad related to "2.50 code removal" done earlier in 17Q2 
depends on defect 0035155 closed alostale API change: removed sort tabs 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-17 09:11alostaleNew Issue
2016-10-17 09:11alostaleAssigned To => platform
2016-10-17 09:11alostaleOBNetwork customer => No
2016-10-17 09:11alostaleModules => Core
2016-10-17 09:11alostaleTriggers an Emergency Pack => No
2016-10-17 09:11alostaleStatusnew => acknowledged
2016-12-05 16:34shuehnerNote Added: 0092095
2016-12-05 16:34shuehnerIssue Monitored: shuehner
2016-12-13 15:52alostaleTarget Version3.0PR17Q1 => 3.0PR17Q2
2016-12-14 12:23alostaleProposed Solution updated
2017-02-03 09:54alostaleDescription Updatedbug_revision_view_page.php?rev_id=14454#r14454
2017-02-03 10:37alostaleRelationship addeddepends on 0035155
2017-02-03 10:40hgbotCheckin
2017-02-03 10:40hgbotNote Added: 0094032
2017-02-03 10:44alostaleAssigned Toplatform => alostale
2017-02-03 10:53hgbotCheckin
2017-02-03 10:53hgbotNote Added: 0094034
2017-02-03 10:53hgbotStatusacknowledged => resolved
2017-02-03 10:53hgbotResolutionopen => fixed
2017-02-03 10:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dab052447577543438f53359b00598b3efda7786 [^]
2017-02-03 11:59hgbotCheckin
2017-02-03 11:59hgbotNote Added: 0094036
2017-02-10 07:22alostaleReview Assigned To => caristu
2017-02-10 10:26caristuNote Added: 0094214
2017-02-10 10:26caristuStatusresolved => closed
2017-02-10 10:26caristuFixed in Version => 3.0PR17Q2
2017-03-02 16:14caristuRelationship addedrelated to 0035411
2017-03-02 17:37caristuRelationship deletedrelated to 0035411
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095155
2017-04-12 09:16hgbotCheckin
2017-04-12 09:16hgbotNote Added: 0095997
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096885
2017-09-09 11:07shuehnerRelationship addedrelated to 0036818

Notes
(0092095)
shuehner   
2016-12-05 16:34   
2 details to think about:
a.) How to warn/notify users if they still have modules requiring this technically installed? log4j.warn or log4j.error?
b.) the 'compileallwindowsin2.50mode wad switch or still required as we use it to compile all windows in 2.50 mode which is needed for the button implementation. However the behavior could be changed to only cover the code needed for the buttons and not just all.

c.) to think about: Delete 90% of the generated wad classes which are not needed for the button code. Could also help by reducing list of cases where we run into issues into the generated code sometimes (less code -> less risk)
(0094032)
hgbot   
2017-02-03 10:40   
Repository: erp/devel/api-checks
Changeset: 3a1cac60b73b791e0d300badb98aa286b184672d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 03 10:34:52 2017 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/3a1cac60b73b791e0d300badb98aa286b184672d [^]

related to issue 34214: false API change positive

  VariablesSecureApp.commandIn(java.lang.String) now accepts a list of Strings
  so old API is still valid.

---
M java/reference/java.japi.gz
---
(0094034)
hgbot   
2017-02-03 10:53   
Repository: erp/devel/pi
Changeset: dab052447577543438f53359b00598b3efda7786
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 03 10:20:01 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dab052447577543438f53359b00598b3efda7786 [^]

fixed issue 34214: remove 2.50 code generation

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowsInClassicModeTask.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-wad/src/org/openbravo/wad/EditionFields_data.xsql
M src-wad/src/org/openbravo/wad/Fields_data.xsql
M src-wad/src/org/openbravo/wad/TableRelation_data.xsql
M src-wad/src/org/openbravo/wad/Tabs_data.xsql
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/WadActionButton.java
M src-wad/src/org/openbravo/wad/WadUtility.java
M src-wad/src/org/openbravo/wad/Wad_data.xsql
M src-wad/src/org/openbravo/wad/datasource.xml
M src-wad/src/org/openbravo/wad/datasource.xsqlxml
M src-wad/src/org/openbravo/wad/javasource.javaxml
M src-wad/src/org/openbravo/wad/javasource.xml
M src/org/openbravo/base/secureApp/VariablesSecureApp.java
R src-wad/src/org/openbravo/wad/ComboReloads.javaxml
R src-wad/src/org/openbravo/wad/ComboReloads.xml
R src-wad/src/org/openbravo/wad/ConfigurationSortTab_Relation.xml
R src-wad/src/org/openbravo/wad/ConfigurationSortTab_Relation.xmlxml
R src-wad/src/org/openbravo/wad/Configuration_Edition.xml
R src-wad/src/org/openbravo/wad/Configuration_Edition.xmlxml
R src-wad/src/org/openbravo/wad/Configuration_Relation.xml
R src-wad/src/org/openbravo/wad/Configuration_Relation.xmlxml
R src-wad/src/org/openbravo/wad/TableLink_data.xsql
R src-wad/src/org/openbravo/wad/TemplateSortTab_Relation.html
R src-wad/src/org/openbravo/wad/TemplateSortTab_Relation.xml
R src-wad/src/org/openbravo/wad/Template_Edition.html
R src-wad/src/org/openbravo/wad/Template_Edition.xml
R src-wad/src/org/openbravo/wad/Template_Relation.html
R src-wad/src/org/openbravo/wad/Template_Relation.xml
R src-wad/src/org/openbravo/wad/controls/WADGrid.java
R src-wad/src/org/openbravo/wad/datasourceSortTab.xml
R src-wad/src/org/openbravo/wad/datasourceSortTab.xsqlxml
R src-wad/src/org/openbravo/wad/javasourceSortTab.javaxml
R src-wad/src/org/openbravo/wad/javasourceSortTab.xml
---
(0094036)
hgbot   
2017-02-03 11:59   
Repository: erp/devel/api-checks
Changeset: d86ef921265d10b4eae219aa1cd268559c4c929a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 03 11:59:02 2017 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/d86ef921265d10b4eae219aa1cd268559c4c929a [^]

related to issue 34214: false API change positive

  fixed java.japi it was compiled with JDK8, it should be with 7

---
M java/reference/java.japi.gz
---
(0094214)
caristu   
2017-02-10 10:26   
Code reviewed and tested as part of the project[1]

[1] http://wiki.openbravo.com/wiki/Projects:Remove_WAD_2.50_Generated_Code [^]
(0095155)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095997)
hgbot   
2017-04-12 09:16   
Repository: erp/devel/pi
Changeset: fd990d9ed28b27a70da8ba4d0e9870c40143dcc8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 28 13:36:13 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fd990d9ed28b27a70da8ba4d0e9870c40143dcc8 [^]

[login-perf] related with issue 34214: removed support for 2.50 style windows

  Also it removes request to WindowDefinitionComponent

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/MenuManager.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
R modules/org.openbravo.client.application/src/org/openbravo/client/application/window/WindowDefinitionComponent.java
---
(0096885)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test