Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034207
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2016-10-14 12:332016-12-16 18:38
ReporterlorenzofidalgoView Statuspublic 
Assigned Toasiermartirena 
PriorityimmediateResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revision6ae94a6a873d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browserGoogle Chrome, Mozilla Firefox
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2016-10-05
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/89f61788c100 [^]
Triggers an Emergency PackNo
Summary

0034207: Document no. sequence is no longer respected when Payment with "Amount = 0.00" is involved

DescriptionWhen a record is generated, it automatically sets the following number of the last record created. Now, when a Payment is created with "Amount = 0.00" the string "*Z*" is concatenated. This induces the Document no. does not set the following number and it is duplicated instead.
Steps To Reproduce1-Go to "Payment In" window.
2-Click "Create a new record in a form" button and memorize the "Document No.".
3-Changing no values (it is important Amount = 0.00, as it is by default), click again in "Create a new record in a form" and change the number that appears in "Document No." field by the number of the just saved record. (It is required, usually, only decrement a unit). Save the record.
4-Go to grid view and realise there are two records with the same document number (finished with *Z*). Sequential document numbers have not been created.
TagsNo tags attached.
Attached Filespng file icon docno.png [^] (81,183 bytes) 2016-10-14 12:33

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00342293.0PR16Q4 closedasiermartirena Document no. sequence is no longer respected when Payment with "Amount = 0.00" is involved 
caused by defect 00340383.0PR16Q4 closedumartirena Payments created with amount 0.00 need to be numbered as *R* (same as netting payment from cancel and replace) 

-  Notes
(0090664)
hgbot (developer)
2016-10-18 11:46

 Repository: erp/devel/pi
Changeset: 6ae94a6a873d6f64801ec5a08a323fe3d9c583f6
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Tue Oct 18 11:45:46 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6ae94a6a873d6f64801ec5a08a323fe3d9c583f6 [^]

Fixed issue 34207: The sequence to create payments docNo was not correctly updated

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_PaymentEventListener.java
---
(0090768)
hgbot (developer)
2016-10-21 13:34

 Repository: erp/devel/pi
Changeset: 380d8ab86ea44c1a12adaf65820ec53548836f83
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 21 12:56:10 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/380d8ab86ea44c1a12adaf65820ec53548836f83 [^]

Related to issue 34207: Code review improvements

Throw error only if we are not reactivating payment in APRM_FIN_PMT_CHECK_TRG trigger.
Remove onSave event in FIN_PaymentEventListener.
Zero payment sufix will only be added in case we are processing the payment and it will only be removed in case we are reactivating the payment.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_PMT_CHECK_TRG.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_PaymentEventListener.java
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0090769)
aferraz (viewer)
2016-10-21 13:40

 Code review + Testing OK
(0092530)
hudsonbot (viewer)
2016-12-16 18:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092542)
hudsonbot (viewer)
2016-12-16 18:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-10-14 12:33 lorenzofidalgo New Issue
2016-10-14 12:33 lorenzofidalgo Assigned To => Triage Finance
2016-10-14 12:33 lorenzofidalgo File Added: docno.png
2016-10-14 12:33 lorenzofidalgo OBNetwork customer => No
2016-10-14 12:33 lorenzofidalgo Web browser => Google Chrome, Mozilla Firefox
2016-10-14 12:33 lorenzofidalgo Modules => Core
2016-10-14 12:33 lorenzofidalgo Regression level => Automated tests
2016-10-14 12:33 lorenzofidalgo Regression introduced in release => main
2016-10-14 12:33 lorenzofidalgo Triggers an Emergency Pack => No
2016-10-14 12:56 lorenzofidalgo Web browser Google Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2016-10-14 12:56 lorenzofidalgo Assigned To Triage Finance => asiermartirena
2016-10-18 11:24 aferraz Relationship added caused by 0034038
2016-10-18 11:26 aferraz Web browser Google Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2016-10-18 11:26 aferraz Regression level Automated tests => Packaging and release
2016-10-18 11:26 aferraz Regression date => 2016-10-05
2016-10-18 11:26 aferraz Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/89f61788c100 [^]
2016-10-18 11:26 aferraz Status new => scheduled
2016-10-18 11:46 hgbot Checkin
2016-10-18 11:46 hgbot Note Added: 0090664
2016-10-18 11:46 hgbot Status scheduled => resolved
2016-10-18 11:46 hgbot Resolution open => fixed
2016-10-18 11:46 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6ae94a6a873d6f64801ec5a08a323fe3d9c583f6 [^]
2016-10-21 13:34 hgbot Checkin
2016-10-21 13:34 hgbot Note Added: 0090768
2016-10-21 13:40 aferraz Review Assigned To => aferraz
2016-10-21 13:40 aferraz Note Added: 0090769
2016-10-21 13:40 aferraz Status resolved => closed
2016-10-21 13:40 aferraz Fixed in Version => 3.0PR17Q1
2016-12-16 18:37 hudsonbot Checkin
2016-12-16 18:37 hudsonbot Note Added: 0092530
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092542

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker