Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034207Openbravo ERP09. Financial managementpublic2016-10-14 12:332016-12-16 18:38
Reporterlorenzofidalgo 
Assigned Toasiermartirena 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browserGoogle Chrome, Mozilla Firefox
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2016-10-05
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/89f61788c100 [^]
Triggers an Emergency PackNo
Summary0034207: Document no. sequence is no longer respected when Payment with "Amount = 0.00" is involved
DescriptionWhen a record is generated, it automatically sets the following number of the last record created. Now, when a Payment is created with "Amount = 0.00" the string "*Z*" is concatenated. This induces the Document no. does not set the following number and it is duplicated instead.
Steps To Reproduce1-Go to "Payment In" window.
2-Click "Create a new record in a form" button and memorize the "Document No.".
3-Changing no values (it is important Amount = 0.00, as it is by default), click again in "Create a new record in a form" and change the number that appears in "Document No." field by the number of the just saved record. (It is required, usually, only decrement a unit). Save the record.
4-Go to grid view and realise there are two records with the same document number (finished with *Z*). Sequential document numbers have not been created.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00342293.0PR16Q4 closed asiermartirena Document no. sequence is no longer respected when Payment with "Amount = 0.00" is involved 
caused by defect 00340383.0PR16Q4 closed umartirena Payments created with amount 0.00 need to be numbered as *R* (same as netting payment from cancel and replace) 
Attached Filespng docno.png (81,183) 2016-10-14 12:33
https://issues.openbravo.com/file_download.php?file_id=9913&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-10-14 12:33lorenzofidalgoNew Issue
2016-10-14 12:33lorenzofidalgoAssigned To => Triage Finance
2016-10-14 12:33lorenzofidalgoFile Added: docno.png
2016-10-14 12:33lorenzofidalgoOBNetwork customer => No
2016-10-14 12:33lorenzofidalgoWeb browser => Google Chrome, Mozilla Firefox
2016-10-14 12:33lorenzofidalgoModules => Core
2016-10-14 12:33lorenzofidalgoRegression level => Automated tests
2016-10-14 12:33lorenzofidalgoRegression introduced in release => main
2016-10-14 12:33lorenzofidalgoTriggers an Emergency Pack => No
2016-10-14 12:56lorenzofidalgoWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2016-10-14 12:56lorenzofidalgoAssigned ToTriage Finance => asiermartirena
2016-10-18 11:24aferrazRelationship addedcaused by 0034038
2016-10-18 11:26aferrazWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2016-10-18 11:26aferrazRegression levelAutomated tests => Packaging and release
2016-10-18 11:26aferrazRegression date => 2016-10-05
2016-10-18 11:26aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/89f61788c100 [^]
2016-10-18 11:26aferrazStatusnew => scheduled
2016-10-18 11:46hgbotCheckin
2016-10-18 11:46hgbotNote Added: 0090664
2016-10-18 11:46hgbotStatusscheduled => resolved
2016-10-18 11:46hgbotResolutionopen => fixed
2016-10-18 11:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6ae94a6a873d6f64801ec5a08a323fe3d9c583f6 [^]
2016-10-21 13:34hgbotCheckin
2016-10-21 13:34hgbotNote Added: 0090768
2016-10-21 13:40aferrazReview Assigned To => aferraz
2016-10-21 13:40aferrazNote Added: 0090769
2016-10-21 13:40aferrazStatusresolved => closed
2016-10-21 13:40aferrazFixed in Version => 3.0PR17Q1
2016-12-16 18:37hudsonbotCheckin
2016-12-16 18:37hudsonbotNote Added: 0092530
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092542

Notes
(0090664)
hgbot   
2016-10-18 11:46   
Repository: erp/devel/pi
Changeset: 6ae94a6a873d6f64801ec5a08a323fe3d9c583f6
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Tue Oct 18 11:45:46 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6ae94a6a873d6f64801ec5a08a323fe3d9c583f6 [^]

Fixed issue 34207: The sequence to create payments docNo was not correctly updated

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_PaymentEventListener.java
---
(0090768)
hgbot   
2016-10-21 13:34   
Repository: erp/devel/pi
Changeset: 380d8ab86ea44c1a12adaf65820ec53548836f83
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 21 12:56:10 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/380d8ab86ea44c1a12adaf65820ec53548836f83 [^]

Related to issue 34207: Code review improvements

Throw error only if we are not reactivating payment in APRM_FIN_PMT_CHECK_TRG trigger.
Remove onSave event in FIN_PaymentEventListener.
Zero payment sufix will only be added in case we are processing the payment and it will only be removed in case we are reactivating the payment.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_PMT_CHECK_TRG.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_PaymentEventListener.java
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0090769)
aferraz   
2016-10-21 13:40   
Code review + Testing OK
(0092530)
hudsonbot   
2016-12-16 18:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092542)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test