Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0034102

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

design defect

[Openbravo ERP] Y. DBSourceManager

minor

always

2016-09-27 16:47

2017-10-09 12:04

Reporter

caristu

View Status

public

Assigned To

platform

Priority

normal

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

caristu

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0034102: Update.database and Install.Source tasks should use the same flow to create the database and the db model

Description

Update.database and Install.Source tasks should use the same flow to create the database and the db model. Currently there is duplicated code that is handling those tasks separately. This causes that the behavior is different when applying some model changes.

For example, currently DB Source Manager supports the exportation of the following changes into a Configuration Script[1]:

- Remove Trigger
- Column Required
- Column Size
- Column Data

But on install.source task it is only possible to apply these changes: Column Size, Column Data and Remove Check. See[2].

The Remove Check change is supported on install.source since the resolution of issue 0036137, but still it is being handled in a different flow from the update.database task.

[1] http://wiki.openbravo.com/wiki/ERP_2.50:Developers_Guide/How_To_Create_a_Configuration_Script [^]

[2] https://code.openbravo.com/erp/devel/dbsm-main/file/482384f24ab9/src/org/apache/ddlutils/platform/SqlBuilder.java#l4504 [^]

Steps To Reproduce

1) Create a new Template and place the attached configuration script into the src-db/database folder. Notice that the config script is intended to turn into false the required property of the C_CURRENCY_ID column in the A_AMORTIZATION_TABLE
2) Run install.source. Notice that the C_CURRENCY_ID is still mandatory --> check the database: the change has NOT been applied
3) Run ant update.database. Notice that the C_CURRENCY_ID is not mandatory --> check the database: the change has been applied

Tags

No tags attached.

configScript.xml [^] (188 bytes) 2016-09-27 16:47

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0033417	3.0PR17Q1	closed	caristu	Loading config script for a module template in install.source task fails in pgsql 9.3
related to	defect	0036137		closed	inigosanchez	[SER-QA 2918] Config script removeCheckChange are not applied on install.source
related to	defect	0034131		closed	alostale	can't export database in verbose mode if there's a config script changing a column to nullable

Notes
(0097257) inigosanchez (developer) 2017-06-08 20:48	Remove check is now supported on the install.source task. See issue 0036137

(0099824) caristu (developer) 2017-10-09 12:04	fixed by 0036137

Issue History
Date Modified	Username	Field	Change
2016-09-27 16:47	caristu	New Issue
2016-09-27 16:47	caristu	Assigned To	=> platform
2016-09-27 16:47	caristu	Modules	=> Core
2016-09-27 16:47	caristu	Triggers an Emergency Pack	=> No
2016-09-27 16:47	caristu	File Added: configScript.xml
2016-09-27 16:49	caristu	Steps to Reproduce Updated	View Revisions
2016-09-27 16:49	caristu	Steps to Reproduce Updated	View Revisions
2016-09-27 16:50	caristu	Relationship added	related to 0033417
2016-09-29 09:27	alostale	Status	new => acknowledged
2016-09-29 16:21	caristu	Category	A. Platform => Y. DBSourceManager
2016-09-30 09:28	alostale	Relationship added	related to 0034131
2016-12-01 13:20	alostale	Priority	high => normal
2017-06-06 17:43	inigosanchez	Relationship added	related to 0036137
2017-06-08 13:19	caristu	Type	defect => design defect
2017-06-08 13:19	caristu	Summary	Some config script changes are not applied during install.source => Update.database and Install.Source tasks should use the same flow to create the database and the db model
2017-06-08 13:19	caristu	Description Updated	View Revisions
2017-06-08 20:48	inigosanchez	Note Added: 0097257
2017-06-08 20:48	inigosanchez	Description Updated	View Revisions
2017-10-09 12:04	caristu	Status	acknowledged => scheduled
2017-10-09 12:04	caristu	Review Assigned To	=> caristu
2017-10-09 12:04	caristu	Note Added: 0099824
2017-10-09 12:04	caristu	Status	scheduled => closed
2017-10-09 12:04	caristu	Resolution	open => fixed

Copyright © 2000 - 2009 MantisBT Group