0034102: Update.database and Install.Source tasks should use the same flow to create the database and the db model

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0034102

Openbravo ERP

Y. DBSourceManager

public

2016-09-27 16:47

2017-10-09 12:04

Reporter

caristu

Assigned To

platform

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0034102: Update.database and Install.Source tasks should use the same flow to create the database and the db model

Description

Update.database and Install.Source tasks should use the same flow to create the database and the db model. Currently there is duplicated code that is handling those tasks separately. This causes that the behavior is different when applying some model changes.

For example, currently DB Source Manager supports the exportation of the following changes into a Configuration Script[1]:

- Remove Trigger
- Column Required
- Column Size
- Column Data

But on install.source task it is only possible to apply these changes: Column Size, Column Data and Remove Check. See[2].

The Remove Check change is supported on install.source since the resolution of issue 0036137, but still it is being handled in a different flow from the update.database task.

[1] http://wiki.openbravo.com/wiki/ERP_2.50:Developers_Guide/How_To_Create_a_Configuration_Script [^]

[2] https://code.openbravo.com/erp/devel/dbsm-main/file/482384f24ab9/src/org/apache/ddlutils/platform/SqlBuilder.java#l4504 [^]

Steps To Reproduce

1) Create a new Template and place the attached configuration script into the src-db/database folder. Notice that the config script is intended to turn into false the required property of the C_CURRENCY_ID column in the A_AMORTIZATION_TABLE
2) Run install.source. Notice that the C_CURRENCY_ID is still mandatory --> check the database: the change has NOT been applied
3) Run ant update.database. Notice that the C_CURRENCY_ID is not mandatory --> check the database: the change has been applied

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0033417	3.0PR17Q1	closed	caristu	Loading config script for a module template in install.source task fails in pgsql 9.3
related to	defect	0036137		closed	inigosanchez	[SER-QA 2918] Config script removeCheckChange are not applied on install.source
related to	defect	0034131		closed	alostale	can't export database in verbose mode if there's a config script changing a column to nullable