Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034097
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementminoralways2016-09-27 11:192018-06-08 07:30
ReportermarvintmView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q3
StatusclosedFix in branchFixed in SCM revision7ad03320bc04
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket530
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034097: In Sales Order (and Purchase Order), the Add Payment button is visible in cases it should not be

DescriptionThe Add Payment button in the Sales Order window should only be visible in case adding a new payment to the selected order would make sense. However, currently there is at least one case in which it's visible in orders which should not accept payments.

For example, in case an order has total amount zero, adding payments to it doesn't make sense, and the button is visible for them.
Steps To Reproduce- Create a new sales order, and add some lines.
- Void this sales order. In this case, the total amount of the order is now zero.
- Notice that the Add Payment button is still visible, and it should not be.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0038047 closedranjith_qualiantech_com Retail Modules Invoices associated with tickets paid completely by Gift Cards are shown as not paid 

-  Notes
(0090540)
nonofrancisco (viewer)
2016-10-12 18:54

 Test Plan

As Openbravo/openbravo

- Create a new Sales Order
    Add some lines
        Book the order
        Realize the button Add Payment is visible
        Click on the Close button and close the order
        Realize the Total Gross Amount is zero and the button Add Payment is not visible
        
Follow the steps above with a Purchase Order and realize that behave the same.
(0104977)
dmiguelez (viewer)
2018-06-06 13:15

 Test Plan

As Openbravo/openbravo

- Create a new Sales Order
    Add some lines
        Book the order
        Realize the button Add Payment is visible
        Click on add Payment button and process the payment
        Realize the button Add Payment is not visible
        
Follow the steps above with a Purchase Order and realize that behave the same.

Follow same steps with a partial payment. While the payment is partial, the button is still visible
(0104992)
hgbot (developer)
2018-06-07 09:10

 Repository: erp/devel/pi
Changeset: 7ad03320bc04a61e4628d28345a6dfa3b2c6d4e4
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Oct 10 15:03:19 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/7ad03320bc04a61e4628d28345a6dfa3b2c6d4e4 [^]

Fixes issue 34097: The Add Payment button is visible in cases it should not be

Display logic of field "Add Payment" in "Sales Order" and "Purchase Order" windows
has been updated. Also the auxiliary input "showAddPayment" has been defined for
"Header" tab on "Sales Order" and "Purchase Order" windows.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
---
(0104993)
hgbot (developer)
2018-06-07 09:10

 Repository: erp/devel/pi
Changeset: 07e8ea54f1199bdb4a4ded864f64adaf5c3b5bca
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 06 16:13:55 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/07e8ea54f1199bdb4a4ded864f64adaf5c3b5bca [^]

Related to Issue 34097. Added GrandTotal column to the Stored
in Session values.

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0104994)
dmiguelez (viewer)
2018-06-07 09:21

 Code Review + Testing Ok
(0105019)
hudsonbot (viewer)
2018-06-08 07:30

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4e0c05c97edf [^]
Maturity status: Test
(0105020)
hudsonbot (viewer)
2018-06-08 07:30

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4e0c05c97edf [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-09-27 11:19 marvintm New Issue
2016-09-27 11:19 marvintm Assigned To => Triage Finance
2016-09-27 11:19 marvintm OBNetwork customer => No
2016-09-27 11:19 marvintm Modules => Core
2016-09-27 11:19 marvintm Triggers an Emergency Pack => No
2016-09-27 11:31 marvintm OBNetwork customer No => Yes
2016-09-27 15:20 heccam Issue Monitored: heccam
2016-10-10 19:39 nonofrancisco Assigned To Triage Finance => nonofrancisco
2016-10-10 19:40 nonofrancisco Status new => scheduled
2016-10-12 18:54 nonofrancisco Note Added: 0090540
2018-03-23 09:23 ngarcia Relationship added related to 0038047
2018-03-23 09:24 ngarcia Issue Monitored: ngarcia
2018-03-23 09:25 ngarcia Support ticket => 530
2018-05-29 11:14 ngarcia Assigned To nonofrancisco => Triage Finance
2018-05-31 08:45 dmiguelez Assigned To Triage Finance => AtulOpenbravo
2018-06-06 13:15 dmiguelez Note Added: 0104977
2018-06-07 09:10 hgbot Checkin
2018-06-07 09:10 hgbot Note Added: 0104992
2018-06-07 09:10 hgbot Status scheduled => resolved
2018-06-07 09:10 hgbot Resolution open => fixed
2018-06-07 09:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7ad03320bc04a61e4628d28345a6dfa3b2c6d4e4 [^]
2018-06-07 09:10 hgbot Checkin
2018-06-07 09:10 hgbot Note Added: 0104993
2018-06-07 09:21 dmiguelez Review Assigned To => dmiguelez
2018-06-07 09:21 dmiguelez Note Added: 0104994
2018-06-07 09:21 dmiguelez Status resolved => closed
2018-06-07 09:22 dmiguelez Fixed in Version => 3.0PR18Q3
2018-06-08 07:30 hudsonbot Checkin
2018-06-08 07:30 hudsonbot Note Added: 0105019
2018-06-08 07:30 hudsonbot Checkin
2018-06-08 07:30 hudsonbot Note Added: 0105020

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker