Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034097Openbravo ERP07. Sales managementpublic2016-09-27 11:192018-06-08 07:30
Reportermarvintm 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034097: In Sales Order (and Purchase Order), the Add Payment button is visible in cases it should not be
DescriptionThe Add Payment button in the Sales Order window should only be visible in case adding a new payment to the selected order would make sense. However, currently there is at least one case in which it's visible in orders which should not accept payments.

For example, in case an order has total amount zero, adding payments to it doesn't make sense, and the button is visible for them.
Steps To Reproduce- Create a new sales order, and add some lines.
- Void this sales order. In this case, the total amount of the order is now zero.
- Notice that the Add Payment button is still visible, and it should not be.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038047 closed ranjith_qualiantech_com Retail Modules Invoices associated with tickets paid completely by Gift Cards are shown as not paid 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-27 11:19marvintmNew Issue
2016-09-27 11:19marvintmAssigned To => Triage Finance
2016-09-27 11:19marvintmModules => Core
2016-09-27 11:19marvintmTriggers an Emergency Pack => No
2016-09-27 15:20heccamIssue Monitored: heccam
2016-10-10 19:39nonofranciscoAssigned ToTriage Finance => nonofrancisco
2016-10-10 19:40nonofranciscoStatusnew => scheduled
2016-10-12 18:54nonofranciscoNote Added: 0090540
2018-03-23 09:23ngarciaRelationship addedrelated to 0038047
2018-03-23 09:24ngarciaIssue Monitored: ngarcia
2018-05-29 11:14ngarciaAssigned Tononofrancisco => Triage Finance
2018-05-31 08:45dmiguelezAssigned ToTriage Finance => AtulOpenbravo
2018-06-06 13:15dmiguelezNote Added: 0104977
2018-06-07 09:10hgbotCheckin
2018-06-07 09:10hgbotNote Added: 0104992
2018-06-07 09:10hgbotStatusscheduled => resolved
2018-06-07 09:10hgbotResolutionopen => fixed
2018-06-07 09:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7ad03320bc04a61e4628d28345a6dfa3b2c6d4e4 [^]
2018-06-07 09:10hgbotCheckin
2018-06-07 09:10hgbotNote Added: 0104993
2018-06-07 09:21dmiguelezReview Assigned To => dmiguelez
2018-06-07 09:21dmiguelezNote Added: 0104994
2018-06-07 09:21dmiguelezStatusresolved => closed
2018-06-07 09:22dmiguelezFixed in Version => 3.0PR18Q3
2018-06-08 07:30hudsonbotCheckin
2018-06-08 07:30hudsonbotNote Added: 0105019
2018-06-08 07:30hudsonbotCheckin
2018-06-08 07:30hudsonbotNote Added: 0105020

Notes
(0090540)
nonofrancisco   
2016-10-12 18:54   
Test Plan

As Openbravo/openbravo

- Create a new Sales Order
    Add some lines
        Book the order
        Realize the button Add Payment is visible
        Click on the Close button and close the order
        Realize the Total Gross Amount is zero and the button Add Payment is not visible
        
Follow the steps above with a Purchase Order and realize that behave the same.
(0104977)
dmiguelez   
2018-06-06 13:15   
Test Plan

As Openbravo/openbravo

- Create a new Sales Order
    Add some lines
        Book the order
        Realize the button Add Payment is visible
        Click on add Payment button and process the payment
        Realize the button Add Payment is not visible
        
Follow the steps above with a Purchase Order and realize that behave the same.

Follow same steps with a partial payment. While the payment is partial, the button is still visible
(0104992)
hgbot   
2018-06-07 09:10   
Repository: erp/devel/pi
Changeset: 7ad03320bc04a61e4628d28345a6dfa3b2c6d4e4
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Oct 10 15:03:19 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/7ad03320bc04a61e4628d28345a6dfa3b2c6d4e4 [^]

Fixes issue 34097: The Add Payment button is visible in cases it should not be

Display logic of field "Add Payment" in "Sales Order" and "Purchase Order" windows
has been updated. Also the auxiliary input "showAddPayment" has been defined for
"Header" tab on "Sales Order" and "Purchase Order" windows.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
---
(0104993)
hgbot   
2018-06-07 09:10   
Repository: erp/devel/pi
Changeset: 07e8ea54f1199bdb4a4ded864f64adaf5c3b5bca
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 06 16:13:55 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/07e8ea54f1199bdb4a4ded864f64adaf5c3b5bca [^]

Related to Issue 34097. Added GrandTotal column to the Stored
in Session values.

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0104994)
dmiguelez   
2018-06-07 09:21   
Code Review + Testing Ok
(0105019)
hudsonbot   
2018-06-08 07:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4e0c05c97edf [^]
Maturity status: Test
(0105020)
hudsonbot   
2018-06-08 07:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4e0c05c97edf [^]
Maturity status: Test